Summary

Ensure form registry is populated when adding or removing forms to pages

Review Request #8725 — Created Feb. 8, 2017 and submitted Feb. 14, 2017, 1:40 p.m.

Information

Owner

brennie

Repository

Djblets

Branch

release-0.10.x

Bugs

Depends On

Blocks

8729

Commit

33422a0...

Reviewers

Groups

djblets

People

Description

The ConfigPageRegistry was not populating the ConfigPageFormRegistry
when calling add_form_to_page or remove_form_from_page, which would
lead to issues when removing pages in tbe case that the method
was called before the registry was populated. We now specifically
populate the form registry to avoid this.

Testing Done

Ran unit tests. The new unit tests fail without this fix applied.

Tool: Pyflakes
Processed Files:
    djblets/configforms/registry.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/configforms/registry.py

Can we get a new test that fails before this change and succeeds after?

Change Summary:

Add unit tests.

Testing Done:

~		Ran unit tests.
	~	Ran unit tests. The new unit tests fail without this fix applied.

Diff:

Revision 2 (+2)

Show changes

djblets/configforms/registry.py

Tool: PEP8 Style Checker
Processed Files:
    djblets/configforms/registry.py



Tool: Pyflakes
Processed Files:
    djblets/configforms/registry.py

Change Summary:

Commit changes. Oops.

Diff:

Revision 3 (+75 -1)

Show changes

	djblets/configforms/registry.py
	djblets/configforms/tests.py

Tool: Pyflakes
Processed Files:
    djblets/configforms/registry.py
    djblets/configforms/tests.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/configforms/registry.py
    djblets/configforms/tests.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.10.x (4898c9f)