Ensure form registry is populated when adding or removing forms to pages

Review Request #8725 - Created Feb. 8, 2017 and submitted

Barret Rennie
Djblets
release-0.10.x
8729
33422a0...
djblets

The ConfigPageRegistry was not populating the ConfigPageFormRegistry
when calling add_form_to_page or remove_form_from_page, which would
lead to issues when removing pages in tbe case that the method
was called before the registry was populated. We now specifically
populate the form registry to avoid this.

Ran unit tests. The new unit tests fail without this fix applied.

Review Bot
  1. Tool: Pyflakes
    Processed Files:
        djblets/configforms/registry.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/configforms/registry.py
    
    
  2. 
      
David Trowbridge
  1. Can we get a new test that fails before this change and succeeds after?

  2. 
      
Barret Rennie
Review Bot
  1. Tool: PEP8 Style Checker
    Processed Files:
        djblets/configforms/registry.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        djblets/configforms/registry.py
    
    
  2. 
      
Barret Rennie
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        djblets/configforms/registry.py
        djblets/configforms/tests.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/configforms/registry.py
        djblets/configforms/tests.py
    
    
  2. 
      
David Trowbridge
  1. Ship It!
  2. 
      
Barret Rennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.10.x (4898c9f)
Loading...