Summary

Do not render the avatar service form when there are no services

Review Request #8729 — Created Feb. 8, 2017 and submitted Feb. 14, 2017, 1:42 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

~~8725~~, ~~8727~~, ~~8726~~

Reviewers

Groups

reviewboard

People

Description

We now take into account the number of enabled services when calculating
the visibility of the avatar settings form. In addition, due to recent
changes to Djblets (see /r/8726 and /r/8728), we no longer have to add or
remove the avatar services form to the configuration page (due to
ConfigPageForm.is_visible() evlauating to False causing the form to
not render). This allows the logic of the avatar services admin form to
be simplified.

Testing Done

Viewed account page with avatars enabled but no enabled services. The
page did not raise an exception and the form was not visible.

Issues

Description	From	Last Updated
'AvatarSettingsForm' imported but unused	reviewbot	Feb. 8, 2017, 4:47 p.m.
'AccountPage' imported but unused	reviewbot	Feb. 8, 2017, 4:47 p.m.
'ProfilePage' imported but unused	reviewbot	Feb. 8, 2017, 4:47 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/admin/forms.py
    reviewboard/accounts/forms/pages.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/forms.py
    reviewboard/accounts/forms/pages.py

reviewboard/admin/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'AvatarSettingsForm' imported but unused
```
reviewboard/admin/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'AccountPage' imported but unused
```
reviewboard/admin/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'ProfilePage' imported but unused
```

Change Summary:

Remove unused imports.

Diff:

Revision 2 (+2 -13)

Show changes

	reviewboard/accounts/forms/pages.py
	reviewboard/admin/forms.py

Tool: Pyflakes
Processed Files:
    reviewboard/admin/forms.py
    reviewboard/accounts/forms/pages.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/forms.py
    reviewboard/accounts/forms/pages.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (980df4f)

reviewboard/admin/forms.py (Diff revision 1)

reviewboard/admin/forms.py (Diff revision 1)

reviewboard/admin/forms.py (Diff revision 1)