Use the avatar services in the user infobox ETag

Review Request #8567 - Created Dec. 12, 2016 and submitted

Barret Rennie
Review Board
release-3.0.x
4499
8566
b9027f8...
reviewboard

Ther user infobox was previously using the e-mail address of users in
ETag calculation because all avatars were Gravatars, which are based off
e-mail addresses. However, now that we have more avatar services
available, data specific to each service must be used to calculate ETag.

Updated the avatar service configuration for a user and saw that the
infobox returned an uncached response.

  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/views.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/views.py
    
    
  2. 
      
David Trowbridge
  1. 
      
  2. reviewboard/reviews/views.py (Diff revision 1)
     
     

    We should leave this in, because the e-mail address is visible in the infobox.

  3. reviewboard/reviews/views.py (Diff revision 1)
     
     
     
     
     
     
     
     

    If you just nested the if avatar_service: check into the avatars_enabled check you could eliminate the default None assignment.

  4. 
      
Barret Rennie
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/views.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/views.py
    
    
  2. 
      
David Trowbridge
  1. Ship It!
  2. 
      
Barret Rennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (6d91661)
Loading...