Use the avatar services in the user infobox ETag
Review Request #8567 - Created Dec. 12, 2016 and submitted
| Information | |
|---|---|
| Barret Rennie | |
| Review Board | |
| release-3.0.x | |
| 4499 | |
| b9027f8... | |
| Reviewers | |
| reviewboard | |
Ther user infobox was previously using the e-mail address of users in
ETag calculation because all avatars were Gravatars, which are based off
e-mail addresses. However, now that we have more avatar services
available, data specific to each service must be used to calculate ETag.
Updated the avatar service configuration for a user and saw that the
infobox returned an uncached response.
David Trowbridge
-
-
reviewboard/reviews/views.py (Diff revision 1) We should leave this in, because the e-mail address is visible in the infobox.
-
reviewboard/reviews/views.py (Diff revision 1) If you just nested the
if avatar_service:check into theavatars_enabledcheck you could eliminate the defaultNoneassignment.
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py
-
Ship It!
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py