Summary

Use the avatar services in the user infobox ETag

Review Request #8567 — Created Dec. 12, 2016 and submitted Dec. 16, 2016, 2:13 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-3.0.x

Bugs

4499

Depends On

~~8566~~

Commit

b9027f8...

Reviewers

Groups

reviewboard

People

Description

Ther user infobox was previously using the e-mail address of users in
ETag calculation because all avatars were Gravatars, which are based off
e-mail addresses. However, now that we have more avatar services
available, data specific to each service must be used to calculate ETag.

Testing Done

Updated the avatar service configuration for a user and saw that the
infobox returned an uncached response.

Issues

Description	From	Last Updated
We should leave this in, because the e-mail address is visible in the infobox.	david	Dec. 15, 2016, 12:08 p.m.
If you just nested the if avatar_service: check into the avatars_enabled check you could eliminate the default None assignment.	david	Dec. 15, 2016, 12:08 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py

reviewboard/reviews/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
We should leave this in, because the e-mail address is visible in the infobox.
```

reviewboard/reviews/views.py (Diff revision 1)

The issue has been resolved. Show all issues

If you just nested the if avatar_service: check into the avatars_enabled check you could eliminate the default None assignment.

Change Summary:

Addressed David's issues

Diff:

Revision 2 (+7)

Show changes

reviewboard/reviews/views.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (6d91661)