Add a hook to register avatar services

Review Request #8531 - Created Nov. 7, 2016 and submitted

Barret Rennie
Review Board
release-3.0.x
8530
reviewboard

The AvatarServiceHook is a new hook for adding avatar service classes
to the avatar services registry. It is a thin wrapper around Djblets'
RegistryHook, which is a generic hook base class for adding items to
registries from extensions.

Ran unit tests.

  • 0
  • 0
  • 4
  • 0
  • 4
Description From Last Updated
Review Bot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/extensions/hooks.py
        reviewboard/extensions/tests.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/extensions/hooks.py
        reviewboard/extensions/tests.py
    
    
  2. 
      
David Trowbridge
  1. 
      
  2. reviewboard/extensions/hooks.py (Diff revision 1)
     
     
     
     
     

    This is getting long enough that we should probably list one per line.

  3. reviewboard/extensions/hooks.py (Diff revision 1)
     
     
     

    It looks to me like this init function doesn't actually do anything. Can we get rid of it?

  4. 
      
Barret Rennie
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/extensions/hooks.py
        reviewboard/extensions/tests.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/extensions/hooks.py
        reviewboard/extensions/tests.py
    
    
  2. 
      
Christian Hammond
  1. 
      
  2. reviewboard/extensions/hooks.py (Diff revision 2)
     
     

    Missing the : on :py:class:

  3. reviewboard/extensions/tests.py (Diff revision 2)
     
     

    This should also check shutting down the hook.

  4. 
      
Barret Rennie
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/extensions/hooks.py
        reviewboard/extensions/tests.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/extensions/hooks.py
        reviewboard/extensions/tests.py
    
    
  2. 
      
David Trowbridge
  1. Ship It!
  2. 
      
Barret Rennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (73a6c53)
Loading...