Summary

Add a hook to register avatar services

Review Request #8531 — Created Nov. 7, 2016 and submitted Nov. 29, 2016, 4:57 a.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

~~8530~~

Reviewers

Groups

reviewboard

People

Description

The AvatarServiceHook is a new hook for adding avatar service classes

to the avatar services registry. It is a thin wrapper around Djblets'

RegistryHook, which is a generic hook base class for adding items to

registries from extensions.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
This is getting long enough that we should probably list one per line.	david	Nov. 9, 2016, 3:18 p.m.
It looks to me like this init function doesn't actually do anything. Can we get rid of it?	david	Nov. 9, 2016, 3:20 p.m.
Missing the : on :py:class:	chipx86	Nov. 16, 2016, 8:46 p.m.
This should also check shutting down the hook.	chipx86	Nov. 16, 2016, 8:49 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/hooks.py
    reviewboard/extensions/tests.py



Tool: Pyflakes
Processed Files:
    reviewboard/extensions/hooks.py
    reviewboard/extensions/tests.py

reviewboard/extensions/hooks.py (Diff revision 1)

Show all issues

This is getting long enough that we should probably list one per line.

reviewboard/extensions/hooks.py (Diff revision 1)

Show all issues

It looks to me like this init function doesn't actually do anything. Can we get rid of it?

Diff:

Revision 2 (+67 -3)

Show changes

	reviewboard/extensions/hooks.py
	reviewboard/extensions/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/extensions/hooks.py
    reviewboard/extensions/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/hooks.py
    reviewboard/extensions/tests.py

reviewboard/extensions/hooks.py (Diff revision 2)
Show all issues
```
Missing the : on :py:class:
```
reviewboard/extensions/tests.py (Diff revision 2)
Show all issues
```
This should also check shutting down the hook.
```

Diff:

Revision 3 (+77 -3)

Show changes

	reviewboard/extensions/hooks.py
	reviewboard/extensions/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/extensions/hooks.py
    reviewboard/extensions/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/hooks.py
    reviewboard/extensions/tests.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (73a6c53)