Add a hook to register avatar services

Review Request #8531 — Created Nov. 7, 2016 and submitted

Information

Review Board
release-3.0.x

Reviewers

The AvatarServiceHook is a new hook for adding avatar service classes
to the avatar services registry. It is a thin wrapper around Djblets'
RegistryHook, which is a generic hook base class for adding items to
registries from extensions.

Ran unit tests.

Description From Last Updated

This is getting long enough that we should probably list one per line.

daviddavid

It looks to me like this init function doesn't actually do anything. Can we get rid of it?

daviddavid

Missing the : on :py:class:

chipx86chipx86

This should also check shutting down the hook.

chipx86chipx86
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/extensions/hooks.py
        reviewboard/extensions/tests.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/extensions/hooks.py
        reviewboard/extensions/tests.py
    
    
  2. 
      
david
  1. 
      
  2. reviewboard/extensions/hooks.py (Diff revision 1)
     
     
     
     
     
    Show all issues

    This is getting long enough that we should probably list one per line.

  3. reviewboard/extensions/hooks.py (Diff revision 1)
     
     
     
    Show all issues

    It looks to me like this init function doesn't actually do anything. Can we get rid of it?

  4. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/extensions/hooks.py
        reviewboard/extensions/tests.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/extensions/hooks.py
        reviewboard/extensions/tests.py
    
    
  2. 
      
chipx86
  1. 
      
  2. reviewboard/extensions/hooks.py (Diff revision 2)
     
     
    Show all issues

    Missing the : on :py:class:

  3. reviewboard/extensions/tests.py (Diff revision 2)
     
     
    Show all issues

    This should also check shutting down the hook.

  4. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/extensions/hooks.py
        reviewboard/extensions/tests.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/extensions/hooks.py
        reviewboard/extensions/tests.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
brennie
Review request changed
Status:
Completed
Change Summary:
Pushed to release-3.0.x (73a6c53)