Summary

Add a RegistryHook base class

Review Request #8530 — Created Nov. 7, 2016 and submitted Nov. 29, 2016, 4:54 a.m.

Information

Owner

brennie

Repository

Djblets

Branch

release-0.10.x

Bugs

Depends On

Blocks

8531

Reviewers

Groups

djblets

People

Description

The RegistryHook is a base class that handles registration and

unregistration of items from registries. Subclasses can set the

specific registry to use.
Tests have been added to ensure that the hook correctly registers

items.

Testing Done


Ran unit tests.
Used this in /r/8531.

Issues

Description	From	Last Updated
Can you add a docstring for this?	david	Nov. 9, 2016, 3:03 p.m.
Can we call this BaseRegistryHook, since it's not meant to be used directly?	chipx86	Nov. 16, 2016, 8:41 p.m.
:py:attr:	chipx86	Nov. 16, 2016, 8:41 p.m.
We should test unregistration too.	chipx86	Nov. 16, 2016, 8:42 p.m.

Tool: Pyflakes
Processed Files:
    djblets/extensions/hooks.py
    djblets/extensions/tests.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/extensions/hooks.py
    djblets/extensions/tests.py

djblets/extensions/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can you add a docstring for this?
```

Diff:

Revision 2 (+65 -2)

Show changes

	djblets/extensions/hooks.py
	djblets/extensions/tests.py

Tool: Pyflakes
Processed Files:
    djblets/extensions/hooks.py
    djblets/extensions/tests.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/extensions/hooks.py
    djblets/extensions/tests.py

djblets/extensions/hooks.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can we call this BaseRegistryHook, since it's not meant to be used directly?
```
djblets/extensions/hooks.py (Diff revision 2)
The issue has been resolved. Show all issues
```
:py:attr:
```
djblets/extensions/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
We should test unregistration too.
```

Diff:

Revision 3 (+74 -2)

Show changes

	djblets/extensions/hooks.py
	djblets/extensions/tests.py

Tool: Pyflakes
Processed Files:
    djblets/extensions/hooks.py
    djblets/extensions/tests.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/extensions/hooks.py
    djblets/extensions/tests.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.10.x (75e5630)

djblets/extensions/tests.py (Diff revision 1)

djblets/extensions/hooks.py (Diff revision 2)

djblets/extensions/hooks.py (Diff revision 2)

djblets/extensions/tests.py (Diff revision 2)