Add a review request hover preview.
Review Request #8508 — Created Oct. 30, 2016 and discarded
When the cursor moves over top of a review request in the dashboard a small
preview of the review request will be shown, similar to the user preview box.
Added 2 unit tests, checked infobox on dashboard, all review requests
and user pages.
| Description | From | Last Updated |
|---|---|---|
|
Missing "Args" and "Returns" sections in docstring. |
 brennie
|
|
|
This is incorrect. This would have to be calc(@z-index-dialog + 1). However, this should be its own constant. |
brennie
|
|
|
These should probably be constants. |
brennie
|
|
|
This should be the first selector under .localtime. |
brennie
|
|
|
Where does this value come from? |
brennie
|
|
|
user, and |
brennie
|
|
|
Where is the corresponding {% spaceless %} start tag? |
brennie
|
|
|
Indentation is off. |
brennie
|
|
|
Need to change this so that it doesn't have to guess about location of href |
ST stensby | |
|
Try deleting lines 605 to 611 here to fix your hover problem. :) |
 imadueme
|
|
|
unicode |
brennie
|
|
|
unicode |
brennie
|
|
|
Alphabetical order. |
brennie
|
|
|
Missing docstring. |
brennie
|
|
|
Testing docstrings can be of the form: """Testing some really_long_function does something specific """ |
brennie
|
|
|
"Display" |
brennie
|
|
|
"The infobox" over "this". |
brennie
|
|
|
arg (type): not arg: (type): |
brennie
|
|
|
int |
brennie
|
|
|
ID |
brennie
|
|
|
django.http.HttpResponse is the type. |
brennie
|
|
|
.classes before elements, so this should be ordered as: a {} h3 {} .infobox-extra {} .infobox-text {} |
brennie
|
|
|
Revert changes to this file |
ST stensby | |
|
Undo this. |
brennie
|
|
|
Can you remove the "right now" |
brennie
|
|
|
Is the whitespace here for a reason? |
brennie
|
|
|
Templates should be indented as with single spacing and the opening brace of block tags (e.g., {% if %}, etc.) … |
brennie
|
ST
- Commit:
-
05da286c4d4f5e479d5bd41be0f322b93a949983f79648b2f169d143bdc7fd731c6b676d5fad02bd
- Diff:
-
Revision 2 (+309 -7)
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/extensions/hooks.py reviewboard/reviews/urls.py Ignored Files: reviewboard/static/rb/js/ui/views/infoboxView.es6.js reviewboard/templates/reviews/review_request_infobox.html reviewboard/static/rb/css/common.less reviewboard/static/rb/js/common.es6.js Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/extensions/hooks.py reviewboard/reviews/urls.py Ignored Files: reviewboard/static/rb/js/ui/views/infoboxView.es6.js reviewboard/templates/reviews/review_request_infobox.html reviewboard/static/rb/css/common.less reviewboard/static/rb/js/common.es6.js
ST
- Commit:
-
f79648b2f169d143bdc7fd731c6b676d5fad02bd5e0f1a45cba7e8bf57c39e2878ed43214ab70e34
- Diff:
-
Revision 3 (+262 -7)
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/extensions/hooks.py reviewboard/reviews/urls.py Ignored Files: reviewboard/static/rb/js/ui/views/infoboxView.es6.js reviewboard/templates/reviews/review_request_infobox.html reviewboard/static/rb/css/common.less reviewboard/static/rb/js/common.es6.js Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/extensions/hooks.py reviewboard/reviews/urls.py Ignored Files: reviewboard/static/rb/js/ui/views/infoboxView.es6.js reviewboard/templates/reviews/review_request_infobox.html reviewboard/static/rb/css/common.less reviewboard/static/rb/js/common.es6.js
ST
- Change Summary:
-
Fixed infobox attachment point to match other infoboxes, continuing debug work on small pixel difference compared to user infobocx.
- Commit:
-
5e0f1a45cba7e8bf57c39e2878ed43214ab70e348ca01325477b2f691ba59f516905558e778601c7
- Diff:
-
Revision 4 (+267 -7)
-
Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/extensions/hooks.py reviewboard/datagrids/columns.py reviewboard/reviews/urls.py Ignored Files: reviewboard/templates/reviews/review_request_infobox.html reviewboard/static/rb/js/common.es6.js reviewboard/static/rb/css/ui/datagrids.less reviewboard/static/rb/css/common.less reviewboard/static/rb/js/ui/views/infoboxView.es6.js reviewboard/templates/datagrids/summary_cell.html Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/extensions/hooks.py reviewboard/datagrids/columns.py reviewboard/reviews/urls.py Ignored Files: reviewboard/templates/reviews/review_request_infobox.html reviewboard/static/rb/js/common.es6.js reviewboard/static/rb/css/ui/datagrids.less reviewboard/static/rb/css/common.less reviewboard/static/rb/js/ui/views/infoboxView.es6.js reviewboard/templates/datagrids/summary_cell.html
ST
- Change Summary:
-
Added unit test.
- Summary:
-
[WIP] Add a review request hover preview.Add a review request hover preview.
- Testing Done:
-
+ Added 2 unit tests, checked infobox on dashboard, all review requests
+ and user page. - Commit:
-
8ca01325477b2f691ba59f516905558e778601c7ad9a48f989d43e1124ec898e64b843dd2ba278ef
- Diff:
-
Revision 5 (+326 -8)
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests/test_views.py reviewboard/extensions/hooks.py reviewboard/datagrids/columns.py reviewboard/reviews/urls.py Ignored Files: reviewboard/templates/reviews/review_request_infobox.html reviewboard/static/rb/js/common.es6.js reviewboard/static/rb/css/ui/datagrids.less reviewboard/static/rb/css/common.less reviewboard/static/rb/js/ui/views/infoboxView.es6.js reviewboard/templates/datagrids/summary_cell.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests/test_views.py reviewboard/extensions/hooks.py reviewboard/datagrids/columns.py reviewboard/reviews/urls.py Ignored Files: reviewboard/templates/reviews/review_request_infobox.html reviewboard/static/rb/js/common.es6.js reviewboard/static/rb/css/ui/datagrids.less reviewboard/static/rb/css/common.less reviewboard/static/rb/js/ui/views/infoboxView.es6.js reviewboard/templates/datagrids/summary_cell.html
ST
- Change Summary:
-
Slight tweak to docstring
- Commit:
-
ad9a48f989d43e1124ec898e64b843dd2ba278ef0c16907ccdee121e460c1ccae6795a8e3d717482
- Diff:
-
Revision 6 (+329 -8)
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests/test_views.py reviewboard/extensions/hooks.py reviewboard/datagrids/columns.py reviewboard/reviews/urls.py Ignored Files: reviewboard/templates/reviews/review_request_infobox.html reviewboard/static/rb/js/common.es6.js reviewboard/static/rb/css/ui/datagrids.less reviewboard/static/rb/css/common.less reviewboard/static/rb/js/ui/views/infoboxView.es6.js reviewboard/templates/datagrids/summary_cell.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests/test_views.py reviewboard/extensions/hooks.py reviewboard/datagrids/columns.py reviewboard/reviews/urls.py Ignored Files: reviewboard/templates/reviews/review_request_infobox.html reviewboard/static/rb/js/common.es6.js reviewboard/static/rb/css/ui/datagrids.less reviewboard/static/rb/css/common.less reviewboard/static/rb/js/ui/views/infoboxView.es6.js reviewboard/templates/datagrids/summary_cell.html
-
-
-
-
-
-
Testing docstrings can be of the form:
"""Testing some really_long_function does something specific """ -
-
-
-
-
-
-
.classesbeforeelements, so this should be ordered as:a {} h3 {} .infobox-extra {} .infobox-text {} -
-
-
-
Templates should be indented as with single spacing and the opening brace of block tags (e.g.,
{% if %}, etc.) should be left aligned, such as:<div class="foo"> <div class="bar"> {% if foo %} {% if bar %} bar {% endif %} {% endif %} </div> </div>
ST
- Change Summary:
-
Addressed Barret's feedback.
- Commit:
-
0c16907ccdee121e460c1ccae6795a8e3d7174827398e2ff969e76099d2f5a4327bedcdce83baa94
- Diff:
-
Revision 7 (+323 -6)
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests/test_views.py reviewboard/extensions/hooks.py reviewboard/datagrids/columns.py reviewboard/reviews/urls.py Ignored Files: reviewboard/static/rb/js/ui/views/infoboxView.es6.js reviewboard/templates/datagrids/summary_cell.html reviewboard/templates/reviews/review_request_infobox.html reviewboard/static/rb/css/common.less reviewboard/static/rb/js/common.es6.js Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests/test_views.py reviewboard/extensions/hooks.py reviewboard/datagrids/columns.py reviewboard/reviews/urls.py Ignored Files: reviewboard/static/rb/js/ui/views/infoboxView.es6.js reviewboard/templates/datagrids/summary_cell.html reviewboard/templates/reviews/review_request_infobox.html reviewboard/static/rb/css/common.less reviewboard/static/rb/js/common.es6.js
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/extensions/hooks.py reviewboard/reviews/urls.py Ignored Files: reviewboard/templates/reviews/review_request_infobox.html reviewboard/static/rb/css/common.less reviewboard/static/rb/js/common.es6.js Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/extensions/hooks.py reviewboard/reviews/urls.py Ignored Files: reviewboard/templates/reviews/review_request_infobox.html reviewboard/static/rb/css/common.less reviewboard/static/rb/js/common.es6.js