Summary

Add a review request hover preview.

Review Request #8508 — Created Oct. 30, 2016 and discarded May 26, 2017, 1:06 p.m.

Information

Owner

stensby

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard, students

People

Description

When the cursor moves over top of a review request in the dashboard a small
preview of the review request will be shown, similar to the user preview box.

Testing Done

Added 2 unit tests, checked infobox on dashboard, all review requests
and user pages.

Files

Issues

Description	From	Last Updated
Missing "Args" and "Returns" sections in docstring.	brennie	Dec. 10, 2016, 9:20 a.m.
This is incorrect. This would have to be calc(@z-index-dialog + 1). However, this should be its own constant.	brennie	Dec. 10, 2016, 9:21 a.m.
These should probably be constants.	brennie	Dec. 10, 2016, 9:21 a.m.
This should be the first selector under .localtime.	brennie	Dec. 7, 2016, 3:50 p.m.
Where does this value come from?	brennie	Dec. 7, 2016, 3:50 p.m.
user, and	brennie	Nov. 9, 2016, 9:37 p.m.
Where is the corresponding {% spaceless %} start tag?	brennie	Nov. 9, 2016, 9:36 p.m.
Indentation is off.	brennie	Nov. 9, 2016, 9:36 p.m.
Need to change this so that it doesn't have to guess about location of href	ST stensby	Nov. 26, 2016, 5:57 p.m.
Try deleting lines 605 to 611 here to fix your hover problem. :)	imadueme	Dec. 3, 2016, 10:15 p.m.
unicode	brennie	Dec. 10, 2016, 7:20 p.m.
unicode	brennie	Dec. 10, 2016, 7:21 p.m.
Alphabetical order.	brennie	Dec. 10, 2016, 7:12 p.m.
Missing docstring.	brennie	Dec. 10, 2016, 7:22 p.m.
Testing docstrings can be of the form: """Testing some really_long_function does something specific """	brennie	Dec. 10, 2016, 7:13 p.m.
"Display"	brennie	Dec. 10, 2016, 7:14 p.m.
"The infobox" over "this".	brennie	Dec. 10, 2016, 7:15 p.m.
arg (type): not arg: (type):	brennie	Dec. 10, 2016, 7:16 p.m.
int	brennie	Dec. 10, 2016, 7:16 p.m.
ID	brennie	Dec. 10, 2016, 7:16 p.m.
django.http.HttpResponse is the type.	brennie	Dec. 10, 2016, 7:16 p.m.
.classes before elements, so this should be ordered as: a {} h3 {} .infobox-extra {} .infobox-text {}	brennie	Dec. 10, 2016, 7:28 p.m.
Revert changes to this file	ST stensby	Dec. 10, 2016, 7:26 p.m.
Undo this.	brennie	Dec. 10, 2016, 7:26 p.m.
Can you remove the "right now"	brennie	Dec. 10, 2016, 7:17 p.m.
Is the whitespace here for a reason?	brennie	Dec. 10, 2016, 7:18 p.m.
Templates should be indented as with single spacing and the opening brace of block tags (e.g., {% if %}, etc.) …	brennie	Dec. 10, 2016, 7:30 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/extensions/hooks.py
    reviewboard/reviews/urls.py

Ignored Files:
    reviewboard/templates/reviews/review_request_infobox.html
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/js/common.es6.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/extensions/hooks.py
    reviewboard/reviews/urls.py

Ignored Files:
    reviewboard/templates/reviews/review_request_infobox.html
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/js/common.es6.js

Commit:

-	05da286c4d4f5e479d5bd41be0f322b93a949983
+	f79648b2f169d143bdc7fd731c6b676d5fad02bd

Diff:

Revision 2 (+309 -7)

Show changes

	reviewboard/extensions/hooks.py
	reviewboard/reviews/urls.py
	reviewboard/reviews/views.py
	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/js/common.es6.js
	reviewboard/static/rb/js/ui/views/infoboxView.es6.js
	reviewboard/templates/reviews/review_request_infobox.html

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/extensions/hooks.py
    reviewboard/reviews/urls.py

Ignored Files:
    reviewboard/static/rb/js/ui/views/infoboxView.es6.js
    reviewboard/templates/reviews/review_request_infobox.html
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/js/common.es6.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/extensions/hooks.py
    reviewboard/reviews/urls.py

Ignored Files:
    reviewboard/static/rb/js/ui/views/infoboxView.es6.js
    reviewboard/templates/reviews/review_request_infobox.html
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/js/common.es6.js

reviewboard/reviews/views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing "Args" and "Returns" sections in docstring.
```
reviewboard/reviews/views.py (Diff revision 2)
```
Circular import?
```

reviewboard/static/rb/css/common.less (Diff revision 2)

The issue has been dropped. Show all issues

This is incorrect. This would have to be calc(@z-index-dialog + 1).

However, this should be its own constant.

reviewboard/static/rb/css/common.less (Diff revision 2)
The issue has been dropped. Show all issues
```
These should probably be constants.
```
reviewboard/static/rb/css/common.less (Diff revision 2)
The issue has been resolved. Show all issues
```
This should be the first selector under .localtime.
```
reviewboard/static/rb/css/common.less (Diff revision 2)
The issue has been resolved. Show all issues
```
Where does this value come from?
```
reviewboard/static/rb/js/common.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
user, and
```
reviewboard/templates/reviews/review_request_infobox.html (Diff revision 2)
The issue has been resolved. Show all issues
```
Where is the corresponding {% spaceless %} start tag?
```
reviewboard/templates/reviews/review_request_infobox.html (Diff revision 2)
The issue has been resolved. Show all issues
```
Indentation is off.
```

Commit:

-	f79648b2f169d143bdc7fd731c6b676d5fad02bd
+	5e0f1a45cba7e8bf57c39e2878ed43214ab70e34

Diff:

Revision 3 (+262 -7)

Show changes

	reviewboard/extensions/hooks.py
	reviewboard/reviews/urls.py
	reviewboard/reviews/views.py
	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/js/common.es6.js
	reviewboard/static/rb/js/ui/views/infoboxView.es6.js
	reviewboard/templates/reviews/review_request_infobox.html

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/extensions/hooks.py
    reviewboard/reviews/urls.py

Ignored Files:
    reviewboard/static/rb/js/ui/views/infoboxView.es6.js
    reviewboard/templates/reviews/review_request_infobox.html
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/js/common.es6.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/extensions/hooks.py
    reviewboard/reviews/urls.py

Ignored Files:
    reviewboard/static/rb/js/ui/views/infoboxView.es6.js
    reviewboard/templates/reviews/review_request_infobox.html
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/js/common.es6.js

reviewboard/static/rb/js/ui/views/infoboxView.es6.js (Diff revision 3)

The issue has been resolved. Show all issues

Need to change this so that it doesn't have to guess about location of href

Change Summary:

Added screenshot of current progress on infobox

Added Files:

Change Summary:

Fixed infobox attachment point to match other infoboxes, continuing debug work on small pixel difference compared to user infobocx.

Commit:

-	5e0f1a45cba7e8bf57c39e2878ed43214ab70e34
+	8ca01325477b2f691ba59f516905558e778601c7

Diff:

Revision 4 (+267 -7)

Show changes

	reviewboard/datagrids/columns.py
	reviewboard/extensions/hooks.py
	reviewboard/reviews/urls.py
	reviewboard/reviews/views.py
	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/css/ui/datagrids.less
	reviewboard/static/rb/js/common.es6.js
	reviewboard/static/rb/js/ui/views/infoboxView.es6.js
	2 more

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/extensions/hooks.py
    reviewboard/datagrids/columns.py
    reviewboard/reviews/urls.py

Ignored Files:
    reviewboard/templates/reviews/review_request_infobox.html
    reviewboard/static/rb/js/common.es6.js
    reviewboard/static/rb/css/ui/datagrids.less
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/js/ui/views/infoboxView.es6.js
    reviewboard/templates/datagrids/summary_cell.html



Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/extensions/hooks.py
    reviewboard/datagrids/columns.py
    reviewboard/reviews/urls.py

Ignored Files:
    reviewboard/templates/reviews/review_request_infobox.html
    reviewboard/static/rb/js/common.es6.js
    reviewboard/static/rb/css/ui/datagrids.less
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/js/ui/views/infoboxView.es6.js
    reviewboard/templates/datagrids/summary_cell.html

reviewboard/static/rb/css/common.less (Diff revision 4)
The issue has been resolved. Show all issues
```
Try deleting lines 605 to 611 here to fix your hover problem. :)
```

Change Summary:

Added unit test.

Summary:

-	[WIP] Add a review request hover preview.
+	Add a review request hover preview.

Testing Done:

	+	Added 2 unit tests, checked infobox on dashboard, all review requests
	+	and user page.

Commit:

-	8ca01325477b2f691ba59f516905558e778601c7
+	ad9a48f989d43e1124ec898e64b843dd2ba278ef

Diff:

Revision 5 (+326 -8)

Show changes

	reviewboard/datagrids/columns.py
	reviewboard/extensions/hooks.py
	reviewboard/reviews/urls.py
	reviewboard/reviews/views.py
	reviewboard/reviews/tests/test_views.py
	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/css/ui/datagrids.less
	reviewboard/static/rb/js/common.es6.js
	3 more

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/tests/test_views.py
    reviewboard/extensions/hooks.py
    reviewboard/datagrids/columns.py
    reviewboard/reviews/urls.py

Ignored Files:
    reviewboard/templates/reviews/review_request_infobox.html
    reviewboard/static/rb/js/common.es6.js
    reviewboard/static/rb/css/ui/datagrids.less
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/js/ui/views/infoboxView.es6.js
    reviewboard/templates/datagrids/summary_cell.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/tests/test_views.py
    reviewboard/extensions/hooks.py
    reviewboard/datagrids/columns.py
    reviewboard/reviews/urls.py

Ignored Files:
    reviewboard/templates/reviews/review_request_infobox.html
    reviewboard/static/rb/js/common.es6.js
    reviewboard/static/rb/css/ui/datagrids.less
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/js/ui/views/infoboxView.es6.js
    reviewboard/templates/datagrids/summary_cell.html

Change Summary:

Slight tweak to docstring

Commit:

-	ad9a48f989d43e1124ec898e64b843dd2ba278ef
+	0c16907ccdee121e460c1ccae6795a8e3d717482

Diff:

Revision 6 (+329 -8)

Show changes

	reviewboard/datagrids/columns.py
	reviewboard/extensions/hooks.py
	reviewboard/reviews/urls.py
	reviewboard/reviews/views.py
	reviewboard/reviews/tests/test_views.py
	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/css/ui/datagrids.less
	reviewboard/static/rb/js/common.es6.js
	3 more

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/tests/test_views.py
    reviewboard/extensions/hooks.py
    reviewboard/datagrids/columns.py
    reviewboard/reviews/urls.py

Ignored Files:
    reviewboard/templates/reviews/review_request_infobox.html
    reviewboard/static/rb/js/common.es6.js
    reviewboard/static/rb/css/ui/datagrids.less
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/js/ui/views/infoboxView.es6.js
    reviewboard/templates/datagrids/summary_cell.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/tests/test_views.py
    reviewboard/extensions/hooks.py
    reviewboard/datagrids/columns.py
    reviewboard/reviews/urls.py

Ignored Files:
    reviewboard/templates/reviews/review_request_infobox.html
    reviewboard/static/rb/js/common.es6.js
    reviewboard/static/rb/css/ui/datagrids.less
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/js/ui/views/infoboxView.es6.js
    reviewboard/templates/datagrids/summary_cell.html

Testing Done:

		Added 2 unit tests, checked infobox on dashboard, all review requests
~		and user page.
	~	and user pages.

reviewboard/static/rb/css/ui/datagrids.less (Diff revision 6)

The issue has been resolved. Show all issues

Revert changes to this file

reviewboard/extensions/hooks.py (Diff revision 6)
The issue has been resolved. Show all issues
```
unicode
```
reviewboard/extensions/hooks.py (Diff revision 6)
The issue has been resolved. Show all issues
```
unicode
```
reviewboard/reviews/tests/test_views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Alphabetical order.
```
reviewboard/reviews/tests/test_views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Missing docstring.
```

reviewboard/reviews/tests/test_views.py (Diff revision 6)

The issue has been resolved. Show all issues

Testing docstrings can be of the form:

"""Testing some really_long_function
does something specific
"""

reviewboard/reviews/views.py (Diff revision 6)

The issue has been resolved. Show all issues

"Display"

stensby Dec. 10, 2016, 7:30 p.m.

Fixed, but just so you know the other functions in this file use "Displays". (User infobox, review file attachment, screenshot etc)

reviewboard/reviews/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
"The infobox" over "this".
```

reviewboard/reviews/views.py (Diff revision 6)

The issue has been resolved. Show all issues

arg (type): not arg: (type):

reviewboard/reviews/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
int
```
reviewboard/reviews/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
ID
```
reviewboard/reviews/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
django.http.HttpResponse is the type.
```

reviewboard/static/rb/css/common.less (Diff revision 6)

The issue has been resolved. Show all issues

.classes before elements, so this should be ordered as:


a {}
h3 {}
.infobox-extra {}
.infobox-text {}

reviewboard/static/rb/css/ui/datagrids.less (Diff revision 6)
The issue has been resolved. Show all issues
```
Undo this.
```
reviewboard/static/rb/js/ui/views/infoboxView.es6.js (Diff revision 6)
The issue has been resolved. Show all issues
```
Can you remove the "right now"
```
reviewboard/templates/datagrids/summary_cell.html (Diff revision 6)
The issue has been resolved. Show all issues
```
Is the whitespace here for a reason?
```

reviewboard/templates/reviews/review_request_infobox.html (Diff revision 6)

The issue has been resolved. Show all issues

Templates should be indented as with single spacing and the opening brace of block tags (e.g., {% if %}, etc.) should be left aligned, such as:

<div class="foo">
 <div class="bar">
{% if foo %}
{%  if bar %}
bar
{%  endif %}
{% endif %}
 </div>
</div>

Change Summary:

Addressed Barret's feedback.

Commit:

-	0c16907ccdee121e460c1ccae6795a8e3d717482
+	7398e2ff969e76099d2f5a4327bedcdce83baa94

Diff:

Revision 7 (+323 -6)

Show changes

	reviewboard/datagrids/columns.py
	reviewboard/extensions/hooks.py
	reviewboard/reviews/urls.py
	reviewboard/reviews/views.py
	reviewboard/reviews/tests/test_views.py
	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/js/common.es6.js
	reviewboard/static/rb/js/ui/views/infoboxView.es6.js
	2 more

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/tests/test_views.py
    reviewboard/extensions/hooks.py
    reviewboard/datagrids/columns.py
    reviewboard/reviews/urls.py

Ignored Files:
    reviewboard/static/rb/js/ui/views/infoboxView.es6.js
    reviewboard/templates/datagrids/summary_cell.html
    reviewboard/templates/reviews/review_request_infobox.html
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/js/common.es6.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/tests/test_views.py
    reviewboard/extensions/hooks.py
    reviewboard/datagrids/columns.py
    reviewboard/reviews/urls.py

Ignored Files:
    reviewboard/static/rb/js/ui/views/infoboxView.es6.js
    reviewboard/templates/datagrids/summary_cell.html
    reviewboard/templates/reviews/review_request_infobox.html
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/js/common.es6.js

Status: Discarded

Change Summary:

Obsoleted by https://reviews.reviewboard.org/r/8661/

Add a review request hover preview.

Information

Reviewers

Commit:

Diff:

Commit:

Diff:

Change Summary:

Added Files:

Change Summary:

Commit:

Diff:

Change Summary:

Summary:

Testing Done:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Testing Done:

Change Summary:

Commit:

Diff:

Status: Discarded

Change Summary: