Add a review request hover preview.

Review Request #8508 — Created Oct. 30, 2016 and discarded

stensby
Review Board
master
reviewboard, students

When the cursor moves over top of a review request in the dashboard a small
preview of the review request will be shown, similar to the user preview box.

Added 2 unit tests, checked infobox on dashboard, all review requests
and user pages.


Description From Last Updated

Missing "Args" and "Returns" sections in docstring.

brenniebrennie

This is incorrect. This would have to be calc(@z-index-dialog + 1). However, this should be its own constant.

brenniebrennie

These should probably be constants.

brenniebrennie

This should be the first selector under .localtime.

brenniebrennie

Where does this value come from?

brenniebrennie

user, and

brenniebrennie

Where is the corresponding {% spaceless %} start tag?

brenniebrennie

Indentation is off.

brenniebrennie

Need to change this so that it doesn't have to guess about location of href

ST stensby

Try deleting lines 605 to 611 here to fix your hover problem. :)

imaduemeimadueme

unicode

brenniebrennie

unicode

brenniebrennie

Alphabetical order.

brenniebrennie

Missing docstring.

brenniebrennie

Testing docstrings can be of the form: """Testing some really_long_function does something specific """

brenniebrennie

"Display"

brenniebrennie

"The infobox" over "this".

brenniebrennie

arg (type): not arg: (type):

brenniebrennie

int

brenniebrennie

ID

brenniebrennie

django.http.HttpResponse is the type.

brenniebrennie

.classes before elements, so this should be ordered as: a {} h3 {} .infobox-extra {} .infobox-text {}

brenniebrennie

Revert changes to this file

ST stensby

Undo this.

brenniebrennie

Can you remove the "right now"

brenniebrennie

Is the whitespace here for a reason?

brenniebrennie

Templates should be indented as with single spacing and the opening brace of block tags (e.g., {% if %}, etc.) ...

brenniebrennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/extensions/hooks.py
        reviewboard/reviews/urls.py
    
    Ignored Files:
        reviewboard/templates/reviews/review_request_infobox.html
        reviewboard/static/rb/css/common.less
        reviewboard/static/rb/js/common.es6.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/extensions/hooks.py
        reviewboard/reviews/urls.py
    
    Ignored Files:
        reviewboard/templates/reviews/review_request_infobox.html
        reviewboard/static/rb/css/common.less
        reviewboard/static/rb/js/common.es6.js
    
    
  2. 
      
ST
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/extensions/hooks.py
        reviewboard/reviews/urls.py
    
    Ignored Files:
        reviewboard/static/rb/js/ui/views/infoboxView.es6.js
        reviewboard/templates/reviews/review_request_infobox.html
        reviewboard/static/rb/css/common.less
        reviewboard/static/rb/js/common.es6.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/extensions/hooks.py
        reviewboard/reviews/urls.py
    
    Ignored Files:
        reviewboard/static/rb/js/ui/views/infoboxView.es6.js
        reviewboard/templates/reviews/review_request_infobox.html
        reviewboard/static/rb/css/common.less
        reviewboard/static/rb/js/common.es6.js
    
    
  2. 
      
brennie
  1. 
      
  2. reviewboard/reviews/views.py (Diff revision 2)
     
     
     
     

    Missing "Args" and "Returns" sections in docstring.

  3. reviewboard/reviews/views.py (Diff revision 2)
     
     

    Circular import?

  4. reviewboard/static/rb/css/common.less (Diff revision 2)
     
     

    This is incorrect. This would have to be calc(@z-index-dialog + 1).

    However, this should be its own constant.

  5. reviewboard/static/rb/css/common.less (Diff revision 2)
     
     

    These should probably be constants.

  6. reviewboard/static/rb/css/common.less (Diff revision 2)
     
     

    This should be the first selector under .localtime.

  7. reviewboard/static/rb/css/common.less (Diff revision 2)
     
     

    Where does this value come from?

  8. reviewboard/static/rb/js/common.es6.js (Diff revision 2)
     
     

    user, and

  9. Where is the corresponding {% spaceless %} start tag?

  10. 
      
ST
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/extensions/hooks.py
        reviewboard/reviews/urls.py
    
    Ignored Files:
        reviewboard/static/rb/js/ui/views/infoboxView.es6.js
        reviewboard/templates/reviews/review_request_infobox.html
        reviewboard/static/rb/css/common.less
        reviewboard/static/rb/js/common.es6.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/extensions/hooks.py
        reviewboard/reviews/urls.py
    
    Ignored Files:
        reviewboard/static/rb/js/ui/views/infoboxView.es6.js
        reviewboard/templates/reviews/review_request_infobox.html
        reviewboard/static/rb/css/common.less
        reviewboard/static/rb/js/common.es6.js
    
    
  2. 
      
ST
  1. 
      
  2. reviewboard/static/rb/js/ui/views/infoboxView.es6.js (Diff revision 3)
     
     
     
     
     
     
     
     
    Need to change this so that it doesn't have to guess about location of href
  3. 
      
ST
ST
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/extensions/hooks.py
        reviewboard/datagrids/columns.py
        reviewboard/reviews/urls.py
    
    Ignored Files:
        reviewboard/templates/reviews/review_request_infobox.html
        reviewboard/static/rb/js/common.es6.js
        reviewboard/static/rb/css/ui/datagrids.less
        reviewboard/static/rb/css/common.less
        reviewboard/static/rb/js/ui/views/infoboxView.es6.js
        reviewboard/templates/datagrids/summary_cell.html
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/extensions/hooks.py
        reviewboard/datagrids/columns.py
        reviewboard/reviews/urls.py
    
    Ignored Files:
        reviewboard/templates/reviews/review_request_infobox.html
        reviewboard/static/rb/js/common.es6.js
        reviewboard/static/rb/css/ui/datagrids.less
        reviewboard/static/rb/css/common.less
        reviewboard/static/rb/js/ui/views/infoboxView.es6.js
        reviewboard/templates/datagrids/summary_cell.html
    
    
  2. 
      
imadueme
  1. 
      
  2. reviewboard/static/rb/css/common.less (Diff revision 4)
     
     

    Try deleting lines 605 to 611 here to fix your hover problem. :)

  3. 
      
ST
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/reviews/tests/test_views.py
        reviewboard/extensions/hooks.py
        reviewboard/datagrids/columns.py
        reviewboard/reviews/urls.py
    
    Ignored Files:
        reviewboard/templates/reviews/review_request_infobox.html
        reviewboard/static/rb/js/common.es6.js
        reviewboard/static/rb/css/ui/datagrids.less
        reviewboard/static/rb/css/common.less
        reviewboard/static/rb/js/ui/views/infoboxView.es6.js
        reviewboard/templates/datagrids/summary_cell.html
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/reviews/tests/test_views.py
        reviewboard/extensions/hooks.py
        reviewboard/datagrids/columns.py
        reviewboard/reviews/urls.py
    
    Ignored Files:
        reviewboard/templates/reviews/review_request_infobox.html
        reviewboard/static/rb/js/common.es6.js
        reviewboard/static/rb/css/ui/datagrids.less
        reviewboard/static/rb/css/common.less
        reviewboard/static/rb/js/ui/views/infoboxView.es6.js
        reviewboard/templates/datagrids/summary_cell.html
    
    
  2. 
      
ST
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/reviews/tests/test_views.py
        reviewboard/extensions/hooks.py
        reviewboard/datagrids/columns.py
        reviewboard/reviews/urls.py
    
    Ignored Files:
        reviewboard/templates/reviews/review_request_infobox.html
        reviewboard/static/rb/js/common.es6.js
        reviewboard/static/rb/css/ui/datagrids.less
        reviewboard/static/rb/css/common.less
        reviewboard/static/rb/js/ui/views/infoboxView.es6.js
        reviewboard/templates/datagrids/summary_cell.html
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/reviews/tests/test_views.py
        reviewboard/extensions/hooks.py
        reviewboard/datagrids/columns.py
        reviewboard/reviews/urls.py
    
    Ignored Files:
        reviewboard/templates/reviews/review_request_infobox.html
        reviewboard/static/rb/js/common.es6.js
        reviewboard/static/rb/css/ui/datagrids.less
        reviewboard/static/rb/css/common.less
        reviewboard/static/rb/js/ui/views/infoboxView.es6.js
        reviewboard/templates/datagrids/summary_cell.html
    
    
  2. 
      
ST
ST
  1. 
      
  2. reviewboard/static/rb/css/ui/datagrids.less (Diff revision 6)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    Revert changes to this file

  3. 
      
brennie
  1. 
      
  2. reviewboard/extensions/hooks.py (Diff revision 6)
     
     

    unicode

  3. reviewboard/extensions/hooks.py (Diff revision 6)
     
     

    unicode

  4. reviewboard/reviews/tests/test_views.py (Diff revision 6)
     
     

    Alphabetical order.

  5. reviewboard/reviews/tests/test_views.py (Diff revision 6)
     
     

    Missing docstring.

  6. reviewboard/reviews/tests/test_views.py (Diff revision 6)
     
     
     
     

    Testing docstrings can be of the form:

    """Testing some really_long_function
    does something specific
    """
    
  7. reviewboard/reviews/views.py (Diff revision 6)
     
     

    "Display"

    1. Fixed, but just so you know the other functions in this file use "Displays". (User infobox, review file attachment, screenshot etc)

  8. reviewboard/reviews/views.py (Diff revision 6)
     
     

    "The infobox" over "this".

  9. reviewboard/reviews/views.py (Diff revision 6)
     
     
     
     
     
     
     
     
     
     
     
     

    arg (type): not arg: (type):

  10. reviewboard/reviews/views.py (Diff revision 6)
     
     
  11. reviewboard/reviews/views.py (Diff revision 6)
     
     
  12. reviewboard/reviews/views.py (Diff revision 6)
     
     

    django.http.HttpResponse is the type.

  13. reviewboard/static/rb/css/common.less (Diff revision 6)
     
     

    .classes before elements, so this should be ordered as:

    a {}
    h3 {}
    .infobox-extra {}
    .infobox-text {}
    
  14. Can you remove the "right now"

  15. Is the whitespace here for a reason?

  16. reviewboard/templates/reviews/review_request_infobox.html (Diff revision 6)
     
     
     
     
     
     
     
     
     
     
     
     
     

    Templates should be indented as with single spacing and the opening brace of block tags (e.g., {% if %}, etc.) should be left aligned, such as:

    <div class="foo">
     <div class="bar">
    {% if foo %}
    {%  if bar %}
    bar
    {%  endif %}
    {% endif %}
     </div>
    </div>
    
  17. 
      
ST
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/reviews/tests/test_views.py
        reviewboard/extensions/hooks.py
        reviewboard/datagrids/columns.py
        reviewboard/reviews/urls.py
    
    Ignored Files:
        reviewboard/static/rb/js/ui/views/infoboxView.es6.js
        reviewboard/templates/datagrids/summary_cell.html
        reviewboard/templates/reviews/review_request_infobox.html
        reviewboard/static/rb/css/common.less
        reviewboard/static/rb/js/common.es6.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/reviews/tests/test_views.py
        reviewboard/extensions/hooks.py
        reviewboard/datagrids/columns.py
        reviewboard/reviews/urls.py
    
    Ignored Files:
        reviewboard/static/rb/js/ui/views/infoboxView.es6.js
        reviewboard/templates/datagrids/summary_cell.html
        reviewboard/templates/reviews/review_request_infobox.html
        reviewboard/static/rb/css/common.less
        reviewboard/static/rb/js/common.es6.js
    
    
  2. 
      
david
Review request changed

Status: Discarded

Change Summary:

Obsoleted by https://reviews.reviewboard.org/r/8661/

Loading...