Summary

Add the URLAvatarService

Review Request #8481 — Created Oct. 21, 2016 and submitted Oct. 25, 2016, 9:47 p.m.

Information

Owner

brennie

Repository

Djblets

Branch

release-0.10.x

Bugs

Depends On

~~8479~~

Blocks

8482

Reviewers

Groups

djblets

People

Description

The URLAvatarService is a new avatar service for setting the avatar of
a user to an absolute URL. This service is a hidden service, which is a
new type of service that is not exposed to users through the
configuration form. (Indeed, attempting to fool the form and submitting
the data will result in an error as if it does not exist.) Instead, it
is to be used to provide avatars for users created by extensions, etc.

Testing Done


Ran unit tests.
Tested with Review Board.
Saw that the service did not show up in the avatar services form.

Issues

Description	From	Last Updated
'AvatarService' imported but unused	reviewbot	Oct. 21, 2016, 3:03 p.m.
'FileUploadService' imported but unused	reviewbot	Oct. 21, 2016, 3:03 p.m.
'GravatarService' imported but unused	reviewbot	Oct. 21, 2016, 3:03 p.m.
'URLAvatarService' imported but unused	reviewbot	Oct. 21, 2016, 3:03 p.m.
redefinition of unused 'unregister' from line 137	reviewbot	Oct. 21, 2016, 8:28 p.m.
redefinition of unused 'avatar_service_id' from line 27	reviewbot	Oct. 22, 2016, 7:31 p.m.
Typo: avatrs.	david	Oct. 24, 2016, 4:34 p.m.
Instead of "Integrations can be configured", how about "Automation users can be configured..."	david	Oct. 24, 2016, 4:34 p.m.
Maybe do one per line for future expansion?	david	Oct. 24, 2016, 4:35 p.m.
Missing : after :py:class.	chipx86	Oct. 25, 2016, 9:46 p.m.
Is this supposed to be "URLAvatarService" ?	chipx86	Oct. 25, 2016, 9:46 p.m.
Too many blank lines.	chipx86	Oct. 25, 2016, 9:46 p.m.

Tool: Pyflakes
Processed Files:
    djblets/avatars/forms.py
    djblets/avatars/services/url.py
    djblets/avatars/services/base.py
    djblets/avatars/services/__init__.py
    djblets/avatars/tests.py
    djblets/avatars/registry.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/avatars/forms.py
    djblets/avatars/services/url.py
    djblets/avatars/services/base.py
    djblets/avatars/services/__init__.py
    djblets/avatars/tests.py
    djblets/avatars/registry.py

djblets/avatars/services/__init__.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'AvatarService' imported but unused
```
djblets/avatars/services/__init__.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'FileUploadService' imported but unused
```
djblets/avatars/services/__init__.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'GravatarService' imported but unused
```
djblets/avatars/services/__init__.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'URLAvatarService' imported but unused
```

Diff:

Revision 2 (+168 -18)

Show changes

	djblets/avatars/forms.py
	djblets/avatars/registry.py
	djblets/avatars/tests.py
	djblets/avatars/services/__init__.py
	djblets/avatars/services/base.py
	djblets/avatars/services/url.py

Tool: Pyflakes
Processed Files:
    djblets/avatars/forms.py
    djblets/avatars/services/url.py
    djblets/avatars/services/base.py
    djblets/avatars/services/__init__.py
    djblets/avatars/tests.py
    djblets/avatars/registry.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/avatars/forms.py
    djblets/avatars/services/url.py
    djblets/avatars/services/base.py
    djblets/avatars/services/__init__.py
    djblets/avatars/tests.py
    djblets/avatars/registry.py

Diff:

Revision 3 (+168 -18)

Show changes

	djblets/avatars/forms.py
	djblets/avatars/registry.py
	djblets/avatars/tests.py
	djblets/avatars/services/__init__.py
	djblets/avatars/services/base.py
	djblets/avatars/services/url.py

Tool: Pyflakes
Processed Files:
    djblets/avatars/forms.py
    djblets/avatars/services/url.py
    djblets/avatars/services/base.py
    djblets/avatars/services/__init__.py
    djblets/avatars/tests.py
    djblets/avatars/registry.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/avatars/forms.py
    djblets/avatars/services/url.py
    djblets/avatars/services/base.py
    djblets/avatars/services/__init__.py
    djblets/avatars/tests.py
    djblets/avatars/registry.py

djblets/avatars/registry.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 redefinition of unused 'unregister' from line 137
```

Diff:

Revision 4 (+173 -37)

Show changes

	djblets/avatars/forms.py
	djblets/avatars/registry.py
	djblets/avatars/tests.py
	djblets/avatars/services/__init__.py
	djblets/avatars/services/base.py
	djblets/avatars/services/url.py

Tool: Pyflakes
Processed Files:
    djblets/avatars/forms.py
    djblets/avatars/services/url.py
    djblets/avatars/services/base.py
    djblets/avatars/services/__init__.py
    djblets/avatars/tests.py
    djblets/avatars/registry.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/avatars/forms.py
    djblets/avatars/services/url.py
    djblets/avatars/services/base.py
    djblets/avatars/services/__init__.py
    djblets/avatars/tests.py
    djblets/avatars/registry.py

Diff:

Revision 5 (+173 -37)

Show changes

	djblets/avatars/forms.py
	djblets/avatars/registry.py
	djblets/avatars/tests.py
	djblets/avatars/services/__init__.py
	djblets/avatars/services/base.py
	djblets/avatars/services/url.py

Tool: Pyflakes
Processed Files:
    djblets/avatars/forms.py
    djblets/avatars/services/url.py
    djblets/avatars/services/base.py
    djblets/avatars/services/__init__.py
    djblets/avatars/tests.py
    djblets/avatars/registry.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/avatars/forms.py
    djblets/avatars/services/url.py
    djblets/avatars/services/base.py
    djblets/avatars/services/__init__.py
    djblets/avatars/tests.py
    djblets/avatars/registry.py

Diff:

Revision 6 (+168 -18)

Show changes

	djblets/avatars/forms.py
	djblets/avatars/registry.py
	djblets/avatars/tests.py
	djblets/avatars/services/__init__.py
	djblets/avatars/services/base.py
	djblets/avatars/services/url.py

Tool: Pyflakes
Processed Files:
    djblets/avatars/forms.py
    djblets/avatars/services/url.py
    djblets/avatars/services/base.py
    djblets/avatars/services/__init__.py
    djblets/avatars/tests.py
    djblets/avatars/registry.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/avatars/forms.py
    djblets/avatars/services/url.py
    djblets/avatars/services/base.py
    djblets/avatars/services/__init__.py
    djblets/avatars/tests.py
    djblets/avatars/registry.py

djblets/avatars/tests.py (Diff revision 6)
The issue has been resolved. Show all issues
```
 redefinition of unused 'avatar_service_id' from line 27
```

Diff:

Revision 7 (+168 -18)

Show changes

	djblets/avatars/forms.py
	djblets/avatars/registry.py
	djblets/avatars/tests.py
	djblets/avatars/services/__init__.py
	djblets/avatars/services/base.py
	djblets/avatars/services/url.py

Tool: Pyflakes
Processed Files:
    djblets/avatars/forms.py
    djblets/avatars/services/url.py
    djblets/avatars/services/base.py
    djblets/avatars/services/__init__.py
    djblets/avatars/tests.py
    djblets/avatars/registry.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/avatars/forms.py
    djblets/avatars/services/url.py
    djblets/avatars/services/base.py
    djblets/avatars/services/__init__.py
    djblets/avatars/tests.py
    djblets/avatars/registry.py

djblets/avatars/services/url.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Typo: avatrs.
```

djblets/avatars/services/url.py (Diff revision 7)

The issue has been resolved. Show all issues

Instead of "Integrations can be configured", how about "Automation users can be configured..."

djblets/avatars/tests.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Maybe do one per line for future expansion?
```

Change Summary:

Addressed issues

Diff:

Revision 8 (+170 -18)

Show changes

	djblets/avatars/forms.py
	djblets/avatars/registry.py
	djblets/avatars/tests.py
	djblets/avatars/services/__init__.py
	djblets/avatars/services/base.py
	djblets/avatars/services/url.py

Tool: Pyflakes
Processed Files:
    djblets/avatars/forms.py
    djblets/avatars/services/url.py
    djblets/avatars/services/base.py
    djblets/avatars/services/__init__.py
    djblets/avatars/tests.py
    djblets/avatars/registry.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/avatars/forms.py
    djblets/avatars/services/url.py
    djblets/avatars/services/base.py
    djblets/avatars/services/__init__.py
    djblets/avatars/tests.py
    djblets/avatars/registry.py

Ship it!

```
Ship It!
```

djblets/avatars/services/base.py (Diff revision 8)
The issue has been resolved. Show all issues
```
Missing : after :py:class.
```
djblets/avatars/services/url.py (Diff revision 8)
The issue has been resolved. Show all issues
```
Is this supposed to be "URLAvatarService" ?
```
djblets/avatars/tests.py (Diff revision 8)
The issue has been resolved. Show all issues
```
Too many blank lines.
```

Status:: Completed
Change Summary:: Pushed to release-0.10.x (8656c59)