Summary

Update Review Board to use the new avatar services APIs

Review Request #8480 — Created Oct. 20, 2016 and submitted Oct. 25, 2016, 9:51 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

~~8479~~

Blocks

8482

Reviewers

Groups

reviewboard

People

Description

This patch updates avatar services tests to use the new avatar services
registry API from r/8479. It also updates the user API and user
datagrid column to use the newer AvatarServicesRegistry.for_user
method to retrieve their preferred avatar service.

Testing Done


Ran unit tests.
Verified that avatar configuration still works.
Verified that avatar admin configuration still works.

Issues

Description	From	Last Updated
I think the old method was cleaner.	david	Oct. 21, 2016, 8:26 p.m.
You lost a not in here.	david	Oct. 24, 2016, 4:28 p.m.
Change back to use has_service?	david	Oct. 24, 2016, 4:28 p.m.
You can use assertEqual. It's equivalent to assertSetEqual when passing in sets.	chipx86	Oct. 25, 2016, 9:49 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/avatars/tests.py
    reviewboard/admin/forms.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/tests/test_user.py
    reviewboard/datagrids/columns.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/avatars/tests.py
    reviewboard/admin/forms.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/tests/test_user.py
    reviewboard/datagrids/columns.py

Summary:: Update avatar services tests to new API
Update Review Board to use the new avatar services APIs

reviewboard/admin/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
I think the old method was cleaner.
```

Diff:

Revision 2 (+27 -39)

Show changes

	reviewboard/admin/forms.py
	reviewboard/avatars/tests.py
	reviewboard/datagrids/columns.py
	reviewboard/webapi/resources/user.py
	reviewboard/webapi/tests/test_user.py

Tool: Pyflakes
Processed Files:
    reviewboard/avatars/tests.py
    reviewboard/admin/forms.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/tests/test_user.py
    reviewboard/datagrids/columns.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/avatars/tests.py
    reviewboard/admin/forms.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/tests/test_user.py
    reviewboard/datagrids/columns.py

reviewboard/admin/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
You lost a not in here.
```
reviewboard/admin/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Change back to use has_service?
```

Change Summary:

Address issues

Diff:

Revision 3 (+25 -37)

Show changes

	reviewboard/admin/forms.py
	reviewboard/avatars/tests.py
	reviewboard/datagrids/columns.py
	reviewboard/webapi/resources/user.py
	reviewboard/webapi/tests/test_user.py

Tool: Pyflakes
Processed Files:
    reviewboard/avatars/tests.py
    reviewboard/admin/forms.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/tests/test_user.py
    reviewboard/datagrids/columns.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/avatars/tests.py
    reviewboard/admin/forms.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/tests/test_user.py
    reviewboard/datagrids/columns.py

Ship it!

```
Ship It!
```

Ship it!

reviewboard/avatars/tests.py (Diff revision 3)

The issue has been resolved. Show all issues

You can use assertEqual. It's equivalent to assertSetEqual when passing in sets.

Status:: Completed
Change Summary:: Pushed to release-3.0.x (ef24b8d)