Add a general comments feature class

 






 

 


  Review Request #8471
  —
  Created Oct. 17, 2016 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  brennie
 









 
 

  Review Board
 









 
 

  release-3.0.x
 









 
 

  
 









 
 

  8470
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
The new general comments feature can be enabled or disabled with the

reviews.general_comments feature. Disabling this feature will disable

all UI elements for it, as well as the web API resources for it.

 








  


 
 

  
Tested with reviews.general_comments enabled and disabled. When

disabled, general comments cannot be created and the UI elements do not

appear.

 







 









 





  








 




 







   

    
    
Diff Revision 4


This is not the most recent revision of the diff. The latest diff is revision 6. See what's changed.

    

 

 

 

 
orig
1
2
3
4
5
6

 



    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/settings.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/default_actions.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/features.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/views/reviewDialogView.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/templates/reviews/reviewable_page_data.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/base_review_general_comment.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...