-
-
-
reviewboard/static/rb/js/views/reviewView.es6.js (Diff revision 1) Let's move this function out into the body of the
RB.ReviewView, so we only have one definition and not one per iteration of this loop. -
reviewboard/static/rb/js/views/reviewView.es6.js (Diff revision 1) Same here about breaking out the function.
-
-
Status Updates part 7: Break some ReviewBoxView functionality out into ReviewView.
Review Request #8408 — Created Sept. 18, 2016 and submitted
Since we're now going to be sticking reviews into things other than the
ReviewBoxView(namely, the change descriptions and a new "initial status
updates" entry), we need to break some functionality out.This change does that, and moves/updates tests as appropriate.
- Ran js-tests.
- Created/discarded a draft reply and saw that banners were handled correctly.
| Description | From | Last Updated |
|---|---|---|
|
Extra stuff on this line. |
 chipx86
|
|
|
Let's move this function out into the body of the RB.ReviewView, so we only have one definition and not one … |
chipx86
|
|
|
Same here about breaking out the function. |
chipx86
|
|
|
Can we insert this more alphabetically grouped? |
chipx86
|
|
|
Same here. |
chipx86
|
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+380 -247) |
-
Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/views/tests/reviewViewTests.es6.js reviewboard/static/rb/js/views/tests/reviewBoxViewTests.js reviewboard/static/rb/js/views/reviewBoxView.es6.js reviewboard/static/rb/js/views/reviewView.es6.js Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/views/tests/reviewViewTests.es6.js reviewboard/static/rb/js/views/tests/reviewBoxViewTests.js reviewboard/static/rb/js/views/reviewBoxView.es6.js reviewboard/static/rb/js/views/reviewView.es6.js