Clean up icon-based actions in review request header.
Review Request #8308 — Created July 25, 2016 and submitted
The CSS that handled the icon-based actions on the left-hand side of the header
(star and archive/mute) was pretty ugly. We had a mix of padding/margin
specifications, especially working around a bad value in icons.less for the
position of the archive icon. We also had rules spread around in various
places, including a couple that were completely obsolete.This change includes the first introduction of review-request.less. My eventual
goal is to move everything corresponding to the review request box into there,
leaving reviews.less for the actual review/change description boxes.
Verified the actions' appearance in Chrome, Firefox, and Safari.
| Description | From | Last Updated |
|---|---|---|
|
Does starring end up triggering a URL change, or does it properly prevent that? |
 chipx86
|
Change Summary:
Add dependency.
Depends On: |
|
|---|
-
-
reviewboard/templates/reviews/review_request_header.html (Diff revision 1) Does starring end up triggering a URL change, or does it properly prevent that?
Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/css/pages/review-request.less reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_request_header.html reviewboard/static/rb/css/assets/icons.less Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/css/pages/review-request.less reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_request_header.html reviewboard/static/rb/css/assets/icons.less