Refactor review request header into a common template.
Review Request #8307 — Created July 22, 2016 and submitted
Every review request (and review-request like box such as the file review UI)
has a header that includes some icon-based actions, a bunch of text-based
actions, and some tabs. The code for these was spread out over every view and
template that wanted to include them, and the functionality was slightly
different for every implementation.This change centralizes all of that into a single template which renders all of
the actions (including the "archive" menu, which was previously only available
on the main review request page). The tabs are handled somewhat specially by
passing in a list of tab data into the template context. The logic for the
"current tab" is done by comparing the request path to the tab's URL.
Checked the header display and functionality on the main review request page,
the diff viewer page (with different diff revisions), and the image review UI.
Change Summary:
Remove leftover debug output.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+97 -85) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/reviews/models/review_request.py reviewboard/reviews/context.py Ignored Files: reviewboard/templates/diffviewer/view_diff.html reviewboard/templates/reviews/review_detail.html reviewboard/templates/reviews/ui/base.html reviewboard/templates/reviews/review_request_header.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/reviews/models/review_request.py reviewboard/reviews/context.py Ignored Files: reviewboard/templates/diffviewer/view_diff.html reviewboard/templates/reviews/review_detail.html reviewboard/templates/reviews/ui/base.html reviewboard/templates/reviews/review_request_header.html
Change Summary:
Fix markup in review UIs.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+97 -86) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/reviews/models/review_request.py reviewboard/reviews/context.py Ignored Files: reviewboard/templates/diffviewer/view_diff.html reviewboard/templates/reviews/review_detail.html reviewboard/templates/reviews/ui/base.html reviewboard/templates/reviews/review_request_header.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/reviews/models/review_request.py reviewboard/reviews/context.py Ignored Files: reviewboard/templates/diffviewer/view_diff.html reviewboard/templates/reviews/review_detail.html reviewboard/templates/reviews/ui/base.html reviewboard/templates/reviews/review_request_header.html
-
This is fantastic.
Would this be something we could safely ship with 2.5.x? Wondering because of the archive fix.
-
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+96 -86) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/reviews/models/review_request.py reviewboard/reviews/context.py Ignored Files: reviewboard/templates/diffviewer/view_diff.html reviewboard/templates/reviews/review_detail.html reviewboard/templates/reviews/ui/base.html reviewboard/templates/reviews/review_request_header.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/reviews/models/review_request.py reviewboard/reviews/context.py Ignored Files: reviewboard/templates/diffviewer/view_diff.html reviewboard/templates/reviews/review_detail.html reviewboard/templates/reviews/ui/base.html reviewboard/templates/reviews/review_request_header.html
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/reviews/models/review_request.py reviewboard/reviews/context.py Ignored Files: reviewboard/templates/diffviewer/view_diff.html reviewboard/templates/reviews/review_detail.html reviewboard/templates/reviews/ui/base.html reviewboard/templates/reviews/review_request_header.html reviewboard/static/rb/js/views/reviewRequestEditorView.js Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/reviews/models/review_request.py reviewboard/reviews/context.py Ignored Files: reviewboard/templates/diffviewer/view_diff.html reviewboard/templates/reviews/review_detail.html reviewboard/templates/reviews/ui/base.html reviewboard/templates/reviews/review_request_header.html reviewboard/static/rb/js/views/reviewRequestEditorView.js