Convert the rest of js/utils to ES6.
Review Request #8047 — Created March 9, 2016 and submitted — Latest diff uploaded
This change converts the rest of the code in js/utils to ES6 (at least that
which makes sense to do--there are a few files where there's no benefit). The
actual code has gotten shorter, but the number of lines is bigger because I
fleshed out and updated the format of our docstrings.This also removes some now-unused functionality to linkify text in Markdown
format (since we no longer do any Markdown rendering on the client side).If you want a good example of why this is awesome, check out the new
implementation of_.bindCallbacks
.
Ran js-tests.
Diff Revision 1 (Latest)
reviewboard/staticbundles.py | ||
reviewboard/static/rb/js/utils/consoleUtils.es6.js Was reviewboard/static/rb/js/utils/consoleUtils.js | ||
reviewboard/static/rb/js/utils/keyBindingUtils.es6.js Was reviewboard/static/rb/js/utils/keyBindingUtils.js | ||
reviewboard/static/rb/js/utils/linkifyUtils.js | Deleted | |
reviewboard/static/rb/js/utils/linkifyUtils.es6.js | ||
reviewboard/static/rb/js/utils/mathUtils.js | Deleted | |
reviewboard/static/rb/js/utils/mathUtils.es6.js | ||
reviewboard/static/rb/js/utils/textUtils.js | Deleted | |
reviewboard/static/rb/js/utils/textUtils.es6.js | ||
reviewboard/static/rb/js/utils/underscoreUtils.js | Deleted | |
reviewboard/static/rb/js/utils/underscoreUtils.es6.js | ||
reviewboard/static/rb/js/utils/tests/linkifyUtilsTests.js |
reviewboard/staticbundles.py |
---|
reviewboard/static/rb/js/utils/consoleUtils.js |
---|
reviewboard/static/rb/js/utils/keyBindingUtils.js |
---|
reviewboard/static/rb/js/utils/linkifyUtils.js |
---|
reviewboard/static/rb/js/utils/linkifyUtils.es6.js |
---|
reviewboard/static/rb/js/utils/mathUtils.js |
---|
reviewboard/static/rb/js/utils/mathUtils.es6.js |
---|
reviewboard/static/rb/js/utils/textUtils.js |
---|
reviewboard/static/rb/js/utils/textUtils.es6.js |
---|
reviewboard/static/rb/js/utils/underscoreUtils.js |
---|
reviewboard/static/rb/js/utils/underscoreUtils.es6.js |
---|
reviewboard/static/rb/js/utils/tests/linkifyUtilsTests.js |
---|