Summary

Convert the rest of js/utils to ES6.

Review Request #8047 — Created March 9, 2016 and submitted March 11, 2016, 9:34 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.6.x

Bugs

Depends On

Commit

de83f12...

Reviewers

Groups

reviewboard

People

Description

This change converts the rest of the code in js/utils to ES6 (at least that
which makes sense to do--there are a few files where there's no benefit). The
actual code has gotten shorter, but the number of lines is bigger because I
fleshed out and updated the format of our docstrings.

This also removes some now-unused functionality to linkify text in Markdown
format (since we no longer do any Markdown rendering on the client side).

If you want a good example of why this is awesome, check out the new
implementation of _.bindCallbacks.

Testing Done

Ran js-tests.

Issues

Description	From	Last Updated
It took me a few minutes to realize why these unit tests were being removed. They're left over from the …	chipx86	March 11, 2016, 9:32 a.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/utils/tests/linkifyUtilsTests.js
    reviewboard/static/rb/js/utils/mathUtils.es6.js
    reviewboard/static/rb/js/utils/consoleUtils.es6.js
    reviewboard/static/rb/js/utils/linkifyUtils.es6.js
    reviewboard/static/rb/js/utils/mathUtils.js
    reviewboard/static/rb/js/utils/underscoreUtils.js
    reviewboard/static/rb/js/utils/linkifyUtils.js
    reviewboard/static/rb/js/utils/keyBindingUtils.es6.js
    reviewboard/static/rb/js/utils/underscoreUtils.es6.js
    reviewboard/static/rb/js/utils/textUtils.js
    reviewboard/static/rb/js/utils/textUtils.es6.js



Tool: Pyflakes
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/utils/tests/linkifyUtilsTests.js
    reviewboard/static/rb/js/utils/mathUtils.es6.js
    reviewboard/static/rb/js/utils/consoleUtils.es6.js
    reviewboard/static/rb/js/utils/linkifyUtils.es6.js
    reviewboard/static/rb/js/utils/mathUtils.js
    reviewboard/static/rb/js/utils/underscoreUtils.js
    reviewboard/static/rb/js/utils/linkifyUtils.js
    reviewboard/static/rb/js/utils/keyBindingUtils.es6.js
    reviewboard/static/rb/js/utils/underscoreUtils.es6.js
    reviewboard/static/rb/js/utils/textUtils.js
    reviewboard/static/rb/js/utils/textUtils.es6.js

Ship it!

```
Ship It!
```

reviewboard/static/rb/js/utils/tests/linkifyUtilsTests.js (Diff revision 1)

The issue has been resolved. Show all issues

It took me a few minutes to realize why these unit tests were being removed. They're left over from the days when the browser would render to Markdown, right? Can we update the review request description to mention this support was removed as part of this, for any git blames down the road?

Description:

		This change converts the rest of the code in js/utils to ES6 (at least that
		which makes sense to do--there are a few files where there's no benefit). The
		actual code has gotten shorter, but the number of lines is bigger because I
		fleshed out and updated the format of our docstrings.

	+	This also removes some now-unused functionality to linkify text in Markdown
	+	format (since we no longer do any Markdown rendering on the client side).
	+
		If you want a good example of why this is awesome, check out the new
		implementation of `_.bindCallbacks`.

Status: Closed (submitted)

Change Summary:

Pushed to release-2.6.x (750240a)