Make editable implementations consistent.

Review Request #7908 — Created Jan. 25, 2016 and submitted

david
student-sonar
master
dd3d4d3...
student-sonar

Sonar uses several custom x-editable types, for various things. These were done
with a mix of ES6 classes and $.extend. I've changed it so they all use the
class-based implementation, and are consistent with regards to things like
EditableClass.defaults.

Tested each of the editables and saw that they still worked.

Description From Last Updated

This wasn't needed before, it seems. Why is it needed now?

mike_conleymike_conley

I don't understand. Aren't we already defining this up in editable-datepicker? Should this be something that we just do once ...

mike_conleymike_conley

Same as above regarding editableform... this looks like we're redefining this in three places.

mike_conleymike_conley
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        lib/frontend/editable-epiceditor.js
        lib/frontend/editable-selectize.js
        lib/frontend/editable-datepicker.js
        lib/frontend/all-status-reports-view.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        lib/frontend/editable-epiceditor.js
        lib/frontend/editable-selectize.js
        lib/frontend/editable-datepicker.js
        lib/frontend/all-status-reports-view.js
    
    
  2. 
      
mike_conley
  1. This looks good to me - just a few questions.

  2. lib/frontend/editable-epiceditor.js (Diff revision 1)
     
     

    This wasn't needed before, it seems. Why is it needed now?

    1. I'm not 100% sure but I think probably it was actually causing an error earlier and just got eaten by promises.

  3. lib/frontend/editable-epiceditor.js (Diff revision 1)
     
     
     
     
     
     
     
     
     

    I don't understand. Aren't we already defining this up in editable-datepicker? Should this be something that we just do once in a common place?

  4. lib/frontend/editable-selectize.js (Diff revision 1)
     
     
     
     
     
     
     
     
     

    Same as above regarding editableform... this looks like we're redefining this in three places.

  5. 
      
david
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        lib/frontend/editable-epiceditor.js
        lib/frontend/editable-defs.js
        lib/frontend/editable-selectize.js
        lib/frontend/editable-datepicker.js
        lib/frontend/all-status-reports-view.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        lib/frontend/editable-epiceditor.js
        lib/frontend/editable-defs.js
        lib/frontend/editable-selectize.js
        lib/frontend/editable-datepicker.js
        lib/frontend/all-status-reports-view.js
    
    
  2. 
      
mike_conley
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (6697d01)
Loading...