post-review: Fix a minor defect with binary files on a Perforce-Cygwin environment.

Review Request #787 — Created March 24, 2009 and submitted — Latest diff uploaded

Information

Review Board SVN (deprecated)

Reviewers

post-review: Fix a minor defect with binary files on a Perforce-Cygwin environment.

post-review crashes on Perforce-Cygwin environment because the error message from diff.exe - "Files %s and %s differ" -
had a trailing CR in it.

I have fixed it to just look for a startswith match.
Tested the fix with a changelist containing an Excel file and a bunch of Java files.