post-review: Fix a minor defect with binary files on a Perforce-Cygwin environment.

Review Request #787 — Created March 25, 2009 and submitted

raghu
Review Board SVN (deprecated)
reviewboard
post-review: Fix a minor defect with binary files on a Perforce-Cygwin environment.

post-review crashes on Perforce-Cygwin environment because the error message from diff.exe - "Files %s and %s differ" -
had a trailing CR in it.

I have fixed it to just look for a startswith match.
Tested the fix with a changelist containing an Excel file and a bunch of Java files.
chipx86
  1. Looks good, thanks! Committed as r1862.
    
    Note that we just moved post-review into /trunk/rbtools, so the change went into there.
  2. 
      
Loading...