Summary

Use registries for authentication backends

Review Request #7785 — Created Nov. 30, 2015 and submitted Dec. 11, 2015, 11:20 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.6.x

Bugs

Depends On

~~7780~~

Blocks

7786

Reviewers

Groups

reviewboard

People

Description

Authentication backends now use Djblets registries for managing the set
of backends. The external API remains unchanged.

There is now a reviewboard.registries module that contains a
specialized registry that populates from an entry point.

Since registries are in Djblets 0.10.x, this updates Review Board to
depend on that version of Djblets.

Testing Done


Ran unit tests.

Issues

Description	From	Last Updated
'EntryPointRegistry' imported but unused	reviewbot	Nov. 30, 2015, 11:18 p.m.
'EntryPointRegistry' imported but unused	reviewbot	Nov. 30, 2015, 11:20 p.m.
'EntryPointRegistry' imported but unused	reviewbot	Nov. 30, 2015, 11:45 p.m.
Docstring?	david	Dec. 11, 2015, 4:31 p.m.
Docstring?	david	Dec. 11, 2015, 4:29 p.m.
Docstring?	david	Dec. 11, 2015, 4:29 p.m.
'EntryPointRegistry' imported but unused	reviewbot	Dec. 8, 2015, 12:02 p.m.
This should be __all__, not __ALL__	david	Dec. 11, 2015, 4:31 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/accounts/backends.py
    reviewboard/registries/__init__.py
    reviewboard/registries/registry.py

Ignored Files:
    reviewboard/registries/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/accounts/backends.py
    reviewboard/registries/__init__.py
    reviewboard/registries/registry.py

Ignored Files:
    reviewboard/registries/tests.py

reviewboard/registries/__init__.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'EntryPointRegistry' imported but unused
```

Diff:

Revision 2 (+150 -101)

Show changes

	reviewboard/accounts/backends.py
	reviewboard/registries/__init__.py
	reviewboard/registries/registry.py
	reviewboard/registries/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/accounts/backends.py
    reviewboard/registries/__init__.py
    reviewboard/registries/registry.py

Ignored Files:
    reviewboard/registries/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/accounts/backends.py
    reviewboard/registries/__init__.py
    reviewboard/registries/registry.py

Ignored Files:
    reviewboard/registries/tests.py

reviewboard/registries/__init__.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'EntryPointRegistry' imported but unused
```

Diff:

Revision 3 (+150 -101)

Show changes

	reviewboard/accounts/backends.py
	reviewboard/registries/__init__.py
	reviewboard/registries/registry.py
	reviewboard/registries/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/accounts/backends.py
    reviewboard/registries/__init__.py
    reviewboard/registries/registry.py

Ignored Files:
    reviewboard/registries/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/accounts/backends.py
    reviewboard/registries/__init__.py
    reviewboard/registries/registry.py

Ignored Files:
    reviewboard/registries/tests.py

reviewboard/registries/__init__.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'EntryPointRegistry' imported but unused
```

Description:: Authentication backends now use Djblets registries for managing the set
~ of registries. The external API remains unchanged.
~ of backends. The external API remains unchanged.

There is now a reviewboard.registries module that contains a
specialized registry that populates from an entry point.

Change Summary:

Rebase off of updated Djblets

Diff:

Revision 4 (+165 -101)

Show changes

	reviewboard/accounts/backends.py
	reviewboard/registries/__init__.py
	reviewboard/registries/registry.py
	reviewboard/registries/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/accounts/backends.py
    reviewboard/registries/__init__.py
    reviewboard/registries/registry.py

Ignored Files:
    reviewboard/registries/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/accounts/backends.py
    reviewboard/registries/__init__.py
    reviewboard/registries/registry.py

Ignored Files:
    reviewboard/registries/tests.py

reviewboard/registries/__init__.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 'EntryPointRegistry' imported but unused
```

reviewboard/accounts/backends.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Docstring?
```
reviewboard/accounts/backends.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Docstring?
```
reviewboard/accounts/backends.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Docstring?
```
reviewboard/registries/__init__.py (Diff revision 4)
The issue has been resolved. Show all issues
```
This should be __all__, not __ALL__
```

Change Summary:

Address David's issues. Rebase off Djblets change

Diff:

Revision 5 (+195 -101)

Show changes

	reviewboard/accounts/backends.py
	reviewboard/registries/__init__.py
	reviewboard/registries/registry.py
	reviewboard/registries/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/accounts/backends.py
    reviewboard/registries/registry.py

Ignored Files:
    reviewboard/registries/tests.py
    reviewboard/registries/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/accounts/backends.py
    reviewboard/registries/registry.py

Ignored Files:
    reviewboard/registries/tests.py
    reviewboard/registries/__init__.py

Ship it!

```
Ship It!
```

Change Summary:

Translation support.

Diff:

Revision 6 (+202 -101)

Show changes

	reviewboard/accounts/backends.py
	reviewboard/registries/__init__.py
	reviewboard/registries/registry.py
	reviewboard/registries/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/accounts/backends.py
    reviewboard/registries/registry.py

Ignored Files:
    reviewboard/registries/tests.py
    reviewboard/registries/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/accounts/backends.py
    reviewboard/registries/registry.py

Ignored Files:
    reviewboard/registries/tests.py
    reviewboard/registries/__init__.py

Change Summary:

Depend on Djblets 0.10.x

Description:

		Authentication backends now use Djblets registries for managing the set
		of backends. The external API remains unchanged.

		There is now a `reviewboard.registries` module that contains a
		specialized registry that populates from an entry point.
	+
	+	Since registries are in Djblets 0.10.x, this updates Review Board to
	+	depend on that version of Djblets.

Diff:

Revision 7 (+203 -102)

Show changes

	setup.py
	reviewboard/accounts/backends.py
	reviewboard/registries/__init__.py
	reviewboard/registries/registry.py
	reviewboard/registries/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/accounts/backends.py
    setup.py
    reviewboard/registries/registry.py

Ignored Files:
    reviewboard/registries/tests.py
    reviewboard/registries/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/accounts/backends.py
    setup.py
    reviewboard/registries/registry.py

Ignored Files:
    reviewboard/registries/tests.py
    reviewboard/registries/__init__.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.6.x (ebc1240)

		Authentication backends now use Djblets registries for managing the set
~		of registries. The external API remains unchanged.
	~	of backends. The external API remains unchanged.

		There is now a `reviewboard.registries` module that contains a
		specialized registry that populates from an entry point.