'rbt close' to figure out the request-id similarly to how 'rbt post -u' figures it out

Review Request #7776 — Created Nov. 20, 2015 and updated

xutong
RBTools
release-0.7.x
rbtools

Making rbt close was capable of doing the same thing as rbt post -u do. Inferring the request-id number, asking to confirm it and submitting an confirmed request. Therefore, before using rbt close, users do not need to use rbt status and find the request-id number.

  1. Test rbt close
    1). Type rbt close and compare outputs with rbt post -u. Check if all the outputs are same.
    2). Choose a request-id and make the request submitted.
    3). Check the develop sever and see the choosen request has been submitted.
    4). Redo from step 1) and check if the submitted request still shown or not.
  2. Run all the unit tests, and see if the new version of rbt close break those original unit tests. And pass the unit tests.
Description From Last Updated

Col: 1 W293 blank line contains whitespace

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 55 E701 multiple statements on one line (colon)

reviewbotreviewbot

Col: 9 E122 continuation line missing indentation or outdented

reviewbotreviewbot

Col: 17 E127 continuation line over-indented for visual indent

reviewbotreviewbot

Col: 36 E113 unexpected indentation

reviewbotreviewbot

Col: 36 E111 indentation is not a multiple of four

reviewbotreviewbot

Col: 1 E122 continuation line missing indentation or outdented

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 1 W293 blank line contains whitespace

reviewbotreviewbot

Col: 1 W293 blank line contains whitespace

reviewbotreviewbot

Col: 1 W293 blank line contains whitespace

reviewbotreviewbot

Col: 9 E265 block comment should start with '# '

reviewbotreviewbot

Col: 9 E265 block comment should start with '# '

reviewbotreviewbot

Col: 9 E265 block comment should start with '# '

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 9 E265 block comment should start with '# '

reviewbotreviewbot

Col: 28 W291 trailing whitespace

reviewbotreviewbot

Col: 16 E201 whitespace after '('

reviewbotreviewbot

Col: 66 W291 trailing whitespace

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 1 W293 blank line contains whitespace

reviewbotreviewbot

Col: 1 W293 blank line contains whitespace

reviewbotreviewbot

Col: 1 W293 blank line contains whitespace

reviewbotreviewbot

Col: 9 E265 block comment should start with '# '

reviewbotreviewbot

Col: 9 E265 block comment should start with '# '

reviewbotreviewbot

Col: 9 E265 block comment should start with '# '

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 9 E265 block comment should start with '# '

reviewbotreviewbot

Col: 28 W291 trailing whitespace

reviewbotreviewbot

Col: 16 E201 whitespace after '('

reviewbotreviewbot

Col: 66 W291 trailing whitespace

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Is there an extra level of indentation here after the if?

SH sherman

In line 48, both the 'r's are capitalized in Review Request: question = ("Update Review Request #%s: '%s'? " Perhaps, ...

CH chronicleyu

Same here regarding capitalization.

CH chronicleyu

Col: 33 E127 continuation line over-indented for visual indent

reviewbotreviewbot
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/post.py
        rbtools/commands/close.py
    
    
  2. rbtools/commands/close.py (Diff revision 1)
     
     
    Col: 1
     W293 blank line contains whitespace
    
  3. rbtools/commands/close.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (81 > 79 characters)
    
  4. rbtools/commands/close.py (Diff revision 1)
     
     
    Col: 55
     E701 multiple statements on one line (colon)
    
  5. rbtools/commands/close.py (Diff revision 1)
     
     
    Col: 9
     E122 continuation line missing indentation or outdented
    
  6. rbtools/commands/close.py (Diff revision 1)
     
     
    Col: 17
     E127 continuation line over-indented for visual indent
    
  7. rbtools/commands/close.py (Diff revision 1)
     
     
    Col: 36
     E113 unexpected indentation
    
  8. rbtools/commands/close.py (Diff revision 1)
     
     
    Col: 36
     E111 indentation is not a multiple of four
    
  9. rbtools/commands/close.py (Diff revision 1)
     
     
    Col: 1
     E122 continuation line missing indentation or outdented
    
  10. rbtools/commands/close.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (81 > 79 characters)
    
  11. rbtools/commands/post.py (Diff revision 1)
     
     
    Col: 1
     W293 blank line contains whitespace
    
  12. 
      
XU
mike_conley
  1. Yes, I think you're on the right track here, Xutong! You're using guess_existing_review_request correctly from what I can see.

  2. 
      
XU
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/commands/post.py
        rbtools/commands/close.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/post.py
        rbtools/commands/close.py
    
    
  2. rbtools/commands/close.py (Diff revision 2)
     
     
    Col: 1
     W293 blank line contains whitespace
    
  3. rbtools/commands/close.py (Diff revision 2)
     
     
    Col: 1
     W293 blank line contains whitespace
    
  4. rbtools/commands/close.py (Diff revision 2)
     
     
    Col: 9
     E265 block comment should start with '# '
    
  5. rbtools/commands/close.py (Diff revision 2)
     
     
    Col: 9
     E265 block comment should start with '# '
    
  6. rbtools/commands/close.py (Diff revision 2)
     
     
    Col: 9
     E265 block comment should start with '# '
    
  7. rbtools/commands/close.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (81 > 79 characters)
    
  8. rbtools/commands/close.py (Diff revision 2)
     
     
    Col: 9
     E265 block comment should start with '# '
    
  9. rbtools/commands/close.py (Diff revision 2)
     
     
    Col: 28
     W291 trailing whitespace
    
  10. rbtools/commands/close.py (Diff revision 2)
     
     
    Col: 16
     E201 whitespace after '('
    
  11. rbtools/commands/close.py (Diff revision 2)
     
     
    Col: 66
     W291 trailing whitespace
    
  12. rbtools/commands/close.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (81 > 79 characters)
    
  13. rbtools/commands/post.py (Diff revision 2)
     
     
    Col: 1
     W293 blank line contains whitespace
    
  14. 
      
XU
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/commands/close.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/close.py
    
    
  2. rbtools/commands/close.py (Diff revision 3)
     
     
    Col: 1
     W293 blank line contains whitespace
    
  3. rbtools/commands/close.py (Diff revision 3)
     
     
    Col: 1
     W293 blank line contains whitespace
    
  4. rbtools/commands/close.py (Diff revision 3)
     
     
    Col: 9
     E265 block comment should start with '# '
    
  5. rbtools/commands/close.py (Diff revision 3)
     
     
    Col: 9
     E265 block comment should start with '# '
    
  6. rbtools/commands/close.py (Diff revision 3)
     
     
    Col: 9
     E265 block comment should start with '# '
    
  7. rbtools/commands/close.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (81 > 79 characters)
    
  8. rbtools/commands/close.py (Diff revision 3)
     
     
    Col: 9
     E265 block comment should start with '# '
    
  9. rbtools/commands/close.py (Diff revision 3)
     
     
    Col: 28
     W291 trailing whitespace
    
  10. rbtools/commands/close.py (Diff revision 3)
     
     
    Col: 16
     E201 whitespace after '('
    
  11. rbtools/commands/close.py (Diff revision 3)
     
     
    Col: 66
     W291 trailing whitespace
    
  12. rbtools/commands/close.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (81 > 79 characters)
    
  13. 
      
XU
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/commands/close.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/close.py
    
    
  2. 
      
XU
XU
XU
XU
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/close.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        rbtools/commands/close.py
    
    
  2. 
      
XU
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/commands/close.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/close.py
    
    
  2. 
      
SH
  1. 
      
  2. rbtools/commands/close.py (Diff revision 6)
     
     

    Is there an extra level of indentation here after the if?

  3. 
      
CH
  1. 
      
  2. rbtools/commands/close.py (Diff revision 6)
     
     

    In line 48, both the 'r's are capitalized in Review Request:

    question = ("Update Review Request #%s: '%s'? "

    Perhaps, to keep things consistent, we should do the same here as well.

    The documentation (https://www.reviewboard.org/docs/manual/dev/contents/) seems to treat a Review Request as a proper noun.

  3. rbtools/commands/close.py (Diff revision 6)
     
     

    Same here regarding capitalization.

  4. 
      
XU
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/commands/close.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/close.py
    
    
  2. rbtools/commands/close.py (Diff revision 7)
     
     
    Col: 33
     E127 continuation line over-indented for visual indent
    
  3. 
      
XU
Review request changed
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/close.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        rbtools/commands/close.py
    
    
  2. 
      
Loading...