-
-
-
-
-
rbtools/commands/close.py (Diff revision 1) Col: 9 E122 continuation line missing indentation or outdented
-
rbtools/commands/close.py (Diff revision 1) Col: 17 E127 continuation line over-indented for visual indent
-
-
-
rbtools/commands/close.py (Diff revision 1) Col: 1 E122 continuation line missing indentation or outdented
-
-
'rbt close' to figure out the request-id similarly to how 'rbt post -u' figures it out
Review Request #7776 — Created Nov. 20, 2015 and discarded
| Information | |
|---|---|
| xutong | |
| RBTools | |
| release-0.7.x | |
| Reviewers | |
| rbtools | |
Making rbt close was capable of doing the same thing as rbt post -u do. Inferring the request-id number, asking to confirm it and submitting an confirmed request. Therefore, before using rbt close, users do not need to use rbt status and find the request-id number.
- Test rbt close
1). Type rbt close and compare outputs with rbt post -u. Check if all the outputs are same.
2). Choose a request-id and make the request submitted.
3). Check the develop sever and see the choosen request has been submitted.
4). Redo from step 1) and check if the submitted request still shown or not.- Run all the unit tests, and see if the new version of rbt close break those original unit tests. And pass the unit tests.
| Description | From | Last Updated |
|---|---|---|
|
Col: 1 W293 blank line contains whitespace |
 reviewbot
|
|
|
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot
|
|
|
Col: 55 E701 multiple statements on one line (colon) |
reviewbot
|
|
|
Col: 9 E122 continuation line missing indentation or outdented |
reviewbot
|
|
|
Col: 17 E127 continuation line over-indented for visual indent |
reviewbot
|
|
|
Col: 36 E113 unexpected indentation |
reviewbot
|
|
|
Col: 36 E111 indentation is not a multiple of four |
reviewbot
|
|
|
Col: 1 E122 continuation line missing indentation or outdented |
reviewbot
|
|
|
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot
|
|
|
Col: 1 W293 blank line contains whitespace |
reviewbot
|
|
|
Col: 1 W293 blank line contains whitespace |
reviewbot
|
|
|
Col: 1 W293 blank line contains whitespace |
reviewbot
|
|
|
Col: 9 E265 block comment should start with '# ' |
reviewbot
|
|
|
Col: 9 E265 block comment should start with '# ' |
reviewbot
|
|
|
Col: 9 E265 block comment should start with '# ' |
reviewbot
|
|
|
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot
|
|
|
Col: 9 E265 block comment should start with '# ' |
reviewbot
|
|
|
Col: 28 W291 trailing whitespace |
reviewbot
|
|
|
Col: 16 E201 whitespace after '(' |
reviewbot
|
|
|
Col: 66 W291 trailing whitespace |
reviewbot
|
|
|
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot
|
|
|
Col: 1 W293 blank line contains whitespace |
reviewbot
|
|
|
Col: 1 W293 blank line contains whitespace |
reviewbot
|
|
|
Col: 1 W293 blank line contains whitespace |
reviewbot
|
|
|
Col: 9 E265 block comment should start with '# ' |
reviewbot
|
|
|
Col: 9 E265 block comment should start with '# ' |
reviewbot
|
|
|
Col: 9 E265 block comment should start with '# ' |
reviewbot
|
|
|
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot
|
|
|
Col: 9 E265 block comment should start with '# ' |
reviewbot
|
|
|
Col: 28 W291 trailing whitespace |
reviewbot
|
|
|
Col: 16 E201 whitespace after '(' |
reviewbot
|
|
|
Col: 66 W291 trailing whitespace |
reviewbot
|
|
|
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot
|
|
|
Is there an extra level of indentation here after the if? |
SH sherman | |
|
In line 48, both the 'r's are capitalized in Review Request: question = ("Update Review Request #%s: '%s'? " Perhaps, … |
CH chronicleyu | |
|
Same here regarding capitalization. |
CH chronicleyu | |
|
Col: 33 E127 continuation line over-indented for visual indent |
reviewbot
|
-
Yes, I think you're on the right track here, Xutong! You're using guess_existing_review_request correctly from what I can see.
-
Tool: Pyflakes Processed Files: rbtools/commands/post.py rbtools/commands/close.py Tool: PEP8 Style Checker Processed Files: rbtools/commands/post.py rbtools/commands/close.py -
-
-
-
-
-
-
-
-
-
-
-
-
Tool: Pyflakes Processed Files: rbtools/commands/close.py Tool: PEP8 Style Checker Processed Files: rbtools/commands/close.py -
-
-
-
-
-
-
-
-
-
-
-
Tool: Pyflakes Processed Files: rbtools/commands/close.py Tool: PEP8 Style Checker Processed Files: rbtools/commands/close.py
XU
Description: |
|
||||||
|---|---|---|---|---|---|---|---|
Testing Done: |
|
XU
Testing Done: |
|
|---|
-
Tool: PEP8 Style Checker Processed Files: rbtools/commands/close.py Tool: Pyflakes Processed Files: rbtools/commands/close.py
-
Tool: Pyflakes Processed Files: rbtools/commands/close.py Tool: PEP8 Style Checker Processed Files: rbtools/commands/close.py
SH
-
-
rbtools/commands/close.py (Diff revision 6) Is there an extra level of indentation here after the
if?
CH
-
-
rbtools/commands/close.py (Diff revision 6) In line 48, both the 'r's are capitalized in
Review Request:question = ("Update Review Request #%s: '%s'? "Perhaps, to keep things consistent, we should do the same here as well.
The documentation (https://www.reviewboard.org/docs/manual/dev/contents/) seems to treat a Review Request as a proper noun.
-
-
Tool: Pyflakes Processed Files: rbtools/commands/close.py Tool: PEP8 Style Checker Processed Files: rbtools/commands/close.py -
rbtools/commands/close.py (Diff revision 7) Col: 33 E127 continuation line over-indented for visual indent
Tool: PEP8 Style Checker Processed Files: rbtools/commands/post.py rbtools/commands/close.py