Summary

'rbt close' to figure out the request-id similarly to how 'rbt post -u' figures it out

Review Request #7776 — Created Nov. 20, 2015 and discarded Dec. 18, 2020, 4:31 p.m.

Information

Owner

xutong

Repository

RBTools

Branch

release-0.7.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Making rbt close was capable of doing the same thing as rbt post -u do. Inferring the request-id number, asking to confirm it and submitting an confirmed request. Therefore, before using rbt close, users do not need to use rbt status and find the request-id number.

Testing Done


Test rbt close

    1). Type rbt close and compare outputs with rbt post -u. Check if all the outputs are same.

    2). Choose a request-id and make the request submitted.

    3). Check the develop sever and see the choosen request has been submitted.

    4). Redo from step 1) and check if the submitted request still shown or not.
Run all the unit tests, and see if the new version of rbt close break those original unit tests. And pass the unit tests.

Issues

Description	From	Last Updated
Col: 1 W293 blank line contains whitespace	reviewbot	Nov. 26, 2015, 10:49 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 26, 2015, 10:49 a.m.
Col: 55 E701 multiple statements on one line (colon)	reviewbot	Nov. 26, 2015, 10:49 a.m.
Col: 9 E122 continuation line missing indentation or outdented	reviewbot	Nov. 26, 2015, 10:49 a.m.
Col: 17 E127 continuation line over-indented for visual indent	reviewbot	Nov. 26, 2015, 10:49 a.m.
Col: 36 E113 unexpected indentation	reviewbot	Nov. 26, 2015, 10:49 a.m.
Col: 36 E111 indentation is not a multiple of four	reviewbot	Nov. 26, 2015, 10:49 a.m.
Col: 1 E122 continuation line missing indentation or outdented	reviewbot	Nov. 26, 2015, 10:49 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 26, 2015, 10:49 a.m.
Col: 1 W293 blank line contains whitespace	reviewbot	Nov. 26, 2015, 10:49 a.m.
Col: 1 W293 blank line contains whitespace	reviewbot	Nov. 26, 2015, 10:49 a.m.
Col: 1 W293 blank line contains whitespace	reviewbot	Nov. 26, 2015, 10:49 a.m.
Col: 9 E265 block comment should start with '# '	reviewbot	Nov. 26, 2015, 10:49 a.m.
Col: 9 E265 block comment should start with '# '	reviewbot	Nov. 26, 2015, 10:49 a.m.
Col: 9 E265 block comment should start with '# '	reviewbot	Nov. 26, 2015, 10:49 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 26, 2015, 10:49 a.m.
Col: 9 E265 block comment should start with '# '	reviewbot	Nov. 26, 2015, 10:48 a.m.
Col: 28 W291 trailing whitespace	reviewbot	Nov. 26, 2015, 10:48 a.m.
Col: 16 E201 whitespace after '('	reviewbot	Nov. 26, 2015, 10:48 a.m.
Col: 66 W291 trailing whitespace	reviewbot	Nov. 26, 2015, 10:48 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 26, 2015, 10:48 a.m.
Col: 1 W293 blank line contains whitespace	reviewbot	Nov. 26, 2015, 10:48 a.m.
Col: 1 W293 blank line contains whitespace	reviewbot	Nov. 26, 2015, 10:47 a.m.
Col: 1 W293 blank line contains whitespace	reviewbot	Nov. 26, 2015, 10:47 a.m.
Col: 9 E265 block comment should start with '# '	reviewbot	Nov. 26, 2015, 10:47 a.m.
Col: 9 E265 block comment should start with '# '	reviewbot	Nov. 26, 2015, 10:47 a.m.
Col: 9 E265 block comment should start with '# '	reviewbot	Nov. 26, 2015, 10:46 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 26, 2015, 10:46 a.m.
Col: 9 E265 block comment should start with '# '	reviewbot	Nov. 26, 2015, 10:45 a.m.
Col: 28 W291 trailing whitespace	reviewbot	Nov. 26, 2015, 10:45 a.m.
Col: 16 E201 whitespace after '('	reviewbot	Nov. 26, 2015, 10:45 a.m.
Col: 66 W291 trailing whitespace	reviewbot	Nov. 26, 2015, 10:45 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 26, 2015, 10:44 a.m.
Is there an extra level of indentation here after the if?	SH sherman	Dec. 2, 2015, 7:13 p.m.
In line 48, both the 'r's are capitalized in Review Request: question = ("Update Review Request #%s: '%s'? " Perhaps, …	CH chronicleyu	Dec. 2, 2015, 7:12 p.m.
Same here regarding capitalization.	CH chronicleyu	Dec. 2, 2015, 7:12 p.m.
Col: 33 E127 continuation line over-indented for visual indent	reviewbot	Dec. 2, 2015, 7:26 p.m.

Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/post.py
    rbtools/commands/close.py

rbtools/commands/close.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
rbtools/commands/close.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/commands/close.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 55
 E701 multiple statements on one line (colon)
```
rbtools/commands/close.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 9
 E122 continuation line missing indentation or outdented
```
rbtools/commands/close.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 17
 E127 continuation line over-indented for visual indent
```
rbtools/commands/close.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 36
 E113 unexpected indentation
```
rbtools/commands/close.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 36
 E111 indentation is not a multiple of four
```
rbtools/commands/close.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 E122 continuation line missing indentation or outdented
```
rbtools/commands/close.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/commands/post.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```

Description:: ~
edit
~
Need to confirmed if I am on the right track...

Yes, I think you're on the right track here, Xutong! You're using guess_existing_review_request correctly from what I can see.

Diff:

Revision 2 (+45 -8)

Show changes

	rbtools/commands/close.py
	rbtools/commands/post.py

Tool: Pyflakes
Processed Files:
    rbtools/commands/post.py
    rbtools/commands/close.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/post.py
    rbtools/commands/close.py

rbtools/commands/close.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
rbtools/commands/close.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
rbtools/commands/close.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 9
 E265 block comment should start with '# '
```
rbtools/commands/close.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 9
 E265 block comment should start with '# '
```
rbtools/commands/close.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 9
 E265 block comment should start with '# '
```
rbtools/commands/close.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/commands/close.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 9
 E265 block comment should start with '# '
```
rbtools/commands/close.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 28
 W291 trailing whitespace
```
rbtools/commands/close.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 16
 E201 whitespace after '('
```
rbtools/commands/close.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 66
 W291 trailing whitespace
```
rbtools/commands/close.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/commands/post.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```

Diff:

Revision 3 (+44 -7)

Show changes

rbtools/commands/close.py

Tool: Pyflakes
Processed Files:
    rbtools/commands/close.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/close.py

rbtools/commands/close.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
rbtools/commands/close.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
rbtools/commands/close.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 9
 E265 block comment should start with '# '
```
rbtools/commands/close.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 9
 E265 block comment should start with '# '
```
rbtools/commands/close.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 9
 E265 block comment should start with '# '
```
rbtools/commands/close.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/commands/close.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 9
 E265 block comment should start with '# '
```
rbtools/commands/close.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 28
 W291 trailing whitespace
```
rbtools/commands/close.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 16
 E201 whitespace after '('
```
rbtools/commands/close.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 66
 W291 trailing whitespace
```
rbtools/commands/close.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```

Diff:

Revision 4 (+41 -8)

Show changes

rbtools/commands/close.py

Tool: Pyflakes
Processed Files:
    rbtools/commands/close.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/close.py

Description:: ~
Need to confirmed if I am on the right track...
~
Making rbt close was capable of doing the same thing as rbt post -u do. Inferring the request-id number, asking to confirm it and submitting an confirmed request. Therefore, before using rbt close, users do not need to use rbt status and find the request-id number.
Testing Done:: +
Test rbt close
1). Type rbt close and compare outputs with rbt post -u. Check if all the outputs are same.
2). Choose a request-id and make the request submitted.
3). Check the develop sever and see the choosen request has been submitted.
4). Redo from step 1) and check if the submitted request still shown or not.
+
Run all the unit tests, and see if the new version of rbt close break those original unit tests.

Testing Done:: Test rbt close
1). Type rbt close and compare outputs with rbt post -u. Check if all the outputs are same.
2). Choose a request-id and make the request submitted.
3). Check the develop sever and see the choosen request has been submitted.
4). Redo from step 1) and check if the submitted request still shown or not.
~
Run all the unit tests, and see if the new version of rbt close break those original unit tests.
~
Run all the unit tests, and see if the new version of rbt close break those original unit tests. And pass the unit tests.

Summary:: [WIP] 'rbt close' to figure out the request-id similarly to how 'rbt post -u' figures it out
'rbt close' to figure out the request-id similarly to how 'rbt post -u' figures it out

Diff:

Revision 5 (+41 -8)

Show changes

rbtools/commands/close.py

Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/close.py



Tool: Pyflakes
Processed Files:
    rbtools/commands/close.py

Diff:

Revision 6 (+30 -9)

Show changes

rbtools/commands/close.py

Tool: Pyflakes
Processed Files:
    rbtools/commands/close.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/close.py

rbtools/commands/close.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Is there an extra level of indentation here after the if?
```

rbtools/commands/close.py (Diff revision 6)

The issue has been resolved. Show all issues

In line 48, both the 'r's are capitalized in Review Request:

question = ("Update Review Request #%s: '%s'? "

Perhaps, to keep things consistent, we should do the same here as well.

The documentation (https://www.reviewboard.org/docs/manual/dev/contents/) seems to treat a Review Request as a proper noun.

rbtools/commands/close.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Same here regarding capitalization.
```

Diff:

Revision 7 (+32 -11)

Show changes

rbtools/commands/close.py

Tool: Pyflakes
Processed Files:
    rbtools/commands/close.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/close.py

rbtools/commands/close.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Col: 33
 E127 continuation line over-indented for visual indent
```

Diff:

Revision 8 (+32 -11)

Show changes

rbtools/commands/close.py

Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/close.py



Tool: Pyflakes
Processed Files:
    rbtools/commands/close.py

Status:: Discarded

~		Need to confirmed if I am on the right track...
	~	Making rbt close was capable of doing the same thing as rbt post -u do. Inferring the request-id number, asking to confirm it and submitting an confirmed request. Therefore, before using rbt close, users do not need to use rbt status and find the request-id number.

	+	Test rbt close 1). Type rbt close and compare outputs with rbt post -u. Check if all the outputs are same. 2). Choose a request-id and make the request submitted. 3). Check the develop sever and see the choosen request has been submitted. 4). Redo from step 1) and check if the submitted request still shown or not.
	+	Run all the unit tests, and see if the new version of rbt close break those original unit tests.