Fixed settings_local.py database path not being absolute.
Review Request #7684 — Created Oct. 9, 2015 and submitted
| Information | |
|---|---|
| phngo | |
| Review Board | |
| master | |
| 3989 | |
| 037259a... | |
| Reviewers | |
| reviewboard | |
When running rb-vm-env on Vagrant, would get relative database path in settings_local.py, which would cause some errors. Such as:
"Testing a SFTP-backed bzr repository ... ERROR:root:Could not load siteconfig: no such table: django_site"Added an import and a path variable to settings_local.py.tmpl
Edited a string that prepare-dev.py wrote into the template.
Performed Review Board unit tests
$cd /src/reviewboard
$./reviewboard/manage.py testRan prepare-dev.py to check if it would create settings_local.py correctly.
| Description | From | Last Updated |
|---|---|---|
|
Setting SITE_ROOT isn't correct (SITE_ROOT is when you want Review Board to appear in a subdirectory of a webserver, for … |
 david
|
|
|
We should use __file__ here, rather than SITE_ROOT. |
david
|
|
|
Please add one more blank line in here (there should be two blank lines between the imports and the first … |
david
|
PH
Summary: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||||||||
Testing Done: |
|
||||||||||||||||||
Bugs: |
|
-
You've ended up adding a bunch of extra junk to git (
.DS_Store,<fdopen>, etc.). Please remove these from your change. -
contrib/conf/settings_local.py.tmpl (Diff revision 1) Setting
SITE_ROOTisn't correct (SITE_ROOT is when you want Review Board to appear in a subdirectory of a webserver, for example, it would be set to "/reviewboard/" if you wanted to access your installation at http://repos.company.com/reviewboard/) -
contrib/internal/prepare-dev.py (Diff revision 1) We should use
__file__here, rather than SITE_ROOT.
PH
Change Summary:
Changed the PATH and removed random git files
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+7 -2) |
-
Tool: Pyflakes Processed Files: contrib/internal/prepare-dev.py Ignored Files: contrib/conf/settings_local.py.tmpl Tool: PEP8 Style Checker Processed Files: contrib/internal/prepare-dev.py Ignored Files: contrib/conf/settings_local.py.tmpl
-
Looking pretty good! Just one more trivial thing.
-
contrib/conf/settings_local.py.tmpl (Diff revision 2) Please add one more blank line in here (there should be two blank lines between the imports and the first thing in the file).
PH
Change Summary:
Added newline
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+7 -2) |
Tool: Pyflakes Processed Files: contrib/internal/prepare-dev.py Ignored Files: contrib/conf/settings_local.py.tmpl reviewboard/<fdopen> contrib/.DS_Store reviewboard/scmtools/testdata/hg_repo/.hg/cache/branchheads .DS_Store Tool: PEP8 Style Checker Processed Files: contrib/internal/prepare-dev.py Ignored Files: contrib/conf/settings_local.py.tmpl reviewboard/<fdopen> contrib/.DS_Store reviewboard/scmtools/testdata/hg_repo/.hg/cache/branchheads .DS_Store