Ensure e-mail headers are binary type

Review Request #7611 — Created Aug. 26, 2015 and submitted

Information

Review Board
release-2.0.x

Reviewers

String literals are unicode by default so including headers from string
literals will result in unicode headers, which will result in unhappy
e-mails. We now ensure that e-mail headers are added to messages as a
binary type.

Unit tests have been updated to be more thorough about checking for
error states.

Unit tests pass.

brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/notifications/email.py
        reviewboard/notifications/tests.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/notifications/email.py
        reviewboard/notifications/tests.py
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (a226005)
Loading...