Summary

Ensure e-mail headers are binary type

Review Request #7611 — Created Aug. 26, 2015 and submitted Aug. 26, 2015, 7:03 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

String literals are unicode by default so including headers from string
literals will result in unicode headers, which will result in unhappy
e-mails. We now ensure that e-mail headers are added to messages as a
binary type.

Unit tests have been updated to be more thorough about checking for
error states.

Testing Done

Unit tests pass.

Description:: ~
FIX
~
String literals are unicode by default so including headers from string
+ literals will result in unicode headers, which will result in unhappy
+ e-mails. We now ensure that e-mail headers are added to messages as a
+ binary type.
+
+
Unit tests have been updated to be more thorough about checking for
+ error states.

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (a226005)

~		FIX
	~	String literals are unicode by default so including headers from string
	+	literals will result in unicode headers, which will result in unhappy
	+	e-mails. We now ensure that e-mail headers are added to messages as a
	+	binary type.
	+
	+	Unit tests have been updated to be more thorough about checking for
	+	error states.