Fix "environment can only contain strings" errors.
Review Request #7522 — Created July 14, 2015 and submitted
On Windows hosts, setting things into the environment requires passing in bytes
rather than unicode. Normally I wouldn't really care, but this does also affect
power pack installations.
Ran unit tests. There are a few failures with rbssh, but those were already
present, and are related to the python path.
| Description | From | Last Updated |
|---|---|---|
|
'reviewboard' imported but unused |
 reviewbot
|
|
|
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot
|
|
|
I think this might cause upgrade issue with python 2.5, or i am missing something here. |
AM Aman | |
|
'reviewboard' imported but unused |
reviewbot
|
|
|
Missing a bytestring here. |
 chipx86
|
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+20 -16) |
-
Tool: Pyflakes Processed Files: reviewboard/admin/siteconfig.py reviewboard/ssh/utils.py reviewboard/extensions/packaging.py reviewboard/__init__.py reviewboard/scmtools/core.py reviewboard/cmdline/rbssh.py reviewboard/manage.py reviewboard/cmdline/rbsite.py reviewboard/admin/tests.py Tool: PEP8 Style Checker Processed Files: reviewboard/admin/siteconfig.py reviewboard/ssh/utils.py reviewboard/extensions/packaging.py reviewboard/__init__.py reviewboard/scmtools/core.py reviewboard/cmdline/rbssh.py reviewboard/manage.py reviewboard/cmdline/rbsite.py reviewboard/admin/tests.py -
AM
-
-
reviewboard/__init__.py (Diff revision 2) I think this might cause upgrade issue with python 2.5, or i am missing something here.
Tool: Pyflakes Processed Files: reviewboard/admin/siteconfig.py reviewboard/ssh/utils.py reviewboard/extensions/packaging.py reviewboard/__init__.py reviewboard/scmtools/core.py reviewboard/cmdline/rbssh.py reviewboard/manage.py reviewboard/cmdline/rbsite.py reviewboard/admin/tests.py Tool: PEP8 Style Checker Processed Files: reviewboard/admin/siteconfig.py reviewboard/ssh/utils.py reviewboard/extensions/packaging.py reviewboard/__init__.py reviewboard/scmtools/core.py reviewboard/cmdline/rbssh.py reviewboard/manage.py reviewboard/cmdline/rbsite.py reviewboard/admin/tests.py