Summary

Process mercurial diffs in binary mode.

Review Request #7473 — Created July 2, 2015 and submitted July 7, 2015, 1:56 p.m.

Information

Owner

david

Repository

RBTools

Branch

release-0.7.x

Bugs

Depends On

Commit

06bf3e7...

Reviewers

Groups

rbtools

People

Description

The mercurial client in RBTools had never been updated to use unicode_literals,
and hadn't been audited to make sure we weren't trying to mix unicode and str
objects. This change converts things to use unicode everywhere that's
appropriate, and process the diffs entirely as bytes.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Blank line between these.	brennie	July 7, 2015, 1:56 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	July 2, 2015, 6:18 p.m.

Tool: Pyflakes
Processed Files:
    rbtools/clients/mercurial.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/mercurial.py

rbtools/clients/mercurial.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```

Ship it!

rbtools/clients/mercurial.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.7.x (3a9e24e)