Fix line counts returned by DiffCommitModel
Review Request #7236 — Created April 22, 2015 and submitted
Previously, the total line counts returned was the concatenation of the
keys of thelineCountsobject. This has been fixed to return the
actual sum of the elements in the object and the logic has been
simplified. This fixes the visual style of the
RB.DiffComplexityIconViews in theRB.DiffCommitIndexView.
Verified the line counts returned by the
getTotalLineCountsfunction
were indeed an integer.
| Description | From | Last Updated |
|---|---|---|
|
Is the real difference between the two that we're now concatenating the values and not the keys? If so, we … |
 chipx86
|
-
-
reviewboard/static/rb/js/diffviewer/models/diffCommitModel.js (Diff revision 1) Is the real difference between the two that we're now concatenating the values and not the keys? If so, we can we go back to the previous form of hte code?
My reason being that, while there's a lot of neat functional stuff in underscore, it adds a readability overhead. Anyone coming in and working with this code will understand the loop and summing, but they'd have to look up and read through the docs of
_.reduce.It's also a lot slower, because underscore doesn't chain, and is pretty bad with performance. So instead of one loop, we're doing three now: One to compute the values, one to compute the keys (internal to
_.values, one to sum).If anything, given thow many line counts can be in a large file, we should probably go the other route and get rid of all function calls, just doing a native iteration of
lineCounts.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+7 -4) |
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/diffviewer/models/diffCommitModel.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/diffviewer/models/diffCommitModel.js