Fix trophy blocktrans

Review Request #705 — Created Jan. 15, 2009 and submitted

Information

Review Board SVN (deprecated)
trunk

Reviewers

Visiting a review that has a trophy causes an exception, reporting that "review_request.id" is an invalid key.  The blocktrans can't evaluate that expression, so it's trying to use that as a dict key directly.  The fix is to just prepare the id before entering the blocktrans.

SVN r1619 introduced this bug, since before that the trophy code didn't have a blocktrans.
Verified that a trophy review now renders correctly.
CU
  1. 
      
  2. BTW, here's an unrelated bug: the inline change highlighter doesn't seem to parse this change very well...
    1. Oh, that's actually correct, if you think about it. Those aren't replaces. The "and review_request.id as id" is an insert, and the "review_request." is a delete. It just seems weird.
  3. 
      
chipx86
  1. Thanks. Committed as r1671.
    
    That's weird about the inline highlighting.. No clue what to say about that.
  2.