Issue 3643: Focus on Username on login

Review Request #6731 — Created Jan. 4, 2015 and submitted

jyuen
Review Board
master
3643
1b6f00c...
reviewboard, students

Originally, the cursor focus would not be on the Username field in the login page. This resulted in users have to press tab multiple times or click on the Username field before filling in the username. With the fix, autofocus is added to the Username field so that the Username field is focused by default.

  • Reloaded the login page, and made sure that cursor / focus is on Username field.
  • Ensured login by email is still functional.
  • Attempted login
  • Attempted to change focus
Description From Last Updated

Col: 1 W293 blank line contains whitespace

reviewbotreviewbot

This change makes the docstring for the Authentication form only contain "Form used for user logins." Move the username field ...

brenniebrennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/accounts/forms/auth.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/accounts/forms/auth.py
    
    
  2. reviewboard/accounts/forms/auth.py (Diff revision 1)
     
     
    Col: 1
     W293 blank line contains whitespace
    
  3. 
      
JY
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/accounts/forms/auth.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/accounts/forms/auth.py
    
    
  2. 
      
brennie
  1. <p>The description of the review request should be more descriptive. Briefly describe the bug and how the fix works.</p>

  2. reviewboard/accounts/forms/auth.py (Diff revision 2)
     
     
     
     
     
     
     
     

    This change makes the docstring for the Authentication form only contain "Form used for user logins."

    Move the username field so that it occurs after the docstring.

  3. 
      
JY
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/accounts/forms/auth.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/accounts/forms/auth.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
JY
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (3df5b06)
Loading...