Summary

Issue 3643: Focus on Username on login

Review Request #6731 — Created Jan. 4, 2015 and submitted Jan. 6, 2015, 2:46 p.m.

Information

Owner

jyuen

Repository

Review Board

Branch

master

Bugs

3643

Depends On

Commit

1b6f00c...

Reviewers

Groups

reviewboard, students

People

Description

Originally, the cursor focus would not be on the Username field in the login page. This resulted in users have to press tab multiple times or click on the Username field before filling in the username. With the fix, autofocus is added to the Username field so that the Username field is focused by default.

Testing Done


Reloaded the login page, and made sure that cursor / focus is on Username field. 
Ensured login by email is still functional.
Attempted login
Attempted to change focus

Issues

Description	From	Last Updated
Col: 1 W293 blank line contains whitespace	reviewbot	Jan. 4, 2015, 4:39 p.m.
This change makes the docstring for the Authentication form only contain "Form used for user logins." Move the username field …	brennie	Jan. 5, 2015, 5:40 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/accounts/forms/auth.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/accounts/forms/auth.py

reviewboard/accounts/forms/auth.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```

Change Summary:

Removed whitespaces on empty line

Commit:

49c9f7a9b144bcc5eca492cda817890a5c1ad7b4

dcb0408facad11e8b0f6ae28e53f76671046f094

Diff:

Revision 2 (+5 -2)

Show changes

reviewboard/accounts/forms/auth.py

Tool: Pyflakes
Processed Files:
    reviewboard/accounts/forms/auth.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/accounts/forms/auth.py

<p>The description of the review request should be more descriptive. Briefly describe the bug and how the fix works.</p>

reviewboard/accounts/forms/auth.py (Diff revision 2)

The issue has been resolved. Show all issues

This change makes the docstring for the Authentication form only contain "Form used for user logins."

Move the username field so that it occurs after the docstring.

Change Summary:

Modifying code and review request description based on Barret's feedback

Description:

~		Issue 3643: Focus on Username on login
	~	Originally, the cursor focus would not be on the Username field in the login page. This resulted in users have to press tab multiple times or click on the Username field before filling in the username. With the fix, autofocus is added to the Username field so that the Username field is focused by default.

Commit:

dcb0408facad11e8b0f6ae28e53f76671046f094

1b6f00c0fe975dd12251431ed2ea561e0acc6d44

Diff:

Revision 3 (+4)

Show changes

reviewboard/accounts/forms/auth.py

Tool: Pyflakes
Processed Files:
    reviewboard/accounts/forms/auth.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/accounts/forms/auth.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (3df5b06)