• 
      

    Make it optional to push the branch after landing in rbt land.

    Review Request #6718 — Created Jan. 1, 2015 and submitted

    Information

    RBTools
    master
    1a4f7c8...

    Reviewers

    rbt land no longer pushes the branch after landing by default. Instead,
    the caller can either pass --push, or can set the default in LAND_PUSH
    in .reviewboardrc. If set by default, it can be overridden again using
    --no-push.

    This behavior change prevents unwanted pushes in the default case, such
    as when the committer wishes to test further before pushing, or wants to
    edit some part of the change.

    Wired off the actual operations and instead printed the options.push value.

    Tested the default without any arguments. Got push == False.

    Tested with --push. Got push == True.

    Tested with LAND_PUSH = True in .reviewboardrc and no arguments. Got push == True.

    Then tested with --no-push. Got push == False.

    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          rbtools/commands/land.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          rbtools/commands/land.py
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (892d0bc)