Summary

Allow ALIASES and TREES to be merged in configs

Review Request #6649 — Created Nov. 26, 2014 and submitted Nov. 30, 2014, 2:24 p.m.

Owner

Repository

RBTools

Branch

master

Bugs

Depends On

Commit

181965d...

Groups

People

Description

Give special treatment to the ALIASES and TREES keys in
.reviewboardrc so that they are merged together and not overwritten.

Testing Done

Ran unit tests.

Created a ../.reviewboardrc and ./.reviewboardrc with different
aliases and was able to execute all of them.

Issues

Description	From	Last Updated
Let's add a blank line here.	chipx86	Nov. 30, 2014, 2:19 p.m.
No blank line needed here.	chipx86	Nov. 30, 2014, 2:19 p.m.
You can condense this with: trees.update(parsed_config.pop('TREES')) etc.	chipx86	Nov. 30, 2014, 2:19 p.m.

Tool: PEP8 Style Checker
Processed Files:
    rbtools/utils/filesystem.py



Tool: Pyflakes
Processed Files:
    rbtools/utils/filesystem.py

rbtools/utils/filesystem.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Let's add a blank line here.
```
rbtools/utils/filesystem.py (Diff revision 1)
The issue has been resolved. Show all issues
```
No blank line needed here.
```

rbtools/utils/filesystem.py (Diff revision 1)

The issue has been resolved. Show all issues

You can condense this with:
trees.update(parsed_config.pop('TREES'))

etc.

Commit:

ec727d25650e498ad97ff136edfe58799288cd6b

181965d0a2a3f0ea26e7b5f8bacfd346c8dc4394

Diff:

Tool: PEP8 Style Checker
Processed Files:
    rbtools/utils/filesystem.py



Tool: Pyflakes
Processed Files:
    rbtools/utils/filesystem.py

Ship it!