Allow ALIASES and TREES to be merged in configs

Review Request #6649 — Created Nov. 26, 2014 and submitted

brennie
RBTools
master
181965d...
rbtools, students

Give special treatment to the ALIASES and TREES keys in
.reviewboardrc so that they are merged together and not overwritten.

Ran unit tests.

Created a ../.reviewboardrc and ./.reviewboardrc with different
aliases and was able to execute all of them.

Description From Last Updated

Let's add a blank line here.

chipx86chipx86

No blank line needed here.

chipx86chipx86

You can condense this with: trees.update(parsed_config.pop('TREES')) etc.

chipx86chipx86
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        rbtools/utils/filesystem.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        rbtools/utils/filesystem.py
    
    
  2. 
      
chipx86
  1. 
      
  2. rbtools/utils/filesystem.py (Diff revision 1)
     
     
     

    Let's add a blank line here.

  3. rbtools/utils/filesystem.py (Diff revision 1)
     
     
     
     

    No blank line needed here.

  4. rbtools/utils/filesystem.py (Diff revision 1)
     
     
     
     
     
     

    You can condense this with:

    trees.update(parsed_config.pop('TREES'))
    

    etc.

  5. 
      
brennie
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        rbtools/utils/filesystem.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        rbtools/utils/filesystem.py
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (8af8fb2)
Loading...