Add new Review Request Dropdown hook to allow dynamic urls in actions.

Review Request #6633 — Created Nov. 23, 2014 and discarded

Information

Review Board
master

Reviewers

Added new hook to allow dynamic urls in dropdown menu items

!TODO!:
Links don't actually do anything

Links shown (at the bottom-left of the screen) when hovering over produce the correct results.

Description From Last Updated

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

Col: 1 E122 continuation line missing indentation or outdented

reviewbotreviewbot

Col: 73 W291 trailing whitespace

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

Col: 1 E122 continuation line missing indentation or outdented

reviewbotreviewbot

Col: 73 W291 trailing whitespace

reviewbotreviewbot
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/extensions/hooks.py
        reviewboard/reviews/models/review_request.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/extensions/hooks.py
        reviewboard/reviews/models/review_request.py
    
    
  2. reviewboard/extensions/hooks.py (Diff revision 1)
     
     
    Col: 1
     E302 expected 2 blank lines, found 1
    
  3. reviewboard/extensions/hooks.py (Diff revision 1)
     
     
    Col: 1
     E122 continuation line missing indentation or outdented
    
  4. reviewboard/extensions/hooks.py (Diff revision 1)
     
     
    Col: 73
     W291 trailing whitespace
    
  5. 
      
ML
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/extensions/hooks.py
        reviewboard/reviews/models/review_request.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/extensions/hooks.py
        reviewboard/reviews/models/review_request.py
    
    
  2. reviewboard/extensions/hooks.py (Diff revision 2)
     
     
    Col: 1
     E302 expected 2 blank lines, found 1
    
  3. reviewboard/extensions/hooks.py (Diff revision 2)
     
     
    Col: 1
     E122 continuation line missing indentation or outdented
    
  4. reviewboard/extensions/hooks.py (Diff revision 2)
     
     
    Col: 73
     W291 trailing whitespace
    
  5. 
      
ML
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/extensions/hooks.py
        reviewboard/reviews/models/review_request.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/extensions/hooks.py
        reviewboard/reviews/models/review_request.py
    
    
  2. 
      
ML
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/extensions/hooks.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/extensions/hooks.py
    
    
  2. 
      
ML
ML
Review request changed

Status: Discarded

Change Summary:

This had been added to the review_export extension where this hook is introduced. See https://reviews.reviewboard.org/r/6393/ for its addition.

Loading...