Summary

Allow users to download a PDF and XML representation of a review request

Review Request #6393 — Created Oct. 2, 2014 and submitted Jan. 8, 2015, 2:30 p.m.

Information

Owner

mloyzer

Repository

rb-extension-pack

Branch

master

Bugs

1395

Depends On

~~6633~~

Commit

36a11dc...

Reviewers

Groups

rb-extension-pack, students

People

Description

Allow users to download a review request as a PDF and XML(WIP) document.

For the sample mock documents, refer to the review request https://reviews.reviewboard.org/r/6413/

TODO:
Finish XML.

NOTE:
this depends on:
1. https://reviews.reviewboard.org/r/6633/
2. https://reviews.reviewboard.org/r/6620/

Testing Done

Issue Summary Section
1. No Issues
2. Open Issues
3. Open & Resolved Issues
4. Open & Dropped Issues
5. Dropped Issues

File Summary Section
1. No Files
2. Files only uploaded
3. Files uploaded and downloaded

Review Summary Section
1. Added/Removed content to description and testing done (Displayed as +/-)
3. Review with only body_top
4. Review with Comment and no replies
5. Review with Comment and replies
6. Issue Opened (Review displays "Issue Opened by 'name' ('status')")
7. Issue Resolved
8. Issue Dropped
9. Added Files (Specified in the ChangeDescription as a bulleted list)
10. Removed Files (Specified in the ChangeDescription as a bulleted list)
11. Comment of File Attachment
12. Added/Removed Bugs Closd (Displayed as +/-)
13. Added/Removed Branch (Displayed as +/-)
14. Added/Removed Target People (Displayed as bulleted list)
15. Modifed Summary (Displayed as +/-)

Issues

Description	From	Last Updated
The ampersand should be escaed. So should <, >, ', and "	brennie	Nov. 26, 2014, 5:59 p.m.
XML tag names shouldn't contain a space. This should be something like <review-request>. Likewise below. Also, the special XML tag …	brennie	Nov. 27, 2014, 7:05 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 5, 2014, 2:51 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Oct. 5, 2014, 2:56 p.m.
Col: 17 E128 continuation line under-indented for visual indent	reviewbot	Oct. 5, 2014, 2:56 p.m.
Col: 13 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Oct. 5, 2014, 2:57 p.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	Oct. 5, 2014, 2:58 p.m.
Col: 5 E128 continuation line under-indented for visual indent	reviewbot	Oct. 5, 2014, 2:59 p.m.
So the url would be: ".../review_export/download_pdf_file/<review_request_id>" You might want to make the url shorter as long as it is clear …	NI nicolexin	Oct. 5, 2014, 3:04 p.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	Oct. 5, 2014, 2:59 p.m.
'render_to_response' imported but unused	reviewbot	Oct. 5, 2014, 2:59 p.m.
'RequestContext' imported but unused	reviewbot	Oct. 5, 2014, 3 p.m.
'ReviewRequest' imported but unused	reviewbot	Oct. 26, 2014, 10:26 a.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Oct. 5, 2014, 3 p.m.
Col: 11 E262 inline comment should start with '# '	reviewbot	Oct. 5, 2014, 3 p.m.
Col: 13 E126 continuation line over-indented for hanging indent	reviewbot	Oct. 5, 2014, 3:01 p.m.
Col: 5 E265 block comment should start with '# '	reviewbot	Oct. 5, 2014, 3:01 p.m.
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	Oct. 5, 2014, 3:02 p.m.
Col: 20 E703 statement ends with a semicolon	reviewbot	Oct. 5, 2014, 3:02 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Oct. 5, 2014, 3:02 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Oct. 5, 2014, 3:02 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Oct. 5, 2014, 3:03 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 5, 2014, 3:04 p.m.
Col: 45 E127 continuation line over-indented for visual indent	reviewbot	Oct. 5, 2014, 3:13 p.m.
Col: 13 E128 continuation line under-indented for visual indent	reviewbot	Oct. 5, 2014, 3:24 p.m.
Col: 5 E128 continuation line under-indented for visual indent	reviewbot	Oct. 5, 2014, 3:24 p.m.
Col: 9 E128 continuation line under-indented for visual indent	reviewbot	Oct. 5, 2014, 3:36 p.m.
Col: 6 E131 continuation line unaligned for hanging indent	reviewbot	Oct. 5, 2014, 3:37 p.m.
Col: 18 E131 continuation line unaligned for hanging indent	reviewbot	Oct. 26, 2014, 10:24 a.m.
There is a PEP that describes how docstrings should be written. I think RB follows that convention. The format is: …	AS asalahli	Oct. 26, 2014, 10:22 a.m.
Col: 32 E226 missing whitespace around arithmetic operator	reviewbot	Oct. 26, 2014, 10:23 a.m.
Col: 27 E226 missing whitespace around arithmetic operator	reviewbot	Oct. 26, 2014, 10:23 a.m.
Col: 26 E226 missing whitespace around arithmetic operator	reviewbot	Oct. 26, 2014, 10:23 a.m.
Col: 40 E226 missing whitespace around arithmetic operator	reviewbot	Oct. 26, 2014, 10:23 a.m.
Col: 33 E226 missing whitespace around arithmetic operator	reviewbot	Oct. 26, 2014, 10:23 a.m.
'ReviewRequest' imported but unused	reviewbot	Oct. 26, 2014, 10:24 a.m.
You can break this into multiple lines without using backslash. Python implicitly concatenates multiple strings into one. description="Add file export …	AS asalahli	Oct. 26, 2014, 10:20 a.m.
Hmm, this is not exactly what it does. How about: """Allows users to export a review request to XML/PDF.	chipx86	Oct. 27, 2014, 4:48 p.m.
Are these URLs functional? I guess we never got around to adding support for url_name for action hooks. We really …	chipx86	Dec. 17, 2014, 10:40 a.m.
This can be one statement.	chipx86	Oct. 27, 2014, 4:16 p.m.
This is a Python Standard Library module, so it should go first. Also, this file is missing this from the …	chipx86	Oct. 27, 2014, 4:17 p.m.
Same here.	chipx86	Oct. 27, 2014, 4:17 p.m.
Should inherit from object.	chipx86	Oct. 27, 2014, 4:22 p.m.
Col: 18 E241 multiple spaces after ':'	reviewbot	Oct. 27, 2014, 4:11 p.m.
Col: 16 E241 multiple spaces after ':'	reviewbot	Oct. 27, 2014, 4:12 p.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Oct. 27, 2014, 4:13 p.m.
You may want self.__dict__.copy(). I'm not sure what this is for though?	chipx86	Dec. 17, 2014, 10:40 a.m.
While fine for debugging, printing to stdout will break sites in production.	chipx86	Nov. 24, 2014, 9:08 a.m.
Should have URL names that are prefixed by the name of the extension.	chipx86	Dec. 17, 2014, 10:40 a.m.
Imports are always in the following groups, from the point of view of the project you're editing: 1) Python standard …	chipx86	Oct. 27, 2014, 4:22 p.m.
Should be consistent on double quotes vs. single quotes. Preferably use single quotes.	chipx86	Oct. 27, 2014, 4:21 p.m.
"Review Requests" is kind of odd to capitalize. How about changing this summary to: "Add PDF and XML export functionality …	chipx86	Oct. 27, 2014, 4:21 p.m.
Col: 18 E241 multiple spaces after ':'	reviewbot	Oct. 27, 2014, 5:10 p.m.
Col: 16 E241 multiple spaces after ':'	reviewbot	Oct. 27, 2014, 5:10 p.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Oct. 27, 2014, 5:10 p.m.
Col: 14 E126 continuation line over-indented for hanging indent	reviewbot	Oct. 28, 2014, 7:43 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 11, 2014, 8:23 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 11, 2014, 8:23 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 11, 2014, 8:24 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 11, 2014, 8:24 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 11, 2014, 8:24 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 11, 2014, 8:24 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 11, 2014, 8:24 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 11, 2014, 8:24 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 11, 2014, 8:24 a.m.
Col: 13 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 24, 2014, 8:55 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 24, 2014, 9:05 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 24, 2014, 9:05 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 24, 2014, 9:05 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 24, 2014, 9:06 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 24, 2014, 9:06 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 24, 2014, 9:06 a.m.
Col: 13 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 24, 2014, 9:06 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 24, 2014, 9:06 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 24, 2014, 9:06 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 24, 2014, 9:06 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 24, 2014, 9:06 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 24, 2014, 9:06 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 24, 2014, 9:06 a.m.
Col: 13 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 24, 2014, 9:08 a.m.
The first line of a docstring must be a complete sentence and it must be followed a blank line (or …	brennie	Nov. 24, 2014, 9:11 a.m.
Add a period	brennie	Nov. 24, 2014, 9:09 a.m.
Add a period.	brennie	Nov. 24, 2014, 9:12 a.m.
The first line of a docstring must be a complete sentence and it must be followed by a blank line …	brennie	Nov. 24, 2014, 9:15 a.m.
Add a period.	brennie	Nov. 24, 2014, 9:15 a.m.
Remove this line	brennie	Nov. 24, 2014, 9:15 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 24, 2014, 9:08 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 24, 2014, 9:08 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 24, 2014, 9:09 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 24, 2014, 9:09 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 24, 2014, 9:09 a.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 24, 2014, 9:09 a.m.
Why not 'rr%d.pdf' % review_request_id ? Likewise for the XML case below.	brennie	Nov. 24, 2014, 9:16 a.m.
This should be rr%s.xml	brennie	Nov. 24, 2014, 9:17 a.m.
This should be application/xml or text/xml.	brennie	Nov. 24, 2014, 9:17 a.m.
There should not be a blank line here.	justy777	Nov. 26, 2014, 5:08 p.m.
and here.	justy777	Nov. 26, 2014, 5:08 p.m.
and here.	justy777	Nov. 26, 2014, 5:08 p.m.
and here.	justy777	Nov. 26, 2014, 5:08 p.m.
and here.	justy777	Nov. 26, 2014, 5:08 p.m.
Did you mean to indent this? or should it be on the same level as the other functions?	justy777	Nov. 26, 2014, 6:01 p.m.
Like I mentioned in the XML review, the tag should not contain a space. Likewise below.	brennie	Nov. 26, 2014, 5:09 p.m.
Why not "'": '&apos' so that you don't have to escape the single quote inside single quotes?	brennie	Nov. 27, 2014, 7:04 a.m.

Tool: Pyflakes
Processed Files:
    review_export/review_export/extension.py
    review_export/setup.py
    review_export/review_export/urls.py
    review_export/review_export/views.py

Ignored Files:
    review_export/review_export/test.pdf
    review_export/review_export/__init__.py
    review_export/review_export/test.txt



Tool: PEP8 Style Checker
Processed Files:
    review_export/review_export/extension.py
    review_export/setup.py
    review_export/review_export/urls.py
    review_export/review_export/views.py

Ignored Files:
    review_export/review_export/test.pdf
    review_export/review_export/__init__.py
    review_export/review_export/test.txt

review_export/review_export/extension.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
review_export/review_export/extension.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```
review_export/review_export/extension.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 17
 E128 continuation line under-indented for visual indent
```
review_export/review_export/extension.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 13
 E123 closing bracket does not match indentation of opening bracket's line
```
review_export/review_export/urls.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
review_export/review_export/urls.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 5
 E128 continuation line under-indented for visual indent
```
review_export/review_export/urls.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
review_export/review_export/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'render_to_response' imported but unused
```
review_export/review_export/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'RequestContext' imported but unused
```
review_export/review_export/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'ReviewRequest' imported but unused
```
review_export/review_export/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 10
 E261 at least two spaces before inline comment
```
review_export/review_export/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 11
 E262 inline comment should start with '# '
```
review_export/review_export/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 13
 E126 continuation line over-indented for hanging indent
```
review_export/review_export/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 5
 E265 block comment should start with '# '
```
review_export/review_export/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```
review_export/review_export/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 20
 E703 statement ends with a semicolon
```
review_export/review_export/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
review_export/review_export/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
review_export/review_export/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 E265 block comment should start with '# '
```
review_export/setup.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```

review_export/review_export/urls.py (Diff revision 1)

The issue has been resolved. Show all issues

So the url would be: ".../review_export/download_pdf_file/<review_request_id>"
You might want to make the url shorter as long as it is clear and umambiguous. (i.e. ".../review_export/pdf/..." since we already know it is about review export)
Just my suggestions though

Change Summary:

Fixed issues raised by Review Bot

Commit:

-	c06a20bf58ac28256c6246afbcca8c1e3594bac0
+	895a86f4f57894caad5b7f1e60908f161f502273

Diff:

Revision 2 (+118)

Show changes

	review_export/setup.py
	review_export/review_export/__init__.py
	review_export/review_export/extension.py
	review_export/review_export/test.txt
	review_export/review_export/test.pdf
	review_export/review_export/urls.py
	review_export/review_export/views.py

Tool: PEP8 Style Checker
Processed Files:
    review_export/review_export/extension.py
    review_export/setup.py
    review_export/review_export/urls.py
    review_export/review_export/views.py

Ignored Files:
    review_export/review_export/test.pdf
    review_export/review_export/__init__.py
    review_export/review_export/test.txt

review_export/review_export/extension.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 45
 E127 continuation line over-indented for visual indent
```
review_export/review_export/extension.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 13
 E128 continuation line under-indented for visual indent
```
review_export/review_export/urls.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 5
 E128 continuation line under-indented for visual indent
```
review_export/review_export/views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 9
 E128 continuation line under-indented for visual indent
```
review_export/setup.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 6
 E131 continuation line unaligned for hanging indent
```

Commit:

-	895a86f4f57894caad5b7f1e60908f161f502273
+	de2fe1a08ef4398ff25fab7b77402fbdea8c9cd8

Diff:

Revision 3 (+121)

Show changes

	review_export/setup.py
	review_export/review_export/__init__.py
	review_export/review_export/extension.py
	review_export/review_export/test.txt
	review_export/review_export/test.pdf
	review_export/review_export/urls.py
	review_export/review_export/views.py

Tool: PEP8 Style Checker
Processed Files:
    review_export/review_export/extension.py
    review_export/setup.py
    review_export/review_export/urls.py
    review_export/review_export/views.py

Ignored Files:
    review_export/review_export/test.pdf
    review_export/review_export/__init__.py
    review_export/review_export/test.txt

review_export/setup.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 18
 E131 continuation line unaligned for hanging indent
```

Change Summary:

added master branch

Branch:

+	master

Change Summary:

Added preliminary development for PDF and changed CSV to XML (though pending).

Summary:

-	[WIP] - Created extension and have the request/response interaction implemented
+	[WIP] - Allow users to download a PDF and ___ representation of a review request

Description:

~		[WIP] - Created extension and have the request/response interaction implemented
	~	[WIP] - Allow users to download a review request as a PDF and ???(XML, JSON?) document.
	+
	+	For the sample mock documents, refer to the review request https://reviews.reviewboard.org/r/6413/
	+
	+	TODO:
	+	Look into adding Frames in the PDF document (may resolve spacing issues)
	+	Finish review and comment objects
	+	Begin second type
	+
	+	NOTE:
	+	added a class method in the review_request model:
	+	def status_to_string(class_, status) # Returns a string representation of the status flag

Commit:

-	de2fe1a08ef4398ff25fab7b77402fbdea8c9cd8
+	60fdc290ca92c95861277662c9ced93e6a6987e0

Diff:

Revision 4 (+304)

Show changes

	review_export/setup.py
	review_export/review_export/__init__.py
	review_export/review_export/extension.py
	review_export/review_export/printer.py
	review_export/review_export/rblogo.png
	review_export/review_export/rblogo.jpg
	review_export/review_export/urls.py
	review_export/review_export/views.py

Tool: PEP8 Style Checker
Processed Files:
    review_export/review_export/extension.py
    review_export/review_export/views.py
    review_export/setup.py
    review_export/review_export/printer.py
    review_export/review_export/urls.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg



Tool: Pyflakes
Processed Files:
    review_export/review_export/extension.py
    review_export/review_export/views.py
    review_export/setup.py
    review_export/review_export/printer.py
    review_export/review_export/urls.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg

review_export/review_export/printer.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 32
 E226 missing whitespace around arithmetic operator
```
review_export/review_export/printer.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 27
 E226 missing whitespace around arithmetic operator
```
review_export/review_export/printer.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 26
 E226 missing whitespace around arithmetic operator
```
review_export/review_export/printer.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 40
 E226 missing whitespace around arithmetic operator
```
review_export/review_export/printer.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 33
 E226 missing whitespace around arithmetic operator
```
review_export/review_export/views.py (Diff revision 4)
The issue has been resolved. Show all issues
```
 'ReviewRequest' imported but unused
```

review_export/review_export/extension.py (Diff revision 4)

The issue has been resolved. Show all issues

There is a PEP that describes how docstrings should be written. I think RB follows that convention.

The format is:

"""One line summary

Long explanation, that can possible
span multiple lines.
"""

or:

"""One line summary"""

Here is a link to PEP 257: http://legacy.python.org/dev/peps/pep-0257/

review_export/setup.py (Diff revision 4)

The issue has been resolved. Show all issues

You can break this into multiple lines without using backslash. Python implicitly concatenates multiple strings into one.

description="Add file export functionality to Review Board Review "
            "Requests",

Change Summary:

Fixed the "Page X of Y" to display in the header of every page. Added additional information in the Details section and added the use of bullets.

Summary:

-	[WIP] - Allow users to download a PDF and ___ representation of a review request
+	[WIP] - Allow users to download a PDF and XML representation of a review request

Description:

~		[WIP] - Allow users to download a review request as a PDF and ???(XML, JSON?) document.
	~	[WIP] - Allow users to download a review request as a PDF and XML document.

		For the sample mock documents, refer to the review request https://reviews.reviewboard.org/r/6413/

		TODO:
		Look into adding Frames in the PDF document (may resolve spacing issues)
		Finish review and comment objects
		Begin second type

		NOTE:
		added a class method in the review_request model:
		def status_to_string(class_, status) # Returns a string representation of the status flag

Commit:

-	60fdc290ca92c95861277662c9ced93e6a6987e0
+	354b37c465fbdccd9d4f7c0c735f2cc530f23f87

Diff:

Revision 5 (+338)

Show changes

	review_export/setup.py
	review_export/review_export/__init__.py
	review_export/review_export/extension.py
	review_export/review_export/printer.py
	review_export/review_export/rblogo.png
	review_export/review_export/rblogo.jpg
	review_export/review_export/urls.py
	review_export/review_export/views.py

Tool: PEP8 Style Checker
Processed Files:
    review_export/review_export/extension.py
    review_export/review_export/views.py
    review_export/setup.py
    review_export/review_export/printer.py
    review_export/review_export/urls.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg



Tool: Pyflakes
Processed Files:
    review_export/review_export/extension.py
    review_export/review_export/views.py
    review_export/setup.py
    review_export/review_export/printer.py
    review_export/review_export/urls.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg

review_export/review_export/printer.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Col: 18
 E241 multiple spaces after ':'
```
review_export/review_export/printer.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Col: 16
 E241 multiple spaces after ':'
```
review_export/review_export/printer.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```

review_export/review_export/extension.py (Diff revision 5)

The issue has been resolved. Show all issues

Hmm, this is not exactly what it does. How about:

"""Allows users to export a review request to XML/PDF.

review_export/review_export/extension.py (Diff revision 5)

The issue has been resolved. Show all issues

Are these URLs functional?

I guess we never got around to adding support for url_name for action hooks. We really should. Wouldn't be too hard.

Basically, URLs should almost never be hard-coded (unless pointing to an external site). Instead, we use URL names (which allow for referencing a URL without knowing or caring about the actual path). However, that support never got added here.

This wouldn't be hard to add to Review Board. Feel up to working on that as well? We can help out with what's needed.

mloyzer Oct. 27, 2014, 4:51 p.m.

They are functional in the sense that the server registers them but they don't do the proper thing yet because I haven't looked into how to assign a review_request_id to the anchor tags when the review is opened.

Ya, I remember smacleod and m_conley wondering about that too when I was asking them about the urls.. so sure I can do that. I want to at least get the PDF generation finished before though.

review_export/review_export/extension.py (Diff revision 5)
The issue has been resolved. Show all issues
```
This can be one statement.
```

review_export/review_export/printer.py (Diff revision 5)

The issue has been resolved. Show all issues

This is a Python Standard Library module, so it should go first.
Also, this file is missing this from the top of this file and others:
from __future__ import unicode_literals

review_export/review_export/printer.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Same here.
```
review_export/review_export/printer.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Should inherit from object.
```

review_export/review_export/printer.py (Diff revision 5)

The issue has been resolved. Show all issues

You may want self.__dict__.copy(). I'm not sure what this is for though?

mloyzer Oct. 27, 2014, 4:51 p.m.

i believe they are the same because I am creating a new dict and passing it a dict to copy by value.  But I can switch it if you want.  it saves the state of the current page and starts anew. i don't explicitly call the showPage function but I believe it is actually called during the document build process

review_export/review_export/printer.py (Diff revision 5)
The issue has been resolved. Show all issues
```
While fine for debugging, printing to stdout will break sites in production.
```

review_export/review_export/urls.py (Diff revision 5)

The issue has been resolved. Show all issues

Should have URL names that are prefixed by the name of the extension.

mloyzer Oct. 27, 2014, 4:51 p.m.

unless if i am mistaken but I added the 'review_export' prefix in the setup.py file so it shouldn't need it here....but it might make more sense to have it pre-pended in this file because this does show the urls....but i'm not sure once the url naming is implemented.

review_export/review_export/views.py (Diff revision 5)

The issue has been resolved. Show all issues

Imports are always in the following groups, from the point of view of the project you're editing:

1) Python standard library imports

2) Third-party imports ("reviewboard" counts from the point of view of this module).

3) Project imports

There's a blank line separating each.

review_export/setup.py (Diff revision 5)

The issue has been resolved. Show all issues

Should be consistent on double quotes vs. single quotes. Preferably use single quotes.

review_export/setup.py (Diff revision 5)

The issue has been resolved. Show all issues

"Review Requests" is kind of odd to capitalize. How about changing this summary to:

"Add PDF and XML export functionality to Review Board."

Change Summary:

Made (most of the) changes in response to ChipX86's review

Diff:

Revision 6 (+338)

Show changes

	review_export/setup.py
	review_export/review_export/__init__.py
	review_export/review_export/extension.py
	review_export/review_export/printer.py
	review_export/review_export/rblogo.png
	review_export/review_export/rblogo.jpg
	review_export/review_export/urls.py
	review_export/review_export/views.py

Tool: PEP8 Style Checker
Processed Files:
    review_export/review_export/extension.py
    review_export/review_export/views.py
    review_export/setup.py
    review_export/review_export/printer.py
    review_export/review_export/urls.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg



Tool: Pyflakes
Processed Files:
    review_export/review_export/extension.py
    review_export/review_export/views.py
    review_export/setup.py
    review_export/review_export/printer.py
    review_export/review_export/urls.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg

review_export/review_export/printer.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 18
 E241 multiple spaces after ':'
```
review_export/review_export/printer.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 16
 E241 multiple spaces after ':'
```
review_export/review_export/printer.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```

Change Summary:

Add (most of the) changes to reflect ChipX86's review.

Commit:

-	354b37c465fbdccd9d4f7c0c735f2cc530f23f87
+	acbd16a8eefe0edca85c824a5a05f0a4a7780630

Diff:

Revision 7 (+337)

Show changes

	review_export/setup.py
	review_export/review_export/__init__.py
	review_export/review_export/extension.py
	review_export/review_export/printer.py
	review_export/review_export/rblogo.png
	review_export/review_export/rblogo.jpg
	review_export/review_export/urls.py
	review_export/review_export/views.py

Tool: PEP8 Style Checker
Processed Files:
    review_export/review_export/extension.py
    review_export/review_export/views.py
    review_export/setup.py
    review_export/review_export/printer.py
    review_export/review_export/urls.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg



Tool: Pyflakes
Processed Files:
    review_export/review_export/extension.py
    review_export/review_export/views.py
    review_export/setup.py
    review_export/review_export/printer.py
    review_export/review_export/urls.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg

review_export/review_export/printer.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Col: 14
 E126 continuation line over-indented for hanging indent
```

Change Summary:

Added beginnings of File, Change Set, and Review Summaries. Need to work out how to display the files.

Description:

		[WIP] - Allow users to download a review request as a PDF and XML document.

		For the sample mock documents, refer to the review request https://reviews.reviewboard.org/r/6413/

		TODO:
~		Look into adding Frames in the PDF document (may resolve spacing issues)
~		Finish review and comment objects
~		Begin second type
	~	Figure out how to display file attachments within PDF.
	~	Finish displaying all comments and bodies (and replies) for reviews.
	~	Begin XML

		NOTE:
		added a class method in the review_request model:
		def status_to_string(class_, status) # Returns a string representation of the status flag

Commit:

-	acbd16a8eefe0edca85c824a5a05f0a4a7780630
+	d9f0b00400355f6987b2ed8bb679902a4deac40e

Diff:

Revision 8 (+493)

Show changes

	review_export/setup.py
	review_export/review_export/__init__.py
	review_export/review_export/extension.py
	review_export/review_export/printer.py
	review_export/review_export/rblogo.png
	review_export/review_export/rblogo.jpg
	review_export/review_export/urls.py
	review_export/review_export/views.py

Tool: Pyflakes
Processed Files:
    review_export/review_export/extension.py
    review_export/review_export/views.py
    review_export/setup.py
    review_export/review_export/printer.py
    review_export/review_export/urls.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg



Tool: PEP8 Style Checker
Processed Files:
    review_export/review_export/extension.py
    review_export/review_export/views.py
    review_export/setup.py
    review_export/review_export/printer.py
    review_export/review_export/urls.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg

review_export/review_export/printer.py (Diff revision 8)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```
review_export/review_export/printer.py (Diff revision 8)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```

Change Summary:

Uploaded a Sample review request. Still need to fix/add the Review Summary section.

Added Files:

Change Summary:

Updated the Review section and added a new sample PDF document of what the current output looks like.

Description:

		[WIP] - Allow users to download a review request as a PDF and XML document.

		For the sample mock documents, refer to the review request https://reviews.reviewboard.org/r/6413/

		TODO:
~		Figure out how to display file attachments within PDF.
	~	Finish displaying ChangeDescription objects.
-		Finish displaying all comments and bodies (and replies) for reviews.
		Begin XML

		NOTE:
		added a class method in the review_request model:
		def status_to_string(class_, status) # Returns a string representation of the status flag

Commit:

-	d9f0b00400355f6987b2ed8bb679902a4deac40e
+	fa8ac8fefa8574edbcf73a1bae458822234c1724

Diff:

Revision 9 (+692)

Show changes

	review_export/setup.py
	review_export/review_export/__init__.py
	review_export/review_export/extension.py
	review_export/review_export/printer.py
	review_export/review_export/rblogo.png
	review_export/review_export/rblogo.jpg
	review_export/review_export/urls.py
	review_export/review_export/views.py

Removed Files:

Added Files:

Tool: Pyflakes
Processed Files:
    review_export/review_export/extension.py
    review_export/review_export/views.py
    review_export/setup.py
    review_export/review_export/printer.py
    review_export/review_export/urls.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg



Tool: PEP8 Style Checker
Processed Files:
    review_export/review_export/extension.py
    review_export/review_export/views.py
    review_export/setup.py
    review_export/review_export/printer.py
    review_export/review_export/urls.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg

review_export/review_export/printer.py (Diff revision 9)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```
review_export/review_export/printer.py (Diff revision 9)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```
review_export/review_export/printer.py (Diff revision 9)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```
review_export/review_export/printer.py (Diff revision 9)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```
review_export/review_export/printer.py (Diff revision 9)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```
review_export/review_export/printer.py (Diff revision 9)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```
review_export/review_export/printer.py (Diff revision 9)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```

Change Summary:

Segregated Data retrieval from Data printing.

Description:

		[WIP] - Allow users to download a review request as a PDF and XML document.

		For the sample mock documents, refer to the review request https://reviews.reviewboard.org/r/6413/

		TODO:
~		Finish displaying ChangeDescription objects.
~		Begin XML
	~	Add ReviewData (data retrieval for Review) and update the printer method.
	~	Start XML.

		NOTE:
		added a class method in the review_request model:
		def status_to_string(class_, status) # Returns a string representation of the status flag

Commit:

-	fa8ac8fefa8574edbcf73a1bae458822234c1724
+	5d5cffcf6158a1c70b791bf114c627b0d8cc0aca

Diff:

Revision 10 (+955)

Show changes

	review_export/setup.py
	review_export/review_export/__init__.py
	review_export/review_export/data_extractor.py
	review_export/review_export/extension.py
	review_export/review_export/printer.py
	review_export/review_export/rblogo.png
	review_export/review_export/rblogo.jpg
	review_export/review_export/urls.py
	1 more

Tool: Pyflakes
Processed Files:
    review_export/review_export/data_extractor.py
    review_export/review_export/views.py
    review_export/review_export/urls.py
    review_export/review_export/extension.py
    review_export/setup.py
    review_export/review_export/printer.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg



Tool: PEP8 Style Checker
Processed Files:
    review_export/review_export/data_extractor.py
    review_export/review_export/views.py
    review_export/review_export/urls.py
    review_export/review_export/extension.py
    review_export/setup.py
    review_export/review_export/printer.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg

review_export/review_export/data_extractor.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Col: 13
 E123 closing bracket does not match indentation of opening bracket's line
```
review_export/review_export/printer.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```
review_export/review_export/printer.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```
review_export/review_export/printer.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```
review_export/review_export/printer.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```
review_export/review_export/printer.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```
review_export/review_export/printer.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```

Change Summary:

Added ReviewData object for data extraction. Updated View to handle requests for XML files

Commit:

-	5d5cffcf6158a1c70b791bf114c627b0d8cc0aca
+	abd1a710b85674f1be71c0e4548fc47317cd163b

Diff:

Revision 11 (+1099)

Show changes

	review_export/setup.py
	review_export/review_export/__init__.py
	review_export/review_export/data_extractor.py
	review_export/review_export/extension.py
	review_export/review_export/printer.py
	review_export/review_export/rblogo.png
	review_export/review_export/rblogo.jpg
	review_export/review_export/urls.py
	1 more

Tool: PEP8 Style Checker
Processed Files:
    review_export/review_export/data_extractor.py
    review_export/review_export/views.py
    review_export/review_export/urls.py
    review_export/review_export/extension.py
    review_export/setup.py
    review_export/review_export/printer.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg



Tool: Pyflakes
Processed Files:
    review_export/review_export/data_extractor.py
    review_export/review_export/views.py
    review_export/review_export/urls.py
    review_export/review_export/extension.py
    review_export/setup.py
    review_export/review_export/printer.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg

review_export/review_export/data_extractor.py (Diff revision 11)
The issue has been resolved. Show all issues
```
Col: 13
 E123 closing bracket does not match indentation of opening bracket's line
```
review_export/review_export/printer.py (Diff revision 11)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```
review_export/review_export/printer.py (Diff revision 11)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```
review_export/review_export/printer.py (Diff revision 11)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```
review_export/review_export/printer.py (Diff revision 11)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```
review_export/review_export/printer.py (Diff revision 11)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```
review_export/review_export/printer.py (Diff revision 11)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```

Change Summary:

Updated Testing, Finished PDF implementation and added dependencies to core reviewboard

Summary:

-	[WIP] - Allow users to download a PDF and XML representation of a review request
+	Allow users to download a PDF and XML representation of a review request

Description:

~		[WIP] - Allow users to download a review request as a PDF and XML document.
	~	Allow users to download a review request as a PDF and XML(WIP) document.

		For the sample mock documents, refer to the review request https://reviews.reviewboard.org/r/6413/

		TODO:
~		Add ReviewData (data retrieval for Review) and update the printer method.
	~	Finish XML.
-		Start XML.

		NOTE:
~		added a class method in the review_request model:
~		def status_to_string(class_, status) # Returns a string representation of the status flag
	~	this depends on:
	~	1. https://reviews.reviewboard.org/r/6633/
	+	2. https://reviews.reviewboard.org/r/6620/

Testing Done:

~		[WIP]
	~	Issue Summary Section
	+	1. No Issues???????
	+	2. Open Issues
	+	3. Open & Resolved Issues
	+	4. Open & Dropped Issues
	+	5. Dropped Issues
	+
	+
	+
	+	File Summary Section
	+	1. No Files
	+	2. Files only uploaded
	+	3. Files uploaded and downloaded
	+
	+	Review Summary Section
	+	1. Added/Removed content to description and testing done (Displayed as +/-)
	+	3. Review with only body_top
	+	4. Review with Comment and no replies
	+	5. Review with Comment and replies
	+	6. Issue Opened (Review displays "Issue Opened by 'name' ('status')")
	+	7. Issue Resolved
	+	8. Issue Dropped
	+	9. Added Files (Specified in the ChangeDescription as a bulleted list)
	+	10. Removed Files (Specified in the ChangeDescription as a bulleted list)
	+	11. Comment of File Attachment
	+	12. Added/Removed Bugs Closd (Displayed as +/-)
	+	13. Added/Removed Branch (Displayed as +/-)
	+	14. Added/Removed Target People (Displayed as bulleted list)
	+	15. Modifed Summary (Displayed as +/-)

Depends On:

+	~~6633 - Add new Review Request Dropdown hook to allow dynamic urls in actions.~~

Commit:

-	abd1a710b85674f1be71c0e4548fc47317cd163b
+	b1e841f9974c8175d6f5a2276f4796b1a3ff7c41

Diff:

Revision 12 (+1099)

Show changes

	review_export/setup.py
	review_export/review_export/__init__.py
	review_export/review_export/data_extractor.py
	review_export/review_export/extension.py
	review_export/review_export/printer.py
	review_export/review_export/rblogo.png
	review_export/review_export/rblogo.jpg
	review_export/review_export/urls.py
	1 more

Tool: Pyflakes
Processed Files:
    review_export/review_export/data_extractor.py
    review_export/review_export/views.py
    review_export/review_export/urls.py
    review_export/review_export/extension.py
    review_export/setup.py
    review_export/review_export/printer.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg



Tool: PEP8 Style Checker
Processed Files:
    review_export/review_export/data_extractor.py
    review_export/review_export/views.py
    review_export/review_export/urls.py
    review_export/review_export/extension.py
    review_export/setup.py
    review_export/review_export/printer.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg

review_export/review_export/data_extractor.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Col: 13
 E123 closing bracket does not match indentation of opening bracket's line
```
review_export/review_export/printer.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```
review_export/review_export/printer.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```
review_export/review_export/printer.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```
review_export/review_export/printer.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```
review_export/review_export/printer.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```
review_export/review_export/printer.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```

review_export/review_export/data_extractor.py (Diff revision 12)

The issue has been resolved. Show all issues

The first line of a docstring must be a complete sentence and it must be followed a blank line (or the end of the docstring).

review_export/review_export/data_extractor.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Add a period
```
review_export/review_export/data_extractor.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Add a period.
```

review_export/review_export/data_extractor.py (Diff revision 12)

The issue has been resolved. Show all issues

The first line of a docstring must be a complete sentence and it must be followed by a blank line (or the end of the docstring).

review_export/review_export/extension.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Add a period.
```
review_export/review_export/printer.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Remove this line
```

review_export/review_export/views.py (Diff revision 12)

The issue has been resolved. Show all issues

Why not 'rr%d.pdf' % review_request_id ? Likewise for the XML case below.

mloyzer Nov. 25, 2014, 4:58 p.m.

Since review_request_id is parsed form the URL, it is not actually an integer. It is unicode....but the str() is not needed

review_export/review_export/views.py (Diff revision 12)
The issue has been resolved. Show all issues
```
This should be rr%s.xml
```
review_export/review_export/views.py (Diff revision 12)
The issue has been resolved. Show all issues
```
This should be application/xml or text/xml.
```

Change Summary:

Fixed content_type in XML and several issues. Added a couple of data retrieval methods in data_extractor

Testing Done:

		Issue Summary Section
~		1. No Issues???????
	~	1. No Issues
		2. Open Issues
		3. Open & Resolved Issues
		4. Open & Dropped Issues
		5. Dropped Issues



		File Summary Section
		1. No Files
		2. Files only uploaded
		3. Files uploaded and downloaded

		Review Summary Section
		1. Added/Removed content to description and testing done (Displayed as +/-)
		3. Review with only body_top
		4. Review with Comment and no replies
		5. Review with Comment and replies
		6. Issue Opened (Review displays "Issue Opened by 'name' ('status')")
		7. Issue Resolved
		8. Issue Dropped
		9. Added Files (Specified in the ChangeDescription as a bulleted list)
		10. Removed Files (Specified in the ChangeDescription as a bulleted list)
		11. Comment of File Attachment
		12. Added/Removed Bugs Closd (Displayed as +/-)
		13. Added/Removed Branch (Displayed as +/-)
		14. Added/Removed Target People (Displayed as bulleted list)
		15. Modifed Summary (Displayed as +/-)

Commit:

-	b1e841f9974c8175d6f5a2276f4796b1a3ff7c41
+	cca1c05f253d7308045185d26b06a1a266b93bb8

Diff:

Revision 13 (+1108)

Show changes

	review_export/setup.py
	review_export/review_export/__init__.py
	review_export/review_export/data_extractor.py
	review_export/review_export/extension.py
	review_export/review_export/printer.py
	review_export/review_export/rblogo.png
	review_export/review_export/rblogo.jpg
	review_export/review_export/urls.py
	1 more

Tool: PEP8 Style Checker
Processed Files:
    review_export/review_export/data_extractor.py
    review_export/review_export/views.py
    review_export/review_export/urls.py
    review_export/review_export/extension.py
    review_export/setup.py
    review_export/review_export/printer.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg



Tool: Pyflakes
Processed Files:
    review_export/review_export/data_extractor.py
    review_export/review_export/views.py
    review_export/review_export/urls.py
    review_export/review_export/extension.py
    review_export/setup.py
    review_export/review_export/printer.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg

Change Summary:

Uploaded new sample files.

Removed Files:
Added Files:

Change Summary:

Add support for exporting XML!

Commit:

-	cca1c05f253d7308045185d26b06a1a266b93bb8
+	d96d042b2f3726db04ce34b25bb67ca8376241bc

Diff:

Revision 14 (+1434)

Show changes

	review_export/setup.py
	review_export/review_export/__init__.py
	review_export/review_export/data_extractor.py
	review_export/review_export/extension.py
	review_export/review_export/printer.py
	review_export/review_export/rblogo.png
	review_export/review_export/rblogo.jpg
	review_export/review_export/urls.py
	1 more

Tool: Pyflakes
Processed Files:
    review_export/review_export/data_extractor.py
    review_export/review_export/views.py
    review_export/review_export/urls.py
    review_export/review_export/extension.py
    review_export/setup.py
    review_export/review_export/printer.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg



Tool: PEP8 Style Checker
Processed Files:
    review_export/review_export/data_extractor.py
    review_export/review_export/views.py
    review_export/review_export/urls.py
    review_export/review_export/extension.py
    review_export/setup.py
    review_export/review_export/printer.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg

The dropdown actions don't query the server. When hovering over the links they show the correct url (review_export/pdf/6393) but the links don't do anything when clicked.

XML (Revision 1)

19	3. Open & Resolved Issues

The issue has been resolved. Show all issues

The ampersand should be escaed. So should <, >, ', and "

XML (Revision 1)

1	<Review Request id=1>

The issue has been resolved. Show all issues

XML tag names shouldn't contain a space. This should be something like <review-request>. Likewise below.
Also, the special XML tag should be specified:
<?xml version="1.0" encoding="UTF-8"?>

(assuming it is encoded with UTF-8)

review_export/review_export/data_extractor.py (Diff revision 14)
The issue has been resolved. Show all issues
```
There should not be a blank line here.
```
review_export/review_export/data_extractor.py (Diff revision 14)
The issue has been resolved. Show all issues
```
and here.
```
review_export/review_export/data_extractor.py (Diff revision 14)
The issue has been resolved. Show all issues
```
and here.
```
review_export/review_export/data_extractor.py (Diff revision 14)
The issue has been resolved. Show all issues
```
and here.
```
review_export/review_export/data_extractor.py (Diff revision 14)
The issue has been resolved. Show all issues
```
and here.
```

review_export/review_export/printer.py (Diff revision 14)

The issue has been resolved. Show all issues

Did you mean to indent this? or should it be on the same level as the other functions?

mloyzer Nov. 26, 2014, 6:01 p.m.

yes i meant to indent that. it is because that procedure is a helper method for the purpose of the method 'print_issue_summary'

review_export/review_export/printer.py (Diff revision 14)
The issue has been resolved. Show all issues
```
Like I mentioned in the XML review, the tag should not contain a space. Likewise below.
```

Change Summary:

Fixed issues regarding header information, encoding, and escaping characters

Commit:

-	d96d042b2f3726db04ce34b25bb67ca8376241bc
+	fe551b9d7ce4f244b08b0da8d37fd50920fde0e5

Diff:

Revision 15 (+1438)

Show changes

	review_export/setup.py
	review_export/review_export/__init__.py
	review_export/review_export/data_extractor.py
	review_export/review_export/extension.py
	review_export/review_export/printer.py
	review_export/review_export/rblogo.png
	review_export/review_export/rblogo.jpg
	review_export/review_export/urls.py
	1 more

Tool: PEP8 Style Checker
Processed Files:
    review_export/review_export/data_extractor.py
    review_export/review_export/views.py
    review_export/review_export/urls.py
    review_export/review_export/extension.py
    review_export/setup.py
    review_export/review_export/printer.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg



Tool: Pyflakes
Processed Files:
    review_export/review_export/data_extractor.py
    review_export/review_export/views.py
    review_export/review_export/urls.py
    review_export/review_export/extension.py
    review_export/setup.py
    review_export/review_export/printer.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg

review_export/review_export/printer.py (Diff revision 15)

The issue has been resolved. Show all issues

Why not "'": '&apos' so that you don't have to escape the single quote inside single quotes?

mloyzer Nov. 27, 2014, 7:04 a.m.

I had that originally but then went with ' for consistency but i think you're right....escaping always looks weird and can be confusing.

Change Summary:

Resolve issues.

Commit:

-	fe551b9d7ce4f244b08b0da8d37fd50920fde0e5
+	bbbeefc0ee6930017fb70682cd0a851bbff9e55c

Diff:

Revision 16 (+1434)

Show changes

	review_export/setup.py
	review_export/review_export/__init__.py
	review_export/review_export/data_extractor.py
	review_export/review_export/extension.py
	review_export/review_export/printer.py
	review_export/review_export/rblogo.png
	review_export/review_export/rblogo.jpg
	review_export/review_export/urls.py
	1 more

Tool: PEP8 Style Checker
Processed Files:
    review_export/review_export/data_extractor.py
    review_export/review_export/views.py
    review_export/review_export/urls.py
    review_export/review_export/extension.py
    review_export/setup.py
    review_export/review_export/printer.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg



Tool: Pyflakes
Processed Files:
    review_export/review_export/data_extractor.py
    review_export/review_export/views.py
    review_export/review_export/urls.py
    review_export/review_export/extension.py
    review_export/setup.py
    review_export/review_export/printer.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg

Change Summary:

Use Django's method to retrieve a review request's status insted of a user defined one.

Commit:

-	bbbeefc0ee6930017fb70682cd0a851bbff9e55c
+	4d894dde7539de7c22637161ba748544a5815adf

Diff:

Revision 17 (+1433)

Show changes

	review_export/setup.py
	review_export/review_export/__init__.py
	review_export/review_export/data_extractor.py
	review_export/review_export/extension.py
	review_export/review_export/printer.py
	review_export/review_export/rblogo.png
	review_export/review_export/rblogo.jpg
	review_export/review_export/urls.py
	1 more

Tool: Pyflakes
Processed Files:
    review_export/review_export/data_extractor.py
    review_export/review_export/views.py
    review_export/review_export/urls.py
    review_export/review_export/extension.py
    review_export/setup.py
    review_export/review_export/printer.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg



Tool: PEP8 Style Checker
Processed Files:
    review_export/review_export/data_extractor.py
    review_export/review_export/views.py
    review_export/review_export/urls.py
    review_export/review_export/extension.py
    review_export/setup.py
    review_export/review_export/printer.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg

Change Summary:

Added custom hook for dynamic URL's in the review request's dropdown action list.

Commit:

-	4d894dde7539de7c22637161ba748544a5815adf
+	97a7dd0f165613ea1fef3a178b858bd488de7bb9

Diff:

Revision 18 (+1464)

Show changes

	review_export/setup.py
	review_export/review_export/__init__.py
	review_export/review_export/data_extractor.py
	review_export/review_export/extension.py
	review_export/review_export/hooks.py
	review_export/review_export/printer.py
	review_export/review_export/rblogo.png
	review_export/review_export/rblogo.jpg
	2 more

Tool: PEP8 Style Checker
Processed Files:
    review_export/review_export/data_extractor.py
    review_export/review_export/views.py
    review_export/review_export/urls.py
    review_export/review_export/hooks.py
    review_export/review_export/extension.py
    review_export/setup.py
    review_export/review_export/printer.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg



Tool: Pyflakes
Processed Files:
    review_export/review_export/data_extractor.py
    review_export/review_export/views.py
    review_export/review_export/urls.py
    review_export/review_export/hooks.py
    review_export/review_export/extension.py
    review_export/setup.py
    review_export/review_export/printer.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg

Change Summary:

Updated Sample Files to be concurrent with the latest code changes.

Added Files:

Change Summary:

Fixed the ReviewRequest's status being displayed as the code instead of the appropriate full-length word. Uploaded current sample documents.

Commit:

-	97a7dd0f165613ea1fef3a178b858bd488de7bb9
+	36a11dc5f374de2d9a843b15da5889e14477bd46

Diff:

Revision 19 (+1481)

Show changes

	review_export/setup.py
	review_export/review_export/__init__.py
	review_export/review_export/data_extractor.py
	review_export/review_export/extension.py
	review_export/review_export/hooks.py
	review_export/review_export/printer.py
	review_export/review_export/rblogo.png
	review_export/review_export/rblogo.jpg
	2 more

Removed Files:

Tool: PEP8 Style Checker
Processed Files:
    review_export/review_export/data_extractor.py
    review_export/review_export/views.py
    review_export/review_export/urls.py
    review_export/review_export/hooks.py
    review_export/review_export/extension.py
    review_export/setup.py
    review_export/review_export/printer.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg



Tool: Pyflakes
Processed Files:
    review_export/review_export/data_extractor.py
    review_export/review_export/views.py
    review_export/review_export/urls.py
    review_export/review_export/hooks.py
    review_export/review_export/extension.py
    review_export/setup.py
    review_export/review_export/printer.py

Ignored Files:
    review_export/review_export/rblogo.png
    review_export/review_export/__init__.py
    review_export/review_export/rblogo.jpg

Status: Closed (submitted)

Status: Re-opened

Status: Closed (submitted)

Change Summary:

Pushed to ucosp/mloyzer/review-export (462d264)