Summary

Add new Review Request Dropdown hook to allow dynamic urls in actions.

Review Request #6633 — Created Nov. 23, 2014 and discarded Dec. 1, 2014, 1:01 p.m.

Information

Owner

mloyzer

Repository

Review Board

Branch

master

Bugs

Depends On

Blocks

6393

Reviewers

Groups

reviewboard

People

Description

Added new hook to allow dynamic urls in dropdown menu items

!TODO!:
Links don't actually do anything

Testing Done

Links shown (at the bottom-left of the screen) when hovering over produce the correct results.

Issues

Description	From	Last Updated
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Nov. 25, 2014, 5:06 p.m.
Col: 1 E122 continuation line missing indentation or outdented	reviewbot	Nov. 25, 2014, 5:06 p.m.
Col: 73 W291 trailing whitespace	reviewbot	Nov. 24, 2014, 8:51 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Nov. 25, 2014, 5:06 p.m.
Col: 1 E122 continuation line missing indentation or outdented	reviewbot	Nov. 25, 2014, 5:06 p.m.
Col: 73 W291 trailing whitespace	reviewbot	Nov. 25, 2014, 5:06 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/hooks.py
    reviewboard/reviews/models/review_request.py



Tool: Pyflakes
Processed Files:
    reviewboard/extensions/hooks.py
    reviewboard/reviews/models/review_request.py

reviewboard/extensions/hooks.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/extensions/hooks.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 E122 continuation line missing indentation or outdented
```
reviewboard/extensions/hooks.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 73
 W291 trailing whitespace
```

Change Summary:

Fixed trailing whitespace issue

Diff:

Revision 2 (+41)

Show changes

	reviewboard/extensions/hooks.py
	reviewboard/reviews/models/review_request.py

Tool: Pyflakes
Processed Files:
    reviewboard/extensions/hooks.py
    reviewboard/reviews/models/review_request.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/hooks.py
    reviewboard/reviews/models/review_request.py

reviewboard/extensions/hooks.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/extensions/hooks.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 E122 continuation line missing indentation or outdented
```
reviewboard/extensions/hooks.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 73
 W291 trailing whitespace
```

Change Summary:

Added review request id from context variable.

Summary:

[WIP]Add new Review Request Dropdown hook to allow dynamic urls in actions.

Add new Review Request Dropdown hook to allow dynamic urls in actions.

Commit:

ae9c0b2e21c0d7fc49349e70a95d35bb86c5aa78

9369aa382d5baca6bd38a9fd66cb2a9750054e26

Diff:

Revision 3 (+41)

Show changes

	reviewboard/extensions/hooks.py
	reviewboard/reviews/models/review_request.py

Tool: Pyflakes
Processed Files:
    reviewboard/extensions/hooks.py
    reviewboard/reviews/models/review_request.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/hooks.py
    reviewboard/reviews/models/review_request.py

Change Summary:

Undo review_request.py model changes. They should not be in this review request.

Description:

		Merge branch 'master' into rr_status



		Added new hook to allow dynamic urls in dropdown menu items

~		TODO:
	~	!TODO!:
-		find the correct attribute in context variable.
		Links don't actually do anything

Commit:

9369aa382d5baca6bd38a9fd66cb2a9750054e26

fa9c67267899931c5672bddee688334c3dd2d652

Diff:

Revision 4 (+30)

Show changes

reviewboard/extensions/hooks.py

Tool: Pyflakes
Processed Files:
    reviewboard/extensions/hooks.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/hooks.py

Change Summary:: Remove description of merging from another branch that has been revoked
Description:: -
Merge branch 'master' into rr_status
-
-
-

Added new hook to allow dynamic urls in dropdown menu items

!TODO!:
Links don't actually do anything

Status:: Discarded
Change Summary:: This had been added to the review_export extension where this hook is introduced. See https://reviews.reviewboard.org/r/6393/ for its addition.