Summary

Update the new review dialog for server-side Markdown.

Review Request #6438 — Created Oct. 14, 2014 and submitted Oct. 16, 2014, 3:12 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

6d2a084...

Reviewers

Groups

reviewboard

People

Description

The new server-side Markdown support was implemented on release-2.0.x,
and thus didn't take into account the new review dialog on master. This
dialog differed from the other places where Markdown was used, in that
we had no way to pre-inject the raw values for review and comment text
fields prior to loading the dialog.

Now, the dialog requests the raw text fields as part of the initial
fetches and the saves, and populates the raw values in the
inlineEditors. This allows the dialog to work as it did before, with the
addition of having server-side Markdown support.

Testing Done

Tested new reviews and modifying the body top/bottom values.

Tested loading existing reviews with comments and seeing the text rendered
correctly. Opened an editor and saw the proper raw text. Saved and saw it
render correctly. Re-opening showed the raw text again.

Verified that the queries for comments and the review draft had the appropriate
query arguments.

Review dialog unit tests pass. (Note that plenty of other JS unit tests are
failing, but those are unrelated.)

Issues

Description	From	Last Updated
Can we use 'true' instead of '1'?	david	Oct. 16, 2014, 2:44 p.m.

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/resources/models/draftResourceModelMixin.js
    reviewboard/static/rb/js/resources/models/baseResourceModel.js
    reviewboard/static/rb/js/resources/models/baseCommentModel.js
    reviewboard/static/rb/js/resources/models/reviewModel.js
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/static/rb/js/views/markdownEditorView.js



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/resources/models/draftResourceModelMixin.js
    reviewboard/static/rb/js/resources/models/baseResourceModel.js
    reviewboard/static/rb/js/resources/models/baseCommentModel.js
    reviewboard/static/rb/js/resources/models/reviewModel.js
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/static/rb/js/views/markdownEditorView.js

reviewboard/static/rb/js/resources/models/baseCommentModel.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we use 'true' instead of '1'?
```

Change Summary:

Switched to using true instead of 1 in the API request.

Commit:

a11cbd4fe62fdf15373c2bcde4e26a9be6a7dcab

6d2a084129f8b3e75b081d4122dc65cb20de3d4d

Diff:

Revision 2 (+107 -11)

Show changes

	reviewboard/static/rb/js/resources/models/baseCommentModel.js
	reviewboard/static/rb/js/resources/models/baseResourceModel.js
	reviewboard/static/rb/js/resources/models/draftResourceModelMixin.js
	reviewboard/static/rb/js/resources/models/reviewModel.js
	reviewboard/static/rb/js/views/markdownEditorView.js
	reviewboard/static/rb/js/views/reviewDialogView.js

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/resources/models/draftResourceModelMixin.js
    reviewboard/static/rb/js/resources/models/baseResourceModel.js
    reviewboard/static/rb/js/resources/models/baseCommentModel.js
    reviewboard/static/rb/js/resources/models/reviewModel.js
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/static/rb/js/views/markdownEditorView.js



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/resources/models/draftResourceModelMixin.js
    reviewboard/static/rb/js/resources/models/baseResourceModel.js
    reviewboard/static/rb/js/resources/models/baseCommentModel.js
    reviewboard/static/rb/js/resources/models/reviewModel.js
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/static/rb/js/views/markdownEditorView.js

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (b605766)