asalahli got a fish trophy!
Moved emitting user_registered signal to djblets, to prevent sending false emails.
Review Request #6336 — Created Sept. 19, 2014 and submitted
Moved emitting
user_registeredsignal to djblets, to prevent sending false emails.The old code was doing the wrong check to determine if the registration was
successful. By moving the signal to djblets view, we can ensure it is only
emitted on success.
All unit tests pass.
Submitted blank, invalid, valid registration forms while:
1. no user was logged in.
2. another user was logged in
| Description | From | Last Updated |
|---|---|---|
|
I get an ImportError at this line when trying to open a review_request. Can you confirm that opening a review_request … |
ML mloyzer |
-
This looks good to me. It looks like you had marked these as "Submitted". In general, you should leave your review requests open until we push them (at which point we'll close them). The only time you should close your own review requests is if you're discarding them.
ML
-
-
reviewboard/notifications/email.py (Diff revision 1) I get an ImportError at this line when trying to open a review_request. Can you confirm that opening a review_request and publishing a draft works for you?
http://pastie.org/9582435