djblets.auth.views.register() emits user_registered signal on success.
Review Request #6334 — Created Sept. 19, 2014 and submitted
| Information | |
|---|---|
| asalahli | |
| Djblets | |
| master | |
| 3438 | |
| 6336 | |
| 5fb821f... | |
| Reviewers | |
| djblets, students | |
djblets.auth.views.register()emitsuser_registered
signal on success. This is useful for doing additional
work outside ofdjblets.auth.views.register()when a
user registers.
All unit tests pass.
Manually tested it, and it works.
No automated testing done.
-
-
djblets/auth/views.py (Diff revision 1) This comment isn't really appropriate. Djblets is a reusable component which is used by some third-party projects, and the code that sends the e-mail exists in reviewboard. Can you rewrite this comment to explain that other components can listen to this signal to perform actions when new users are registered?
AS
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+11) |
-
Tool: Pyflakes Processed Files: djblets/auth/views.py djblets/auth/signals.py Tool: PEP8 Style Checker Processed Files: djblets/auth/views.py djblets/auth/signals.py
-
-
djblets/auth/views.py (Diff revision 2) Please alphabetize these ('signals' between 'forms' and 'util').
AS
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+11) |
-
Tool: Pyflakes Processed Files: djblets/auth/views.py djblets/auth/signals.py Tool: PEP8 Style Checker Processed Files: djblets/auth/views.py djblets/auth/signals.py
Tool: PEP8 Style Checker Processed Files: djblets/auth/views.py djblets/auth/signals.py Tool: Pyflakes Processed Files: djblets/auth/views.py djblets/auth/signals.py