djblets.auth.views.register() emits user_registered signal on success.

Review Request #6334 — Created Sept. 19, 2014 and submitted

asalahli
Djblets
master
3438
6336
5fb821f...
djblets, students

djblets.auth.views.register() emits user_registered
signal on success. This is useful for doing additional
work outside of djblets.auth.views.register() when a
user registers.

All unit tests pass.

Manually tested it, and it works.

No automated testing done.

Description From Last Updated

This comment isn't really appropriate. Djblets is a reusable component which is used by some third-party projects, and the code ...

daviddavid

Please alphabetize these ('signals' between 'forms' and 'util').

daviddavid
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        djblets/auth/views.py
        djblets/auth/signals.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        djblets/auth/views.py
        djblets/auth/signals.py
    
    
  2. 
      
AS
david
  1. 
      
  2. djblets/auth/views.py (Diff revision 1)
     
     
     

    This comment isn't really appropriate. Djblets is a reusable component which is used by some third-party projects, and the code that sends the e-mail exists in reviewboard. Can you rewrite this comment to explain that other components can listen to this signal to perform actions when new users are registered?

    1. Sorry about copy-paste. Changed it!

  3. 
      
AS
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        djblets/auth/views.py
        djblets/auth/signals.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/auth/views.py
        djblets/auth/signals.py
    
    
  2. 
      
brennie
  1. Ship It!

  2. 
      
justy777
  1. Ship It!

  2. 
      
AS
AS
david
  1. 
      
  2. djblets/auth/views.py (Diff revision 2)
     
     
     
     

    Please alphabetize these ('signals' between 'forms' and 'util').

  3. 
      
AS
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        djblets/auth/views.py
        djblets/auth/signals.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/auth/views.py
        djblets/auth/signals.py
    
    
  2. 
      
AS
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.8.x (0d6747a)
david
  1. Ship It!

  2. 
      
Loading...