• 
  
    
 
    
 
    

    



    
    
    
    
     
    




    
 
    




    


 
    
  
  Fish Trophy

  
    asalahli got a fish trophy!
    
  
  Fish Trophy

 
    


    


  
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Moved emitting user_registered signal to djblets, to prevent sending false emails.
    
 
    

    



 
    
 
    

  Review Request #6336
  —
  Created Sept. 19, 2014 and submitted 

 
    


    




    




    




 
    
  
    
   Information

  
    



    
 
 
    
  asalahli
 
    

    





    
 
 
    
  Review Board
 
    

    





    
 
 
    
  master
 
    

    





    
 
 
    
  3438
 
    

    





    
 
 
    
  6334
 
    

    





    
 
 
    
  46e9275...
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  reviewboard, students
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    Moved emitting user_registered signal to djblets, to prevent sending false emails.
    

    The old code was doing the wrong check to determine if the registration was
    
successful. By moving the signal to djblets view, we can ensure it is only
    
emitted on success.
    
 
    

    





  

    
 
 
    
  
    All unit tests pass.
    

    Submitted blank, invalid, valid registration forms while:
    
1. no user was logged in.
    
2. another user was logged in
    
 
    

    




 
    

    





    
 
    









 





    
 
 
 
    
  
    
   
    
    
    
     
    
    
    
      
     
    • 
      
     
      • 
     
    • 
      
     
      • 
     
    • 
      
     
      • 
     
    • 
      
     
      • 
     
    • 
      
     
      • 
    
    
   
    
   
    
    
     
    
      Description
      From
      Last Updated
     
    
        
    



     
    
      
       
       
    I get an ImportError at this line when trying to open a review_request. Can you confirm that opening a review_request …
    
          		
      
       
 ML
mloyzer
      
      
       
      
     
    

        
   
    
  
    
 
    

    




 
    

    



  
    
 
    

    


    


 













    
 



 
    
  
    
   
    




 AS





   
    
   
    
  
    
 
    


 

    












    
 





 
    
  
    
   
    



brennie




   
    
   
    





    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
brennie


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      Ship It!
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 















    2. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 


    

  
    
 
    

    












    
 





 
    
  
    
   
    



dkus




   
    
   
    



    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
dkus


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      What did you do for the manual testing?
      
  
      
 
      

 
      
  


      
 
      
 
        

  


      1. 
 
 
        
 
        
  
 
        
 
        
  
          

        • Submitted blank, invalid, valid registration forms while:
            

          1. no user was logged in.
            2. 

          2. another user was logged in
            3. 

          

          • 

        
 
        

        2. 



      2. 
 
 
        
 
        
  
 
        
 
        
  
        Should this be documented in the Testing Done field?
        
 
        

        3. 



      3. 
 
 
        
 
        
  
 
        
 
        
  
        Right! Added it
        
 
        

        4. 


 
      


      

 
      

      2. 















    2. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 


    

  
    
 
    

    












    
 





 
    
  
    
   
    



justy777




   
    
   
    





    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
justy777


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      Ship It!
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 















    2. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 


    

  
    
 
    

    












    
 



 
    
  
    
   
    




 AS





   
    
   
    
  
    
 
    


 

    












    
 



 
    
  
    
   
    




 AS





   
    
   
    
  
    
 
    


 

    












    
 



 
    
  
    
   
    




 AS





   
    
   
    
  
    
 
    


 

    












    
 





 
    
  
    
   
    



dkus




   
    
   
    





    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
dkus


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 















    2. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 


    

  
    
 
    

    












    
 



 
    
  
    
   
    




 AS





   
    
   
    
  
    
 
    


 

    












    
 



 
    
  
    
   
    




 AS





   
    
   
    
  
    
 
    


 

    












    
 





 
    
  
    
   
    



david




   
    
   
    





    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
david


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      This looks good to me. It looks like you had marked these as "Submitted". In general, you should leave your review requests open until we push them (at which point we'll close them). The only time you should close your own review requests is if you're discarding them.
      
  
      
 
      

 
      
  


      
 
      
 
        

  


      1. 
 
 
        
 
        
  
 
        
 
        
  
        Ooops. I thought I had to submit the review for it to be considered for merging
        
 
        

        2. 


 
      


      

 
      

      2. 















    2. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 


    

  
    
 
    

    












    
 





 
    
  
    
   
    



david




   
    
   
    





    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
david


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      Ship It!
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 















    2. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 


    

  
    
 
    

    












    
 



 
    
  
    
   
    




 AS





   
    
   
    
  
    
 
    


 
    
  
    

   
    
   
    
    
     Review request changed
    
    
   
    

  
    
  
    
  
    




    

  
    
   
    
    Status:
   
    
   
    

    Completed

   
    
  
    



  
    
   
    
    Change Summary:
   
    
   
    
    
    Pushed to release-2.0.x (decc128)
    
   
    
  
    








    





  
    
 
    

    












    
 





 
    
  
    
   
    




 ML





   
    
   
    





    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
mloyzer


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 

















    2. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/notifications/email.py
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      I get an ImportError at this line when trying to open a review_request.  Can you confirm that opening a review_request and publishing a draft works for you?
      

      http://pastie.org/9582435
      
  
      
 
      

 
      
  


      
 
      
 
        

  


      1. 
 
 
        
 
        
  
 
        
 
        
  
        Did you update Djblets?
        
 
        

        2. 



      2. 
 
 
        
 
        
  
 
        
 
        
  
        ah that was it.  once i updated djblets it works fine, thanks
        
 
        

        3. 


 
      


      

 
      

      3. 




    3. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      4.