Support more than 100 Gitlab hosted repos
Review Request #6037 — Created June 30, 2014 and submitted
Newer gitlab versions do provide pagination support via a header.
See https://github.com/gitlabhq/gitlabhq/commit/0678b8a4 Gitlab v6.8.0+Add a new method that follows the "next" rel if present in the link
header, and use this to fetch all repositories.
Tested on a gitlab 6.8.X deployment against a developer reviewboard. Was able to add a repository that's beyond the first 100 repos.
| Description | From | Last Updated |
|---|---|---|
|
Can we reword this without a string of semicolons? Maybe: Follows the "next" rel .... This requires at least GitLab … |
 chipx86
|
|
|
No blank line. |
chipx86
|
|
|
Blank line after this. |
chipx86
|
|
|
Instead of duplicating all this, I'd suggest doing what we did in github.py on master where api_get can return headers, … |
chipx86
|
|
|
Blank line on either side of this. |
chipx86
|
|
|
Can we make constants for this string and its length? |
chipx86
|
|
|
And blank line before this. |
chipx86
|
-
-
reviewboard/hostingsvcs/gitlab.py (Diff revision 1) Can we reword this without a string of semicolons? Maybe:
Follows the "next" rel .... This requires at least GitLab v6.8.0, and will provide only the first page on earlier versions. -
-
-
reviewboard/hostingsvcs/gitlab.py (Diff revision 1) Instead of duplicating all this, I'd suggest doing what we did in github.py on master where
api_getcan return headers, and thenapi_get_listjust makes use ofapi_get. -
-
reviewboard/hostingsvcs/gitlab.py (Diff revision 1) Can we make constants for this string and its length?
-
Tool: Pyflakes Processed Files: reviewboard/hostingsvcs/gitlab.py Tool: PEP8 Style Checker Processed Files: reviewboard/hostingsvcs/gitlab.py