Summary

Update for the new support page infrastructure.

Review Request #6015 — Created June 22, 2014 and submitted June 23, 2014, 1:42 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

bd4b283...

Reviewers

Groups

reviewboard

People

Description

This updates Review Board to work with the new support infrastructure
being deployed on our servers.

rb-site now asks for a Company name, which can also be provided later on
the General Settings page. This name will show up on the support page
when users visit it. We may also want to use this down the road to help
brand Review Board itself.

rb-site will also ask for permission to collect support data, and
explain what we collect and how it's used. This can be changed later
through a checkbox on the Support Settings page. If allowed, rb-site
will up and maintain the support page on install and upgrade.

Testing Done

Set the company name on an existing server and saw that it saved.

Toggled the new checkbox for support data and saw that data was only set
when it was checked.

Created a new site and entered a company name. Saw it was saved and showed up
in the support page.

Tested various input for the permission check in install, and tested that they
had the expected outcome. Also tested this with the new --opt-out-support-data
option.

Issues

Description	From	Last Updated
Col: 15 E241 multiple spaces after ':'	reviewbot	June 22, 2014, 8:10 p.m.
Col: 32 E241 multiple spaces after ':'	reviewbot	June 22, 2014, 8:10 p.m.
import 'choice' from line 17 shadowed by loop variable	reviewbot	June 22, 2014, 8:10 p.m.
I'm not sure we should include the second sentence here. Maybe not even this paragraph at all.	david	June 23, 2014, 1:42 a.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	June 22, 2014, 8:10 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	June 22, 2014, 8:10 p.m.
'PIPELINE_JS' imported but unused	reviewbot	June 22, 2014, 8:10 p.m.
Col: 15 E241 multiple spaces after ':'	reviewbot	June 23, 2014, 1:27 a.m.
Col: 32 E241 multiple spaces after ':'	reviewbot	June 23, 2014, 1:27 a.m.
import 'choice' from line 17 shadowed by loop variable	reviewbot	June 23, 2014, 1:27 a.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	June 23, 2014, 1:27 a.m.
'PIPELINE_JS' imported but unused	reviewbot	June 23, 2014, 1:27 a.m.
'PIPELINE_CSS' imported but unused	reviewbot	June 23, 2014, 1:27 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/admin/siteconfig.py
    reviewboard/admin/forms.py
    reviewboard/admin/support.py
    reviewboard/settings.py
    reviewboard/cmdline/rbsite.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/siteconfig.py
    reviewboard/admin/forms.py
    reviewboard/admin/support.py
    reviewboard/settings.py
    reviewboard/cmdline/rbsite.py

reviewboard/admin/siteconfig.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 15
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 32
 E241 multiple spaces after ':'
```
reviewboard/cmdline/rbsite.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 import 'choice' from line 17 shadowed by loop variable
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```

reviewboard/cmdline/rbsite.py (Diff revision 1)

The issue has been resolved. Show all issues

I'm not sure we should include the second sentence here. Maybe not even this paragraph at all.

chipx86 June 23, 2014, 12:35 a.m.

My intent was to give some information as to why they'd want this so they understand there's a benefit to them. Any thoughts in that area?

david June 23, 2014, 12:43 a.m.

Maybe say that we use it to determine what versions we need to support, and to correlate the volume of bugs and support requests with upgrade cycles?

chipx86 June 23, 2014, 1:16 a.m.

Okay. Trying new text that covers a bit of both. The support page bit is useful for them, since it links to the correct docs for their version and provides contact info for their admins. So I want to continue to highlight that.

Change Summary:

Trying some new text on the support data page.

Commit:

fecb54e44b2d5f5d3b06c0f0ca45c8955c627a74

bd4b2832a8349394c9071592c8c9ab93cf51f515

Diff:

Revision 2 (+180 -33)

Show changes

	reviewboard/settings.py
	reviewboard/admin/forms.py
	reviewboard/admin/siteconfig.py
	reviewboard/admin/support.py
	reviewboard/cmdline/rbsite.py

Tool: Pyflakes
Processed Files:
    reviewboard/admin/siteconfig.py
    reviewboard/admin/forms.py
    reviewboard/admin/support.py
    reviewboard/settings.py
    reviewboard/cmdline/rbsite.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/siteconfig.py
    reviewboard/admin/forms.py
    reviewboard/admin/support.py
    reviewboard/settings.py
    reviewboard/cmdline/rbsite.py

reviewboard/admin/siteconfig.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 15
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 32
 E241 multiple spaces after ':'
```
reviewboard/cmdline/rbsite.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 import 'choice' from line 17 shadowed by loop variable
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (e563d7e)