-
-
-
-
reviewboard/cmdline/rbsite.py (Diff revision 1) import 'choice' from line 17 shadowed by loop variable
-
reviewboard/settings.py (Diff revision 1) 'from settings_local import *' used; unable to detect undefined names
-
-
Update for the new support page infrastructure.
Review Request #6015 — Created June 22, 2014 and submitted
This updates Review Board to work with the new support infrastructure
being deployed on our servers.rb-site now asks for a Company name, which can also be provided later on
the General Settings page. This name will show up on the support page
when users visit it. We may also want to use this down the road to help
brand Review Board itself.rb-site will also ask for permission to collect support data, and
explain what we collect and how it's used. This can be changed later
through a checkbox on the Support Settings page. If allowed, rb-site
will up and maintain the support page on install and upgrade.
Set the company name on an existing server and saw that it saved.
Toggled the new checkbox for support data and saw that data was only set
when it was checked.Created a new site and entered a company name. Saw it was saved and showed up
in the support page.Tested various input for the permission check in install, and tested that they
had the expected outcome. Also tested this with the new --opt-out-support-data
option.
| Description | From | Last Updated |
|---|---|---|
|
Col: 15 E241 multiple spaces after ':' |
 reviewbot
|
|
|
Col: 32 E241 multiple spaces after ':' |
reviewbot
|
|
|
import 'choice' from line 17 shadowed by loop variable |
reviewbot
|
|
|
I'm not sure we should include the second sentence here. Maybe not even this paragraph at all. |
 david
|
|
|
'from settings_local import *' used; unable to detect undefined names |
reviewbot
|
|
|
'PIPELINE_CSS' imported but unused |
reviewbot
|
|
|
'PIPELINE_JS' imported but unused |
reviewbot
|
|
|
Col: 15 E241 multiple spaces after ':' |
reviewbot
|
|
|
Col: 32 E241 multiple spaces after ':' |
reviewbot
|
|
|
import 'choice' from line 17 shadowed by loop variable |
reviewbot
|
|
|
'from settings_local import *' used; unable to detect undefined names |
reviewbot
|
|
|
'PIPELINE_JS' imported but unused |
reviewbot
|
|
|
'PIPELINE_CSS' imported but unused |
reviewbot
|
-
-
reviewboard/cmdline/rbsite.py (Diff revision 1) I'm not sure we should include the second sentence here. Maybe not even this paragraph at all.
Change Summary:
Trying some new text on the support data page.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+180 -33) |
-
Tool: Pyflakes Processed Files: reviewboard/admin/siteconfig.py reviewboard/admin/forms.py reviewboard/admin/support.py reviewboard/settings.py reviewboard/cmdline/rbsite.py Tool: PEP8 Style Checker Processed Files: reviewboard/admin/siteconfig.py reviewboard/admin/forms.py reviewboard/admin/support.py reviewboard/settings.py reviewboard/cmdline/rbsite.py -
-
-
reviewboard/cmdline/rbsite.py (Diff revision 2) import 'choice' from line 17 shadowed by loop variable
-
reviewboard/settings.py (Diff revision 2) 'from settings_local import *' used; unable to detect undefined names
-
-
Tool: Pyflakes Processed Files: reviewboard/admin/siteconfig.py reviewboard/admin/forms.py reviewboard/admin/support.py reviewboard/settings.py reviewboard/cmdline/rbsite.py Tool: PEP8 Style Checker Processed Files: reviewboard/admin/siteconfig.py reviewboard/admin/forms.py reviewboard/admin/support.py reviewboard/settings.py reviewboard/cmdline/rbsite.py