Update for the new support page infrastructure.

Review Request #6015 — Created June 22, 2014 and submitted

Information

Review Board
release-2.0.x
bd4b283...

Reviewers

This updates Review Board to work with the new support infrastructure
being deployed on our servers.

rb-site now asks for a Company name, which can also be provided later on
the General Settings page. This name will show up on the support page
when users visit it. We may also want to use this down the road to help
brand Review Board itself.

rb-site will also ask for permission to collect support data, and
explain what we collect and how it's used. This can be changed later
through a checkbox on the Support Settings page. If allowed, rb-site
will up and maintain the support page on install and upgrade.

Set the company name on an existing server and saw that it saved.

Toggled the new checkbox for support data and saw that data was only set
when it was checked.

Created a new site and entered a company name. Saw it was saved and showed up
in the support page.

Tested various input for the permission check in install, and tested that they
had the expected outcome. Also tested this with the new --opt-out-support-data
option.

Description From Last Updated

Col: 15 E241 multiple spaces after ':'

reviewbotreviewbot

Col: 32 E241 multiple spaces after ':'

reviewbotreviewbot

import 'choice' from line 17 shadowed by loop variable

reviewbotreviewbot

I'm not sure we should include the second sentence here. Maybe not even this paragraph at all.

daviddavid

'from settings_local import *' used; unable to detect undefined names

reviewbotreviewbot

'PIPELINE_CSS' imported but unused

reviewbotreviewbot

'PIPELINE_JS' imported but unused

reviewbotreviewbot

Col: 15 E241 multiple spaces after ':'

reviewbotreviewbot

Col: 32 E241 multiple spaces after ':'

reviewbotreviewbot

import 'choice' from line 17 shadowed by loop variable

reviewbotreviewbot

'from settings_local import *' used; unable to detect undefined names

reviewbotreviewbot

'PIPELINE_JS' imported but unused

reviewbotreviewbot

'PIPELINE_CSS' imported but unused

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/admin/siteconfig.py
        reviewboard/admin/forms.py
        reviewboard/admin/support.py
        reviewboard/settings.py
        reviewboard/cmdline/rbsite.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/admin/siteconfig.py
        reviewboard/admin/forms.py
        reviewboard/admin/support.py
        reviewboard/settings.py
        reviewboard/cmdline/rbsite.py
    
    
  2. reviewboard/admin/siteconfig.py (Diff revision 1)
     
     
    Show all issues
    Col: 15
     E241 multiple spaces after ':'
    
  3. reviewboard/admin/siteconfig.py (Diff revision 1)
     
     
    Show all issues
    Col: 32
     E241 multiple spaces after ':'
    
  4. reviewboard/cmdline/rbsite.py (Diff revision 1)
     
     
    Show all issues
     import 'choice' from line 17 shadowed by loop variable
    
  5. reviewboard/settings.py (Diff revision 1)
     
     
    Show all issues
     'from settings_local import *' used; unable to detect undefined names
    
  6. reviewboard/settings.py (Diff revision 1)
     
     
    Show all issues
     'PIPELINE_CSS' imported but unused
    
  7. reviewboard/settings.py (Diff revision 1)
     
     
    Show all issues
     'PIPELINE_JS' imported but unused
    
  8. 
      
david
  1. 
      
  2. reviewboard/cmdline/rbsite.py (Diff revision 1)
     
     
     
     
    Show all issues

    I'm not sure we should include the second sentence here. Maybe not even this paragraph at all.

    1. My intent was to give some information as to why they'd want this so they understand there's a benefit to them. Any thoughts in that area?

    2. Maybe say that we use it to determine what versions we need to support, and to correlate the volume of bugs and support requests with upgrade cycles?

    3. Okay. Trying new text that covers a bit of both. The support page bit is useful for them, since it links to the correct docs for their version and provides contact info for their admins. So I want to continue to highlight that.

  3. 
      
chipx86
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/admin/siteconfig.py
        reviewboard/admin/forms.py
        reviewboard/admin/support.py
        reviewboard/settings.py
        reviewboard/cmdline/rbsite.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/admin/siteconfig.py
        reviewboard/admin/forms.py
        reviewboard/admin/support.py
        reviewboard/settings.py
        reviewboard/cmdline/rbsite.py
    
    
  2. reviewboard/admin/siteconfig.py (Diff revision 2)
     
     
    Show all issues
    Col: 15
     E241 multiple spaces after ':'
    
  3. reviewboard/admin/siteconfig.py (Diff revision 2)
     
     
    Show all issues
    Col: 32
     E241 multiple spaces after ':'
    
  4. reviewboard/cmdline/rbsite.py (Diff revision 2)
     
     
    Show all issues
     import 'choice' from line 17 shadowed by loop variable
    
  5. reviewboard/settings.py (Diff revision 2)
     
     
    Show all issues
     'from settings_local import *' used; unable to detect undefined names
    
  6. reviewboard/settings.py (Diff revision 2)
     
     
    Show all issues
     'PIPELINE_JS' imported but unused
    
  7. reviewboard/settings.py (Diff revision 2)
     
     
    Show all issues
     'PIPELINE_CSS' imported but unused
    
  8. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.0.x (e563d7e)