-
-
reviewboard/static/rb/css/admin.less (Diff revision 1) There's some trailing whitespace on this line.
-
reviewboard/static/rb/css/admin.less (Diff revision 1) Can you split this onto three lines?
.filtered { min-height: 545px !important; }
How did you come up with 545?
Ensure filtering menu is shown when viewing review requests in the admin section
Review Request #5433 — Created Feb. 8, 2014 and submitted
Information | |
---|---|
Joonas | |
Review Board | |
master | |
3222 | |
Reviewers | |
reviewboard, students | |
In the URL /admin/db/reviews/reviewrequest/ when you had a small number of review requests, the filtering menu was not fully shown. I changed the minimum height for the box displaying the review requests, thus also showing the filtering menu completely.
I checked that the UI looks fine on the Chrome and Firefox versions mentioned in the issue.
-
The code looks good now.
I'd like you to change your description a bit. The description should explain what the bug is, as well as how you fixed it. The goal is to be able to understand the change when loooking only at the git log, without having to click through to the bug tracker.
Please also add the bug number in the "Bugs" field.
Summary: |
|
||||||
---|---|---|---|---|---|---|---|
Description: |
|
||||||
Bugs: |
|
||||||
Diff: |
Revision 3 (+4) |