Ensure filtering menu is shown when viewing review requests in the admin section

Review Request #5433 — Created Feb. 8, 2014 and submitted

Information

Review Board
master

Reviewers

In the URL /admin/db/reviews/reviewrequest/ when you had a small number of review requests, the filtering menu was not fully shown. I changed the minimum height for the box displaying the review requests, thus also showing the filtering menu completely.

I checked that the UI looks fine on the Chrome and Firefox versions mentioned in the issue.


Description From Last Updated

There's some trailing whitespace on this line.

daviddavid

Can you split this onto three lines? .filtered { min-height: 545px !important; } How did you come up with 545?

daviddavid
david
  1. I have a couple style comments:

  2. reviewboard/static/rb/css/admin.less (Diff revision 1)
     
     

    There's some trailing whitespace on this line.

  3. reviewboard/static/rb/css/admin.less (Diff revision 1)
     
     

    Can you split this onto three lines?

    .filtered {
      min-height: 545px !important;
    }
    

    How did you come up with 545?

    1. 545px just looked nice on Chrome and it also leaves some space to add filtering options without the need to change the min-length again.

  4. 
      
JO
david
  1. The code looks good now.

    I'd like you to change your description a bit. The description should explain what the bug is, as well as how you fixed it. The goal is to be able to understand the change when loooking only at the git log, without having to click through to the bug tracker.

    Please also add the bug number in the "Bugs" field.

  2. 
      
JO
david
  1. Ship It!

  2. 
      
JO
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (0bfc5e8). Thanks!
Loading...