Summary

Ensure filtering menu is shown when viewing review requests in the admin section

Review Request #5433 — Created Feb. 8, 2014 and submitted Feb. 8, 2014, 2:59 p.m.

Information

Owner

Joonas

Repository

Review Board

Branch

master

Bugs

3222

Depends On

Reviewers

Groups

reviewboard, students

People

Description

In the URL /admin/db/reviews/reviewrequest/ when you had a small number of review requests, the filtering menu was not fully shown. I changed the minimum height for the box displaying the review requests, thus also showing the filtering menu completely.

Testing Done

I checked that the UI looks fine on the Chrome and Firefox versions mentioned in the issue.

Files

Issues

Description	From	Last Updated
There's some trailing whitespace on this line.	david	Feb. 8, 2014, 11:36 a.m.
Can you split this onto three lines? .filtered { min-height: 545px !important; } How did you come up with 545?	david	Feb. 8, 2014, 11:36 a.m.

```
I have a couple style comments:
```
reviewboard/static/rb/css/admin.less (Diff revision 1)
The issue has been resolved. Show all issues
```
There's some trailing whitespace on this line.
```

reviewboard/static/rb/css/admin.less (Diff revision 1)

The issue has been resolved. Show all issues

Can you split this onto three lines?

.filtered {
  min-height: 545px !important;
}


How did you come up with 545?

Joonas Feb. 8, 2014, 11:36 a.m.

545px just looked nice on Chrome and it also leaves some space to add filtering options without the need to change the min-length again.

Diff:

Revision 2 (+4)

Show changes

reviewboard/static/rb/css/admin.less

The code looks good now.

I'd like you to change your description a bit. The description should explain what the bug is, as well as how you fixed it. The goal is to be able to understand the change when loooking only at the git log, without having to click through to the bug tracker.

Please also add the bug number in the "Bugs" field.

Summary:

Issue #3222 fixed by setting up a larger min-height for the box listing the review requests.

Ensure filtering menu is shown when viewing review requests in the admin section

Description:

~		Issue #3222 fixed by setting up a larger min-height for the box listing the review requests.
	~	In the URL /admin/db/reviews/reviewrequest/ when you had a small number of review requests, the filtering menu was not fully shown. I changed the minimum height for the box displaying the review requests, thus also showing the filtering menu completely.

Bugs:

3222

Diff:

Revision 3 (+4)

Show changes

reviewboard/static/rb/css/admin.less

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (0bfc5e8). Thanks!