Change Summary:
Another paste-o :(
Summary: |
|
|||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
Review Request #4968 — Created Nov. 15, 2013 and submitted
Perform unicode migration for reviewboard/scmtools
This change represents an audit of all of our string literals to make sure that
bytestrings are annotated with a leading 'b', and then adds
"from __future__ import unicode_literals
" to the beginning of every non-empty
file.This also includes some changes to use
six.text_type
for python 2/3
compatibility, marking some additional strings for translation, and changes
some file opens to use 'with
'.
Ran unit tests.
Another paste-o :(
Summary: |
|
|||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
reviewboard/scmtools/git.py (Diff revision 1) |
---|
Why is
six.text_type
needed here? Surely_()
is sufficient?