Summary

Perform unicode migration for reviewboard/scmtools

Review Request #4968 — Created Nov. 15, 2013 and submitted Nov. 15, 2013, 11:16 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Perform unicode migration for reviewboard/scmtools
This change represents an audit of all of our string literals to make sure that

bytestrings are annotated with a leading 'b', and then adds

"from __future__ import unicode_literals" to the beginning of every non-empty

file.
This also includes some changes to use six.text_type for python 2/3

compatibility, marking some additional strings for translation, and changes

some file opens to use 'with'.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Swap these.	chipx86	Nov. 15, 2013, 6:31 p.m.
Why is six.text_type needed here? Surely _() is sufficient?	chipx86	Nov. 15, 2013, 6:17 p.m.

Change Summary:: Another paste-o :(
Summary:: Perform unicode migration for reviewboard/reviews
Perform unicode migration for reviewboard/scmtools
Description:: ~
Perform unicode migration for reviewboard/reviews
~
Perform unicode migration for reviewboard/scmtools

This change represents an audit of all of our string literals to make sure that
bytestrings are annotated with a leading 'b', and then adds
"from __future__ import unicode_literals" to the beginning of every non-empty
file.

This also includes some changes to use six.text_type for python 2/3
compatibility, marking some additional strings for translation, and changes
some file opens to use 'with'.

reviewboard/scmtools/core.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Swap these.
```

reviewboard/scmtools/git.py (Diff revision 1)

The issue has been dropped. Show all issues

Why is six.text_type needed here? Surely _() is sufficient?

david Nov. 15, 2013, 6:17 p.m.

_() returns a functional.__proxy__ object, which can be coerced to unicode, but this particular code path didn't do that coersion, opting instead to raise a ValueError.

Diff:

Revision 2 (+418 -329)

Show changes

	reviewboard/scmtools/admin.py
	reviewboard/scmtools/bzr.py
	reviewboard/scmtools/certs.py
	reviewboard/scmtools/clearcase.py
	reviewboard/scmtools/core.py
	reviewboard/scmtools/crypto_utils.py
	reviewboard/scmtools/cvs.py
	reviewboard/scmtools/errors.py
	25 more

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (cc82e59)

~		Perform unicode migration for reviewboard/reviews
	~	Perform unicode migration for reviewboard/scmtools

		This change represents an audit of all of our string literals to make sure that
		bytestrings are annotated with a leading 'b', and then adds
		"`from __future__ import unicode_literals`" to the beginning of every non-empty
		file.

		This also includes some changes to use `six.text_type` for python 2/3
		compatibility, marking some additional strings for translation, and changes
		some file opens to use '`with`'.