Fix so users with apostrophes won't cause 500 errors.

Review Request #4606 — Created Sept. 20, 2013 and submitted

Information

Review Board
master

Reviewers

Fix so users with apostrophes won't cause 500 errors.

It's possible to get a user with an apostrophe due to active directory.
This change allows the regex to recognize these users.

I created a user with an apostrophe in the name and went through the steps to reproduce the problem (going to users page, as well as trying to assign the apostrophe user to a review). 500 errors were no longer thrown after my changes.

Description From Last Updated

Probably don't need to escape the ', now that you're using double quotes.

chipx86chipx86
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    reviewboard/urls.py
    Ignored Files:

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    reviewboard/urls.py
    Ignored Files:

  2. 
      
chipx86
  1. 
      
  2. reviewboard/urls.py (Diff revision 1)
     
     
     
     
    Show all issues

    Probably don't need to escape the ', now that you're using double quotes.

  3. 
      
AS
mike_conley
  1. Bump - do you still have time to see this through, Allisa? There's still an open issue.

  2. 
      
AS
david
  1. Ship It!
  2. 
      
AS
Review request changed
Status:
Completed
Change Summary:
Pushed to release-1.7.x (c8bcf59). Thanks!