2890: Error 500 - NoReverseMatch failure with usernames containing single-quote character

ric****@glidd****** (Google Code) (Is this you? Claim this profile.)
Nov. 26, 2013
What version are you running?
1.6.4.1

What's the URL of the page containing the problem?
http://reviewboard.brockhome.net/users/
Any review assigned to that user.

What steps will reproduce the problem?
1. Create a user account with an ' in it.
2. View the Submitters page, or attempt to assign a review to that user account.
3.

What is the expected output? What do you see instead?
Either it should not be possible to create a user with a ' in their name, or the system should work as expected.  Error 500 should not be generated.

What operating system are you using? What browser?
Client: Windows 7, Chrome 24.0.1312.57 m
Server: Ubuntu 10.04.3 LTS

Please provide any additional information below.

ReviewBoard is authenticating against Active Directory.  User's account is entered in Active Directory with a ' in the user id.

Error email generated when the 500 error occurs is attached.
david
#1 david
  • +Component-Dashboard
    +EasyFix
#2 Caffeina*********@gmai***** (Google Code) (Is this you? Claim this profile.)
I'll fix this one. Decided that we're just going to disable the ability to have single quotes in usernames.
#3 ric****@glidd****** (Google Code) (Is this you? Claim this profile.)
Thanks.  How do you plan to handle databases that have existing users with single quotes in their name during an upgrade?
david
#4 david
Fixed in release-1.7.x (c8bcf59).

We ended up just changing the URLs for the user pages to include quotes, so existing users won't be affected.
  • +Fixed