Add a URL link for extension authors, and make the page more stylable.

Review Request #4282 — Created July 3, 2013 and submitted

Information

Djblets
master

Reviewers

Add a URL link for extension authors, and make the page more stylable.

The extensions list page now links the author to the extension's URL, if
one is available.

The name, version and author are now grouped together in a div that can
be styled. The page also has a class so that decisions can be made
involving the overall style of the extensions list page.

There's also now an author_url field (mapping to 'Author-home-page')
that extensions can provide in Extension.metadata for specifying the
URL for the author's site, for the link. By default, this will point to
the extension's URL (which is generally the project page for the
extension).
Looked at the page on an RB install without any changes for these new classes.
Everything looked the same.

Tested with a change that improves the look of the extensions list page.
Description From Last Updated

It seems like extensions might want to have a URL that's separate from the author. Is it possible to have …

daviddavid
david
  1. 
      
  2. Show all issues
    It seems like extensions might want to have a URL that's separate from the author. Is it possible to have separate url and author_url fields?
    1. Yeah, I'd like to do something like that and add some more info to the list as well. I'm trying not to alter the content or layout in a meaningful way right now, since I want this to go in for the RBE build without bumping RB. After that, I'm happy to make some larger changes. (I actually had more and it looked terrible with RB, so I reverted everything.)
    2. I guess what I'm saying is that even if you don't add "url" now, if you want to make the author a link, I'd call the field author_url. It's going to be annoying for backwards compatibility if people start using url for their authors, otherwise.
    3. I don't know where this field would come from. These fields all map to Python egg metadata, and they don't have such a concept. There's Author, Author E-Mail, and URL. No Author URL, or Company, or anything like that.
    4. The standard, as far as I see anywhere, is to use Author for the company name, and URL for either the company's URL or the product's URL. Doesn't seem to get any more fine-grained than that.
    5. I guess it's okay, but I'd like to officially note my grumbles with egg metadata.
    6. Understood. At least now extensions can override these fields.
      
      I'm not opposed to adding an Author-URL metadata in the custom metadata dict and using that if provided.  author_url could use that if provided, and fall back on 'url' ('Home Page').
  3. 
      
david
  1. Ship It!
  2. 
      
chipx86
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        djblets/extensions/base.py
      Ignored Files:
        djblets/extensions/templates/extensions/extension_list.html
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        djblets/extensions/base.py
      Ignored Files:
        djblets/extensions/templates/extensions/extension_list.html
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed