Summary

Add a URL link for extension authors, and make the page more stylable.

Review Request #4282 — Created July 3, 2013 and submitted July 8, 2013, 2:07 a.m.

Information

Owner

chipx86

Repository

Djblets

Branch

master

Bugs

Depends On

Blocks

4283

Reviewers

Groups

djblets

People

Description

Add a URL link for extension authors, and make the page more stylable.

The extensions list page now links the author to the extension's URL, if
one is available.

The name, version and author are now grouped together in a div that can
be styled. The page also has a class so that decisions can be made
involving the overall style of the extensions list page.

There's also now an author_url field (mapping to 'Author-home-page')
that extensions can provide in Extension.metadata for specifying the
URL for the author's site, for the link. By default, this will point to
the extension's URL (which is generally the project page for the
extension).

Testing Done

Looked at the page on an RB install without any changes for these new classes.
Everything looked the same.

Tested with a change that improves the look of the extensions list page.

Issues

Description	From	Last Updated
It seems like extensions might want to have a URL that's separate from the author. Is it possible to have …	david	July 3, 2013, 2:04 a.m.

Fix it!

djblets/extensions/templates/extensions/extension_list.html (Diff revision 1)

An issue was opened. Show all issues

It seems like extensions might want to have a URL that's separate from the author. Is it possible to have separate url and author_url fields?

chipx86 July 3, 2013, 2:25 a.m.

Yeah, I'd like to do something like that and add some more info to the list as well. I'm trying not to alter the content or layout in a meaningful way right now, since I want this to go in for the RBE build without bumping RB. After that, I'm happy to make some larger changes. (I actually had more and it looked terrible with RB, so I reverted everything.)

david July 5, 2013, 5:24 p.m.

I guess what I'm saying is that even if you don't add "url" now, if you want to make the author a link, I'd call the field author_url. It's going to be annoying for backwards compatibility if people start using url for their authors, otherwise.

chipx86 July 5, 2013, 5:29 p.m.

I don't know where this field would come from. These fields all map to Python egg metadata, and they don't have such a concept. There's Author, Author E-Mail, and URL. No Author URL, or Company, or anything like that.

chipx86 July 5, 2013, 5:33 p.m.

The standard, as far as I see anywhere, is to use Author for the company name, and URL for either the company's URL or the product's URL. Doesn't seem to get any more fine-grained than that.

david July 5, 2013, 5:36 p.m.

I guess it's okay, but I'd like to officially note my grumbles with egg metadata.

chipx86 July 5, 2013, 5:38 p.m.

Understood. At least now extensions can override these fields.

I'm not opposed to adding an Author-URL metadata in the custom metadata dict and using that if provided.  author_url could use that if provided, and fall back on 'url' ('Home Page').

Ship it!

```
Ship It!
```

Change Summary:

Added an author_url field (mapping to Extension.metadata['Author-home-page'])

Description:

		Add a URL link for extension authors, and make the page more stylable.

		The extensions list page now links the author to the extension's URL, if
		one is available.

		The name, version and author are now grouped together in a div that can
		be styled. The page also has a class so that decisions can be made
		involving the overall style of the extensions list page.
	+
	+	There's also now an author_url field (mapping to 'Author-home-page')
	+	that extensions can provide in Extension.metadata for specifying the
	+	URL for the author's site, for the link. By default, this will point to
	+	the extension's URL (which is generally the project page for the
	+	extension).

Diff:

Revision 2 (+15 -2)

Show changes

	djblets/extensions/base.py
	djblets/extensions/templates/extensions/extension_list.html

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    djblets/extensions/base.py
  Ignored Files:
    djblets/extensions/templates/extensions/extension_list.html

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    djblets/extensions/base.py
  Ignored Files:
    djblets/extensions/templates/extensions/extension_list.html

Ship it!

```
Ship It!
```

Status:: Completed