This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: rbtools/commands/post.py rbtools/commands/diff.py Ignored Files:
Fix rbt post and diff for certain SCM clients.
Review Request #4111 — Created May 7, 2013 and submitted
Fix rbt post and diff for certain SCM clients. post-review provided the command line arguments to SCM clients as a list. Each rbt command is provided the arguments as a tuple, which was being passed on to the SCM clients. Since some of these clients attempt to concatenate the tuple onto the end of a list, errors were occuring. We now make the command line arguments into a list immediately in post and diff. This should fix bugs when using rbt with both svn and bazzar (possibly other clients as well).
Ran rbt commands and posted reviews.
I wish we could transform these before calling main, but I know that's not how *args works. Ideally this wouldn't need to be done for every tool out there. How many cases do we know of where this breaks? Can we do a list() in those places?