Summary

Fix rbt post and diff for certain SCM clients.

Review Request #4111 — Created May 7, 2013 and submitted May 8, 2013, 12:12 p.m.

Information

Owner

smacleod

Repository

RBTools

Branch

master

Bugs

2967

Depends On

Reviewers

Groups

rbtools

People

Description

Fix rbt post and diff for certain SCM clients.

post-review provided the command line arguments to SCM clients as a
list. Each rbt command is provided the arguments as a tuple, which was
being passed on to the SCM clients. Since some of these clients
attempt to concatenate the tuple onto the end of a list, errors were
occuring.

We now make the command line arguments into a list immediately in post
and diff. This should fix bugs when using rbt with both svn and bazzar
(possibly other clients as well).

Testing Done

Ran rbt commands and posted reviews.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    rbtools/commands/post.py
    rbtools/commands/diff.py
  Ignored Files:

I wish we could transform these before calling main, but I know that's not how *args works. Ideally this wouldn't need to be done for every tool out there. How many cases do we know of where this breaks? Can we do a list() in those places?

smacleod May 7, 2013, 11:55 a.m.

I spent about 25 seconds searching and found 3 places, so I figured I'd just go with this quick fix for now, and deal with everything as I work on the SCM client code.

chipx86 May 7, 2013, 12:02 p.m.

Okay, that's fine. My only concern is third-party clients having the same breakage, but so long as we have a plan for fixing the root cause, I'm good. Ship it!

Status: Closed (submitted)

Change Summary:

Pushed to master and release-0.5.x (a8f4db54db3fe1058423c7280c5b825016edeeff).